mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-02 04:56:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

cql3: select_statement: mutation_fragments_select_statement: fix use-after-return

Browse Source 
Don't capture stack variables by reference... it can (and will) explode
in your face.
This commit is contained in:
Botond Dénes
2024-02-28 06:46:48 -05:00
parent 616eec2214
commit c228e4d518
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cql3/statements/select_statement.cc
View File

@@ -1761,7 +1761,7 @@ mutation_fragments_select_statement::do_execute(query_processor& qp, service::qu
*command, key_ranges))) {
return do_query({}, qp.proxy(), _schema, command, std::move(key_ranges), cl,
{timeout, state.get_permit(), state.get_client_state(), state.get_trace_state(), {}, {}})
.then(wrap_result_to_error_message([&, this, erm_keepalive] (service::storage_proxy_coordinator_query_result&& qr) {
.then(wrap_result_to_error_message([this, erm_keepalive, now, slice = command->slice] (service::storage_proxy_coordinator_query_result&& qr) mutable {
cql3::selection::result_set_builder builder(*_selection, now);
query::result_view::consume(*qr.query_result, std::move(slice),
cql3::selection::result_set_builder::visitor(builder, *_schema, *_selection));