mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

cql3: Add expr::index_supports_some_column

Browse Source 
Add a function that checks if there is an index
which supports one of the columns present in
the given expression.

This functionality will soon be needed for
clustering and nonprimary columns so it's
good to separate into a reusable function.

Signed-off-by: Jan Ciolek <jan.ciolek@scylladb.com>
This commit is contained in:
Jan Ciolek
2022-07-14 16:52:10 +02:00
parent c2d20adc49
commit c7495fa59e
3 changed files with 23 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cql3/expr/expression.cc
View File

@@ -1028,6 +1028,21 @@ bool has_supporting_index(
support);
}
bool index_supports_some_column(
const expression& e,
const secondary_index::secondary_index_manager& index_manager,
allow_local_index allow_local) {
single_column_restrictions_map single_col_restrictions = get_single_column_restrictions_map(e);
for (auto&& [col, col_restrictions] : single_col_restrictions) {
if (has_supporting_index(col_restrictions, index_manager, allow_local)) {
return true;
}
}
return false;
}
std::ostream& operator<<(std::ostream& os, const column_value& cv) {
os << cv.col->name_as_text();
return os;

7
cql3/expr/expression.hh
View File

@@ -499,6 +499,13 @@ extern bool is_supported_by(const expression&, const secondary_index::index&);
extern bool has_supporting_index(
const expression&, const secondary_index::secondary_index_manager&, allow_local_index allow_local);
// Looks at each column indivudually and checks whether some index can support restrictions on this single column.
// Expression has to consist only of single column restrictions.
extern bool index_supports_some_column(
const expression&,
const secondary_index::secondary_index_manager&,
allow_local_index allow_local);
extern sstring to_string(const expression&);
extern std::ostream& operator<<(std::ostream&, const column_value&);

15
cql3/restrictions/statement_restrictions.cc
View File

@@ -881,20 +881,7 @@ bool statement_restrictions::parition_key_restrictions_have_supporting_index(con
return false;
}
// Otherwise those are single column restrictions
std::vector<const column_definition*> restricted_pk_columns = expr::get_sorted_column_defs(_partition_key_restrictions);
for (const column_definition* cdef : restricted_pk_columns) {
expr::expression col_restrictions = expr::conjunction {
.children = expr::extract_single_column_restrictions_for_column(_partition_key_restrictions, *cdef)
};
if (expr::has_supporting_index(col_restrictions, index_manager, allow_local)) {
return true;
}
}
return false;
return expr::index_supports_some_column(_partition_key_restrictions, index_manager, allow_local);
}
void statement_restrictions::process_clustering_columns_restrictions(bool for_view, bool allow_filtering) {