mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-13 03:12:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools/scylla-nodetool: use constexpr for compile-time format check

Browse Source 
instead of using fmt::runtime format string, use compile-time
format string, so that we can have compile-time format check provided
by {fmt}.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb/scylladb#17709
This commit is contained in:
Kefu Chai
2024-03-06 18:11:40 +08:00
committed by Botond Dénes
parent af90910687
commit ca7b73f34e
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/scylla-nodetool.cc
View File

@@ -689,14 +689,14 @@ void getendpoints_operation(scylla_rest_client& client, const bpo::variables_map
void getlogginglevels_operation(scylla_rest_client& client, const bpo::variables_map& vm) {
auto res = client.get("/storage_service/logging_level");
const auto row_format = "{:<50}{:>10}\n";
constexpr auto row_format = "{:<50}{:>10}\n";
fmt::print(std::cout, "\n");
fmt::print(std::cout, fmt::runtime(row_format), "Logger Name", "Log Level");
fmt::print(std::cout, row_format, "Logger Name", "Log Level");
for (const auto& element : res.GetArray()) {
const auto& logger_obj = element.GetObject();
fmt::print(
std::cout,
fmt::runtime(row_format),
row_format,
rjson::to_string_view(logger_obj["key"]),
rjson::to_string_view(logger_obj["value"]));
}
@@ -1264,7 +1264,7 @@ void print_dc(scylla_rest_client& client,
fmt::print("\n"
"Datacenter: {}\n"
"==========\n", dc);
const auto fmt_str = fmt::runtime("{:<{}} {:<12}{:<7}{:<8}{:<16}{:<20}{:<44}\n");
constexpr auto fmt_str = "{:<{}} {:<12}{:<7}{:<8}{:<16}{:<20}{:<44}\n";
const auto max_endpoint_width = std::invoke([&] {
auto stat_with_max_addr_width = std::ranges::max_element(
host_stats,