mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-30 19:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: use BOOST_CHECK_EQUAL when appropriate in compaction_manager_basic_test

Browse Source 
compaction_manager_basic_test checks the stats of compaction_manager to
verify that there are no ongoing or pending compactions after the triggering
the compaction and waiting for its completion. but in #14865, there are
still active compaction(s) after the compaction_manager's stats shows there
is at least one task completed.

to understand this issue better, let's use `BOOST_CHECK_EQUAL()` instead
of `BOOST_REQUIRE()`, so that the test does not error out when the check
fails, and we can have better understanding of the status when the test
fails.

Refs #14865
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes #14872
This commit is contained in:
Kefu Chai
2023-07-28 18:50:51 +08:00
committed by Botond Dénes
parent 3a51053e66
commit cc2bbde8f1
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/boost/sstable_compaction_test.cc
View File

@@ -178,13 +178,14 @@ SEASTAR_TEST_CASE(compaction_manager_basic_test) {
return sleep(std::chrono::milliseconds(100));
}).wait();
// test no more running compactions
BOOST_REQUIRE(cm.get_stats().pending_tasks == 0 && cm.get_stats().active_tasks == 0);
BOOST_CHECK_EQUAL(cm.get_stats().pending_tasks, 0);
BOOST_CHECK_EQUAL(cm.get_stats().active_tasks, 0);
// test compaction successfully finished
BOOST_REQUIRE(cm.get_stats().completed_tasks == 1);
BOOST_REQUIRE(cm.get_stats().errors == 0);
BOOST_CHECK_EQUAL(cm.get_stats().completed_tasks, 1);
BOOST_CHECK_EQUAL(cm.get_stats().errors, 0);
// expect sstables of cf to be compacted.
BOOST_REQUIRE(cf->sstables_count() == 1);
BOOST_CHECK_EQUAL(cf->sstables_count(), 1);
});
}