mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 19:21:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

test/nodetool: bind JMX to per-module loopback IP

Browse Source 
The Cassandra nodetool fixture picked a random JMX port on 127.0.0.1,
which can collide with unrelated listeners and has a TOCTOU race
between port selection and bind.

Bind JMX to the per-module loopback IP with the standard port 7199
instead.  Set java.rmi.server.hostname so the RMI endpoint stays on
the same leased address.
This commit is contained in:
Piotr Smaron
2026-05-25 14:49:47 +02:00
parent 8fd946c649
commit e441ce2fd9
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/nodetool/conftest.py
View File

@@ -134,11 +134,9 @@ def jmx(request, rest_api_mock_server):
response=[])]
set_expected_requests(rest_api_mock_server, expected_requests)
# Our nodetool launcher script ignores the host param, so this has to be 127.0.0.1, matching the internal default.
jmx_ip = "127.0.0.1"
jmx_port = random.randint(10000, 65535)
while jmx_port == api_port:
jmx_port = random.randint(10000, 65535)
# Bind JMX to the same per-module loopback IP as the REST mock.
jmx_ip = ip
jmx_port = 7199
jmx_process = subprocess.Popen(
[
@@ -147,6 +145,7 @@ def jmx(request, rest_api_mock_server):
"-p", str(api_port),
"-ja", jmx_ip,
"-jp", str(jmx_port),
f"-Djava.rmi.server.hostname={jmx_ip}",
],
cwd=workdir, text=True)