mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-12 19:02:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

table: Guarantee serialization of every sstable set updates

Browse Source 
Continuing the work from e4eb7df1a1, let's guarantee
serialization of sstable set updates by making all sites acquire
the mutation permit. Then table no longer rely on serialization
mechanism of row cache's update functions.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20210728174740.78826-1-raphaelsc@scylladb.com>
This commit is contained in:
Raphael S. Carvalho
2021-07-28 14:47:40 -03:00
committed by Avi Kivity
parent 4764028cb3
commit eb16268768
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
table.cc
View File

@@ -387,7 +387,8 @@ void table::enable_off_strategy_trigger() {
future<>
table::add_sstable_and_update_cache(sstables::shared_sstable sst, sstables::offstrategy offstrategy) {
return get_row_cache().invalidate(row_cache::external_updater([this, sst, offstrategy] () noexcept {
auto permit = co_await seastar::get_units(_sstable_set_mutation_sem, 1);
co_return co_await get_row_cache().invalidate(row_cache::external_updater([this, sst, offstrategy] () noexcept {
// FIXME: this is not really noexcept, but we need to provide strong exception guarantees.
// atomically load all opened sstables into column family.
if (!offstrategy) {
@@ -401,6 +402,7 @@ table::add_sstable_and_update_cache(sstables::shared_sstable sst, sstables::offs
future<>
table::update_cache(lw_shared_ptr<memtable> m, std::vector<sstables::shared_sstable> ssts) {
auto permit = co_await seastar::get_units(_sstable_set_mutation_sem, 1);
mutation_source_opt ms_opt;
if (ssts.size() == 1) {
ms_opt = ssts.front()->as_mutation_source();
@@ -420,9 +422,9 @@ table::update_cache(lw_shared_ptr<memtable> m, std::vector<sstables::shared_ssta
try_trigger_compaction();
});
if (cache_enabled()) {
return _cache.update(std::move(adder), *m);
co_return co_await _cache.update(std::move(adder), *m);
} else {
return _cache.invalidate(std::move(adder)).then([m] { return m->clear_gently(); });
co_return co_await _cache.invalidate(std::move(adder)).then([m] { return m->clear_gently(); });
}
}