mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-04 22:13:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

db::commitlog: Add optional replay_position sieve to min_gc_time

Browse Source 
Allows filtering out timestamps by replay position (i.e. skip
some segments)
This commit is contained in:
Calle Wilund
2026-05-12 10:15:24 +02:00
parent bf445d97e5
commit eef16c096c
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
db/commitlog/commitlog.cc
View File

@@ -488,7 +488,7 @@ public:
future<std::vector<descriptor>> list_descriptors(sstring dir) const;
future<std::vector<sstring>> get_segments_to_replay() const;
gc_clock::time_point min_gc_time(const cf_id_type&) const;
gc_clock::time_point min_gc_time(const cf_id_type&, const db::replay_position&) const;
flush_handler_id add_flush_handler(flush_handler h) {
auto id = ++_flush_ids;
@@ -2053,9 +2053,12 @@ future<std::vector<sstring>> db::commitlog::segment_manager::get_segments_to_rep
co_return segments_to_replay;
}
gc_clock::time_point db::commitlog::segment_manager::min_gc_time(const cf_id_type& id) const {
gc_clock::time_point db::commitlog::segment_manager::min_gc_time(const cf_id_type& id, const db::replay_position& rp) const {
auto res = gc_clock::time_point::max();
for (auto& s : _segments) {
if (rp.valid() && replay_position(s->_desc.id, s->position()) <= rp) {
continue;
}
res = std::min(res, s->min_time(id));
}
return res;
@@ -3956,8 +3959,8 @@ future<std::vector<sstring>> db::commitlog::list_existing_segments(const sstring
});
}
gc_clock::time_point db::commitlog::min_gc_time(const cf_id_type& id) const {
return _segment_manager->min_gc_time(id);
gc_clock::time_point db::commitlog::min_gc_time(const cf_id_type& id, const db::replay_position& rp) const {
return _segment_manager->min_gc_time(id, rp);
}
db::replay_position db::commitlog::min_position() const {

6
db/commitlog/commitlog.hh
View File

@@ -375,7 +375,11 @@ public:
future<std::vector<sstring>> list_existing_segments() const;
future<std::vector<sstring>> list_existing_segments(const sstring& dir) const;
gc_clock::time_point min_gc_time(const cf_id_type&) const;
/**
* Gets the recorded min timestamp for the given id. Optionally filter by
* replay position, i.e. skip segments that have top position <= rp_filter
*/
gc_clock::time_point min_gc_time(const cf_id_type&, const db::replay_position& rp_filter = {}) const;
// Return the lowest possible replay position across all existing or future commitlog segments.
// In other words, only positions greater or equal to min_position() can