mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 19:21:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

config: mark query timeouts live update-able

Browse Source 
in this change, following query timeouts config options are marked
live update-able:

- range_request_timeout_in_ms
- read_request_timeout_in_ms
- counter_write_request_timeout_in_ms
- cas_contention_timeout_in_ms
- truncate_request_timeout_in_ms
- write_request_timeout_in_ms
- request_timeout_in_ms

as per https://github.com/scylladb/scylladb/issues/10172,

> Many users would like to set the driver timers based on server timers.
> For example: expire a read timeout before or after the server read time
> out.

with this change, these options are *marked* live-updateable, but since
they are cached by their consumers locally, so we will have another commit
to update the local copies when these options get updated.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
This commit is contained in:
Kefu Chai
2023-01-15 23:39:07 +08:00
parent 1cc28679bc
commit f789d8d3cd
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
db/config.cc
View File

@@ -566,20 +566,20 @@ db::config::config(std::shared_ptr<db::extensions> exts)
, query_tombstone_page_limit(this, "query_tombstone_page_limit", liveness::LiveUpdate, value_status::Used, 10000,
"The number of tombstones after which a query cuts a page, even if not full or even empty.")
/* Network timeout settings */
, range_request_timeout_in_ms(this, "range_request_timeout_in_ms", value_status::Used, 10000,
, range_request_timeout_in_ms(this, "range_request_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 10000,
"The time in milliseconds that the coordinator waits for sequential or index scans to complete.")
, read_request_timeout_in_ms(this, "read_request_timeout_in_ms", value_status::Used, 5000,
, read_request_timeout_in_ms(this, "read_request_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 5000,
"The time that the coordinator waits for read operations to complete")
, counter_write_request_timeout_in_ms(this, "counter_write_request_timeout_in_ms", value_status::Used, 5000,
, counter_write_request_timeout_in_ms(this, "counter_write_request_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 5000,
"The time that the coordinator waits for counter writes to complete.")
, cas_contention_timeout_in_ms(this, "cas_contention_timeout_in_ms", value_status::Used, 1000,
, cas_contention_timeout_in_ms(this, "cas_contention_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 1000,
"The time that the coordinator continues to retry a CAS (compare and set) operation that contends with other proposals for the same row.")
, truncate_request_timeout_in_ms(this, "truncate_request_timeout_in_ms", value_status::Used, 60000,
, truncate_request_timeout_in_ms(this, "truncate_request_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 60000,
"The time that the coordinator waits for truncates (remove all data from a table) to complete. The long default value allows for a snapshot to be taken before removing the data. If auto_snapshot is disabled (not recommended), you can reduce this time.")
, write_request_timeout_in_ms(this, "write_request_timeout_in_ms", value_status::Used, 2000,
, write_request_timeout_in_ms(this, "write_request_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 2000,
"The time in milliseconds that the coordinator waits for write operations to complete.\n"
"Related information: About hinted handoff writes")
, request_timeout_in_ms(this, "request_timeout_in_ms", value_status::Used, 10000,
, request_timeout_in_ms(this, "request_timeout_in_ms", liveness::LiveUpdate, value_status::Used, 10000,
"The default timeout for other, miscellaneous operations.\n"
"Related information: About hinted handoff writes")
/* Inter-node settings */