mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-01 12:36:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

sstables: Support writing counters for SSTables 3.x.

Browse Source 
Signed-off-by: Vladimir Krivopalov <vladimir@scylladb.com>
This commit is contained in:
Vladimir Krivopalov
2018-05-15 11:13:45 -07:00
parent 28c3c21c73
commit ffd8886da9
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
sstables/sstables.cc
View File

@@ -1702,13 +1702,15 @@ static inline void update_cell_stats(column_stats& c_stats, api::timestamp_type
c_stats.cells_count++;
}
static void write_counter_value(counter_cell_view ccv, file_writer& out, sstable_version_types v) {
template <typename WriteLengthFunc>
static void write_counter_value(counter_cell_view ccv, file_writer& out, sstable_version_types v, WriteLengthFunc&& write_len_func) {
auto shard_count = ccv.shard_count();
static constexpr auto header_entry_size = sizeof(int16_t);
static constexpr auto counter_shard_size = 32u; // counter_id: 16 + clock: 8 + value: 8
auto total_size = sizeof(int16_t) + shard_count * (header_entry_size + counter_shard_size);
write(v, out, int32_t(total_size), int16_t(shard_count));
write_len_func(out, uint32_t(total_size));
write(v, out, int16_t(shard_count));
for (auto i = 0u; i < shard_count; i++) {
write<int16_t>(v, out, std::numeric_limits<int16_t>::min() + i);
}
@@ -1754,7 +1756,9 @@ void sstable::write_cell(file_writer& out, atomic_cell_view cell, const column_d
write(_version, out, mask, int64_t(0), timestamp);
counter_cell_view ccv(cell);
write_counter_value(ccv, out, _version);
write_counter_value(ccv, out, _version, [v = _version] (file_writer& out, uint32_t value) {
return write(v, out, value);
});
_c_stats.update_local_deletion_time(std::numeric_limits<int>::max());
} else if (cell.is_live_and_has_ttl()) {
@@ -2852,7 +2856,15 @@ void sstable_writer_m::write_cell(file_writer& writer, atomic_cell_view cell, co
}
if (has_value) {
write_cell_value(writer, *cdef.type, cell.value());
if (cdef.is_counter()) {
assert(!cell.is_counter_update());
counter_cell_view ccv(cell);
write_counter_value(ccv, writer, sstable_version_types::mc, [] (file_writer& out, uint32_t value) {
return write_vint(out, value);
});
} else {
write_cell_value(writer, *cdef.type, cell.value());
}
}
// Collect cell statistics