dist: prevent error building ubuntu package on EC2

fixes #491

Signed-off-by: Takuya ASADA <syuu@scylladb.com>

.gitignore

@@ -4,4 +4,3 @@
 build
 build.ninja
 cscope.*
-/debian/

README.md

@@ -11,37 +11,13 @@ git submodule init
 git submodule update --recursive
 ```
 
-### Building and Running Scylla on Fedora
-* Installing required packages:
+### Building scylla on Fedora
+Installing required packages:
 
 ```
 sudo yum install yaml-cpp-devel lz4-devel zlib-devel snappy-devel jsoncpp-devel thrift-devel antlr3-tool antlr3-C++-devel libasan libubsan
 ```
 
-* Build Scylla
-```
-./configure.py --mode=release --with=scylla --disable-xen
-ninja build/release/scylla -j2 # you can use more cpus if you have tons of RAM
-
-```
-
-* Run Scylla
-```
-./build/release/scylla
-
-```
-
-* run Scylla with one CPU and ./tmp as data directory
-
-```
-./build/release/scylla --datadir tmp --commitlog-directory tmp --smp 1
-```
-
-* For more run options:
-```
-./build/release/scylla --help
-```
-
 ## Building Fedora RPM
 
 As a pre-requisite, you need to install [Mock](https://fedoraproject.org/wiki/Mock) on your machine:
@@ -80,5 +56,5 @@ docker build -t <image-name> .
 Run the image with:
 
 ```
-docker run -p $(hostname -i):9042:9042 -i -t <image name>
+docker run -i -t <image name>
 ```

SCYLLA-VERSION-GEN

@@ -1,6 +1,6 @@
 #!/bin/sh
 
-VERSION=0.12
+VERSION=0.11.1
 
 if test -f version
 then

api/api-doc/messaging_service.json

@@ -8,16 +8,13 @@
    ],
    "apis":[
       {
-         "path":"/messaging_service/messages/timeout",
+         "path":"/messaging_service/totaltimeouts",
          "operations":[
             {
                "method":"GET",
-               "summary":"Get the number of timeout messages",
-               "type":"array",
-               "items":{
-                  "type":"message_counter"
-               },
-               "nickname":"get_timeout_messages",
+               "summary":"Total number of timeouts happened on this node",
+               "type":"long",
+               "nickname":"get_totaltimeouts",
                "produces":[
                   "application/json"
                ],
@@ -28,7 +25,7 @@
          ]
       },
       {
-         "path":"/messaging_service/messages/dropped_by_ver",
+         "path":"/messaging_service/messages/dropped",
          "operations":[
             {
                "method":"GET",
@@ -37,25 +34,6 @@
                "items":{
                   "type":"verb_counter"
                },
-               "nickname":"get_dropped_messages_by_ver",
-               "produces":[
-                  "application/json"
-               ],
-               "parameters":[
-               ]
-            }
-         ]
-      },
-      {
-         "path":"/messaging_service/messages/dropped",
-         "operations":[
-            {
-               "method":"GET",
-               "summary":"Get the number of messages that were dropped before sending",
-               "type":"array",
-               "items":{
-                  "type":"message_counter"
-               },
                "nickname":"get_dropped_messages",
                "produces":[
                   "application/json"
@@ -162,25 +140,6 @@
                ],
                "parameters":[
                   
-               ]
-            }
-         ]
-      },
-      {
-         "path":"/messaging_service/messages/respond_completed",
-         "operations":[
-            {
-               "method":"GET",
-               "summary":"Get the number of completed respond messages",
-               "type":"array",
-               "items":{
-                  "type":"message_counter"
-               },
-               "nickname":"get_respond_completed_messages",
-               "produces":[
-                  "application/json"
-               ],
-               "parameters":[
                ]
             }
          ]
@@ -191,10 +150,10 @@
          "id":"message_counter",
          "description":"Holds command counters",
          "properties":{
-            "value":{
+            "count":{
                "type":"long"
             },
-            "key":{
+            "ip":{
                "type":"string"
             }
          }

api/api-doc/storage_service.json

@@ -290,25 +290,6 @@
             }
          ]
       },
-      {
-         "path":"/storage_service/describe_ring/",
-         "operations":[
-            {
-               "method":"GET",
-               "summary":"The TokenRange for a any keyspace",
-               "type":"array",
-               "items":{
-                  "type":"token_range"
-               },
-               "nickname":"describe_any_ring",
-               "produces":[
-                  "application/json"
-               ],
-               "parameters":[
-               ]
-            }
-         ]
-      },
       {
          "path":"/storage_service/describe_ring/{keyspace}",
          "operations":[
@@ -317,9 +298,9 @@
                "summary":"The TokenRange for a given keyspace",
                "type":"array",
                "items":{
-                  "type":"token_range"
+                  "type":"string"
                },
-               "nickname":"describe_ring",
+               "nickname":"describe_ring_jmx",
                "produces":[
                   "application/json"
                ],
@@ -330,7 +311,7 @@
                      "required":true,
                      "allowMultiple":false,
                      "type":"string",
-                     "paramType":"path"
+                     "paramType":"query"
                   }
                ]
             }
@@ -2022,59 +2003,6 @@
                "description":"The column family"
             }
          }
-      },
-      "endpoint_detail":{
-         "id":"endpoint_detail",
-         "description":"Endpoint detail",
-         "properties":{
-            "host":{
-               "type":"string",
-               "description":"The endpoint host"
-            },
-            "datacenter":{
-               "type":"string",
-               "description":"The endpoint datacenter"
-            },
-            "rack":{
-               "type":"string",
-               "description":"The endpoint rack"
-            }
-         }
-      },
-      "token_range":{
-         "id":"token_range",
-         "description":"Endpoint range information",
-         "properties":{
-            "start_token":{
-               "type":"string",
-               "description":"The range start token"
-            },
-            "end_token":{
-               "type":"string",
-               "description":"The range start token"
-            },
-            "endpoints":{
-               "type":"array",
-               "items":{
-                  "type":"string"
-               },
-               "description":"The endpoints"
-            },
-            "rpc_endpoints":{
-               "type":"array",
-               "items":{
-                  "type":"string"
-               },
-               "description":"The rpc endpoints"
-            },
-            "endpoint_details":{
-               "type":"array",
-               "items":{
-                  "type":"endpoint_detail"
-               },
-               "description":"The endpoint details"
-            }
-         }
       }
    }
 }

api/compaction_manager.cc

@@ -30,7 +30,7 @@ namespace cm = httpd::compaction_manager_json;
 
 static future<json::json_return_type> get_cm_stats(http_context& ctx,
         int64_t compaction_manager::stats::*f) {
-    return ctx.db.map_reduce0([f](database& db) {
+    return ctx.db.map_reduce0([&](database& db) {
         return db.get_compaction_manager().get_stats().*f;
     }, int64_t(0), std::plus<int64_t>()).then([](const int64_t& res) {
         return make_ready_future<json::json_return_type>(res);

api/messaging_service.cc

@@ -41,8 +41,8 @@ std::vector<message_counter> map_to_message_counters(
     std::vector<message_counter> res;
     for (auto i : map) {
         res.push_back(message_counter());
-        res.back().key = boost::lexical_cast<sstring>(i.first);
-        res.back().value = i.second;
+        res.back().ip = boost::lexical_cast<sstring>(i.first);
+        res.back().count = i.second;
     }
     return res;
 }
@@ -70,39 +70,12 @@ future_json_function get_client_getter(std::function<uint64_t(const shard_info&)
     };
 }
 
-future_json_function get_server_getter(std::function<uint64_t(const rpc::stats&)> f) {
-    return [f](std::unique_ptr<request> req) {
-        using map_type = std::unordered_map<gms::inet_address, uint64_t>;
-        auto get_shard_map = [f](messaging_service& ms) {
-            std::unordered_map<gms::inet_address, unsigned long> map;
-            ms.foreach_server_connection_stats([&map, f] (const rpc::client_info& info, const rpc::stats& stats) mutable {
-                map[gms::inet_address(net::ipv4_address(info.addr))] = f(stats);
-            });
-            return map;
-        };
-        return  get_messaging_service().map_reduce0(get_shard_map, map_type(), map_sum<map_type>).
-                then([](map_type&& map) {
-            return make_ready_future<json::json_return_type>(map_to_message_counters(map));
-        });
-    };
-}
-
 void set_messaging_service(http_context& ctx, routes& r) {
-    get_timeout_messages.set(r, get_client_getter([](const shard_info& c) {
-        return c.get_stats().timeout;
-    }));
 
     get_sent_messages.set(r, get_client_getter([](const shard_info& c) {
         return c.get_stats().sent_messages;
     }));
 
-    get_dropped_messages.set(r, get_client_getter([](const shard_info& c) {
-        // We don't have the same drop message mechanism
-        // as origin has.
-        // hence we can always return 0
-        return 0;
-    }));
-
     get_exception_messages.set(r, get_client_getter([](const shard_info& c) {
         return c.get_stats().exception_received;
     }));
@@ -111,15 +84,11 @@ void set_messaging_service(http_context& ctx, routes& r) {
         return c.get_stats().pending;
     }));
 
-    get_respond_pending_messages.set(r, get_server_getter([](const rpc::stats& c) {
-        return c.pending;
+    get_respond_pending_messages.set(r, get_client_getter([](const shard_info& c) {
+        return c.get_stats().wait_reply;
     }));
 
-    get_respond_completed_messages.set(r, get_server_getter([](const rpc::stats& c) {
-        return c.sent_messages;
-    }));
-
-    get_dropped_messages_by_ver.set(r, [](std::unique_ptr<request> req) {
+    get_dropped_messages.set(r, [](std::unique_ptr<request> req) {
         shared_ptr<std::vector<uint64_t>> map = make_shared<std::vector<uint64_t>>(num_verb, 0);
 
         return net::get_messaging_service().map_reduce([map](const uint64_t* local_map) mutable {

api/storage_proxy.cc

@@ -201,16 +201,22 @@ void set_storage_proxy(http_context& ctx, routes& r) {
         return make_ready_future<json::json_return_type>(json_void());
     });
 
-    sp::get_read_repair_attempted.set(r, [&ctx](std::unique_ptr<request> req)  {
-        return sum_stats(ctx.sp, &proxy::stats::read_repair_attempts);
+    sp::get_read_repair_attempted.set(r, [](std::unique_ptr<request> req)  {
+        //TBD
+        unimplemented();
+        return make_ready_future<json::json_return_type>(0);
     });
 
-    sp::get_read_repair_repaired_blocking.set(r, [&ctx](std::unique_ptr<request> req)  {
-        return sum_stats(ctx.sp, &proxy::stats::read_repair_repaired_blocking);
+    sp::get_read_repair_repaired_blocking.set(r, [](std::unique_ptr<request> req)  {
+        //TBD
+        unimplemented();
+        return make_ready_future<json::json_return_type>(0);
     });
 
-    sp::get_read_repair_repaired_background.set(r, [&ctx](std::unique_ptr<request> req)  {
-        return sum_stats(ctx.sp, &proxy::stats::read_repair_repaired_background);
+    sp::get_read_repair_repaired_background.set(r, [](std::unique_ptr<request> req)  {
+        //TBD
+        unimplemented();
+        return make_ready_future<json::json_return_type>(0);
     });
 
     sp::get_schema_versions.set(r, [](std::unique_ptr<request> req)  {

api/storage_service.cc

@@ -43,29 +43,6 @@ static sstring validate_keyspace(http_context& ctx, const parameters& param) {
     throw bad_param_exception("Keyspace " + param["keyspace"] + " Does not exist");
 }
 
-
-static std::vector<ss::token_range> describe_ring(const sstring& keyspace) {
-    std::vector<ss::token_range> res;
-    for (auto d : service::get_local_storage_service().describe_ring(keyspace)) {
-        ss::token_range r;
-        r.start_token = d._start_token;
-        r.end_token = d._end_token;
-        r.endpoints = d._endpoints;
-        r.rpc_endpoints = d._rpc_endpoints;
-        for (auto det : d._endpoint_details) {
-            ss::endpoint_detail ed;
-            ed.host = det._host;
-            ed.datacenter = det._datacenter;
-            if (det._rack != "") {
-                ed.rack = det._rack;
-            }
-            r.endpoint_details.push(ed);
-        }
-        res.push_back(r);
-    }
-    return res;
-}
-
 void set_storage_service(http_context& ctx, routes& r) {
     ss::local_hostid.set(r, [](std::unique_ptr<request> req) {
         return db::system_keyspace::get_local_host_id().then([](const utils::UUID& id) {
@@ -148,13 +125,12 @@ void set_storage_service(http_context& ctx, routes& r) {
         return make_ready_future<json::json_return_type>(res);
     });
 
-    ss::describe_any_ring.set(r, [&ctx](const_req req) {
-        return describe_ring("");
-    });
-
-    ss::describe_ring.set(r, [&ctx](const_req req) {
-        auto keyspace = validate_keyspace(ctx, req.param);
-        return describe_ring(keyspace);
+    ss::describe_ring_jmx.set(r, [&ctx](std::unique_ptr<request> req) {
+        //TBD
+        unimplemented();
+        auto keyspace = validate_keyspace(ctx, req->param);
+        std::vector<sstring> res;
+        return make_ready_future<json::json_return_type>(res);
     });
 
     ss::get_host_id_map.set(r, [](const_req req) {
@@ -181,10 +157,15 @@ void set_storage_service(http_context& ctx, routes& r) {
         });
     });
 
-    ss::get_natural_endpoints.set(r, [&ctx](const_req req) {
-        auto keyspace = validate_keyspace(ctx, req.param);
-        return container_to_vec(service::get_local_storage_service().get_natural_endpoints(keyspace, req.get_query_param("cf"),
-                req.get_query_param("key")));
+    ss::get_natural_endpoints.set(r, [&ctx](std::unique_ptr<request> req) {
+        //TBD
+        unimplemented();
+        auto keyspace = validate_keyspace(ctx, req->param);
+        auto column_family = req->get_query_param("cf");
+        auto key = req->get_query_param("key");
+
+        std::vector<sstring> res;
+        return make_ready_future<json::json_return_type>(res);
     });
 
     ss::get_snapshot_details.set(r, [](std::unique_ptr<request> req) {
@@ -266,14 +247,10 @@ void set_storage_service(http_context& ctx, routes& r) {
 
     ss::force_keyspace_cleanup.set(r, [&ctx](std::unique_ptr<request> req) {
         //TBD
-        // FIXME
-        // the nodetool clean up is used in many tests
-        // this workaround willl let it work until
-        // a cleanup is implemented
-        warn(unimplemented::cause::API);
+        unimplemented();
         auto keyspace = validate_keyspace(ctx, req->param);
         auto column_family = req->get_query_param("cf");
-        return make_ready_future<json::json_return_type>(0);
+        return make_ready_future<json::json_return_type>(json_void());
     });
 
     ss::scrub.set(r, [&ctx](std::unique_ptr<request> req) {
@@ -361,11 +338,11 @@ void set_storage_service(http_context& ctx, routes& r) {
         });
     });
 
-    ss::move.set(r, [] (std::unique_ptr<request> req) {
+    ss::move.set(r, [](std::unique_ptr<request> req) {
+        //TBD
+        unimplemented();
         auto new_token = req->get_query_param("new_token");
-        return service::get_local_storage_service().move(new_token).then([] {
-            return make_ready_future<json::json_return_type>(json_void());
-        });
+        return make_ready_future<json::json_return_type>(json_void());
     });
 
     ss::remove_node.set(r, [](std::unique_ptr<request> req) {
@@ -518,10 +495,8 @@ void set_storage_service(http_context& ctx, routes& r) {
         });
     });
 
-    ss::is_joined.set(r, [] (std::unique_ptr<request> req) {
-        return service::get_local_storage_service().is_joined().then([] (bool is_joined) {
-            return make_ready_future<json::json_return_type>(is_joined);
-        });
+    ss::is_joined.set(r, [](const_req req) {
+        return service::get_local_storage_service().is_joined();
     });
 
     ss::set_stream_throughput_mb_per_sec.set(r, [](std::unique_ptr<request> req) {
@@ -750,19 +725,17 @@ void set_storage_service(http_context& ctx, routes& r) {
         return make_ready_future<json::json_return_type>(0);
     });
 
-    ss::get_ownership.set(r, [] (std::unique_ptr<request> req) {
-        return service::get_local_storage_service().get_ownership().then([] (auto&& ownership) {
-            std::vector<storage_service_json::mapper> res;
-            return make_ready_future<json::json_return_type>(map_to_key_value(ownership, res));
-        });
+    ss::get_ownership.set(r, [](const_req req) {
+        auto tokens = service::get_local_storage_service().get_ownership();
+        std::vector<storage_service_json::mapper> res;
+        return map_to_key_value(tokens, res);
     });
 
-    ss::get_effective_ownership.set(r, [&ctx] (std::unique_ptr<request> req) {
-        auto keyspace_name = req->param["keyspace"] == "null" ? "" : validate_keyspace(ctx, req->param);
-        return service::get_local_storage_service().effective_ownership(keyspace_name).then([] (auto&& ownership) {
-            std::vector<storage_service_json::mapper> res;
-            return make_ready_future<json::json_return_type>(map_to_key_value(ownership, res));
-        });
+    ss::get_effective_ownership.set(r, [&ctx](const_req req) {
+        auto tokens = service::get_local_storage_service().effective_ownership(
+                (req.param["keyspace"] == "null")? "" : validate_keyspace(ctx, req.param));
+        std::vector<storage_service_json::mapper> res;
+        return map_to_key_value(tokens, res);
     });
 }
 

atomic_cell.hh

@@ -234,8 +234,6 @@ public:
     friend std::ostream& operator<<(std::ostream& os, const atomic_cell& ac);
 };
 
-class collection_mutation_view;
-
 // Represents a mutation of a collection.  Actual format is determined by collection type,
 // and is:
 //   set:  list of atomic_cell
@@ -243,30 +241,20 @@ class collection_mutation_view;
 //   list: tbd, probably ugly
 class collection_mutation {
 public:
-    managed_bytes data;
-    collection_mutation() {}
-    collection_mutation(managed_bytes b) : data(std::move(b)) {}
-    collection_mutation(collection_mutation_view v);
-    operator collection_mutation_view() const;
+    struct view {
+        bytes_view data;
+        bytes_view serialize() const { return data; }
+        static view from_bytes(bytes_view v) { return { v }; }
+    };
+    struct one {
+        managed_bytes data;
+        one() {}
+        one(managed_bytes b) : data(std::move(b)) {}
+        one(view v) : data(v.data) {}
+        operator view() const { return { data }; }
+    };
 };
 
-class collection_mutation_view {
-public:
-    bytes_view data;
-    bytes_view serialize() const { return data; }
-    static collection_mutation_view from_bytes(bytes_view v) { return { v }; }
-};
-
-inline
-collection_mutation::collection_mutation(collection_mutation_view v)
-        : data(v.data) {
-}
-
-inline
-collection_mutation::operator collection_mutation_view() const {
-    return { data };
-}
-
 namespace db {
 template<typename T>
 class serializer;
@@ -286,15 +274,15 @@ public:
     atomic_cell_or_collection(atomic_cell ac) : _data(std::move(ac._data)) {}
     static atomic_cell_or_collection from_atomic_cell(atomic_cell data) { return { std::move(data._data) }; }
     atomic_cell_view as_atomic_cell() const { return atomic_cell_view::from_bytes(_data); }
-    atomic_cell_or_collection(collection_mutation cm) : _data(std::move(cm.data)) {}
+    atomic_cell_or_collection(collection_mutation::one cm) : _data(std::move(cm.data)) {}
     explicit operator bool() const {
         return !_data.empty();
     }
-    static atomic_cell_or_collection from_collection_mutation(collection_mutation data) {
+    static atomic_cell_or_collection from_collection_mutation(collection_mutation::one data) {
         return std::move(data.data);
     }
-    collection_mutation_view as_collection_mutation() const {
-        return collection_mutation_view{_data};
+    collection_mutation::view as_collection_mutation() const {
+        return collection_mutation::view{_data};
     }
     bytes_view serialize() const {
         return _data;

compaction_strategy.hh

@@ -63,18 +63,16 @@ public:
     }
 
     static compaction_strategy_type type(const sstring& name) {
-        auto pos = name.find("org.apache.cassandra.db.compaction.");
-        sstring short_name = (pos == sstring::npos) ? name : name.substr(pos + 35);
-        if (short_name == "NullCompactionStrategy") {
+        if (name == "NullCompactionStrategy") {
             return compaction_strategy_type::null;
-        } else if (short_name == "MajorCompactionStrategy") {
+        } else if (name == "MajorCompactionStrategy") {
             return compaction_strategy_type::major;
-        } else if (short_name == "SizeTieredCompactionStrategy") {
+        } else if (name == "SizeTieredCompactionStrategy") {
             return compaction_strategy_type::size_tiered;
-        } else if (short_name == "LeveledCompactionStrategy") {
+        } else if (name == "LeveledCompactionStrategy") {
             return compaction_strategy_type::leveled;
         } else {
-            throw exceptions::configuration_exception(sprint("Unable to find compaction strategy class '%s'", name));
+            throw exceptions::configuration_exception(sprint("Unable to find compaction strategy class 'org.apache.cassandra.db.compaction.%s", name));
         }
     }
 

compound.hh

@@ -159,7 +159,7 @@ public:
         }
         return ::serialize_value(*this, values);
     }
-    bytes serialize_value_deep(const std::vector<data_value>& values) {
+    bytes serialize_value_deep(const std::vector<boost::any>& values) {
         // TODO: Optimize
         std::vector<bytes> partial;
         partial.reserve(values.size());

conf/scylla.yaml

@@ -409,16 +409,15 @@ partitioner: org.apache.cassandra.dht.Murmur3Partitioner
 #   offheap_objects: native memory, eliminating nio buffer heap overhead
 # memtable_allocation_type: heap_buffers
 
-# Total space to use for commitlogs.
+# Total space to use for commitlogs.  Since commitlog segments are
+# mmapped, and hence use up address space, the default size is 32
+# on 32-bit JVMs, and 8192 on 64-bit JVMs.
 #
 # If space gets above this value (it will round up to the next nearest
 # segment multiple), Scylla will flush every dirty CF in the oldest
 # segment and remove it.  So a small total commitlog space will tend
 # to cause more flush activity on less-active columnfamilies.
-#
-# A value of -1 (default) will automatically equate it to the total amount of memory
-# available for Scylla.
-commitlog_total_space_in_mb: -1
+commitlog_total_space_in_mb: 8192
 
 # This sets the amount of memtable flush writer threads.  These will
 # be blocked by disk io, and each one will hold a memtable in memory

configure.py

@@ -374,8 +374,6 @@ scylla_core = (['database.cc',
                  'service/storage_service.cc',
                  'service/pending_range_calculator_service.cc',
                  'service/load_broadcaster.cc',
-                 'service/pager/paging_state.cc',
-                 'service/pager/query_pagers.cc',
                  'streaming/streaming.cc',
                  'streaming/stream_task.cc',
                  'streaming/stream_session.cc',
@@ -396,7 +394,6 @@ scylla_core = (['database.cc',
                  'streaming/messages/file_message_header.cc',
                  'streaming/messages/outgoing_file_message.cc',
                  'streaming/messages/incoming_file_message.cc',
-                 'streaming/stream_session_state.cc',
                  'gc_clock.cc',
                  'partition_slice_builder.cc',
                  'init.cc',

cql3/attributes.cc

@@ -80,7 +80,7 @@ int64_t attributes::get_timestamp(int64_t now, const query_options& options) {
     } catch (marshal_exception e) {
         throw exceptions::invalid_request_exception("Invalid timestamp value");
     }
-    return value_cast<int64_t>(data_type_for<int64_t>()->deserialize(*tval));
+    return boost::any_cast<int64_t>(data_type_for<int64_t>()->deserialize(*tval));
 }
 
 int32_t attributes::get_time_to_live(const query_options& options) {
@@ -99,7 +99,7 @@ int32_t attributes::get_time_to_live(const query_options& options) {
         throw exceptions::invalid_request_exception("Invalid TTL value");
     }
 
-    auto ttl = value_cast<int32_t>(data_type_for<int32_t>()->deserialize(*tval));
+    auto ttl = boost::any_cast<int32_t>(data_type_for<int32_t>()->deserialize(*tval));
     if (ttl < 0) {
         throw exceptions::invalid_request_exception("A TTL must be greater or equal to 0");
     }

cql3/constants.cc

@@ -160,7 +160,7 @@ void constants::deleter::execute(mutation& m, const exploded_clustering_prefix&
         auto ctype = static_pointer_cast<const collection_type_impl>(column.type);
         m.set_cell(prefix, column, atomic_cell_or_collection::from_collection_mutation(ctype->serialize_mutation_form(coll_m)));
     } else {
-        m.set_cell(prefix, column, make_dead_cell(params));
+        m.set_cell(prefix, column, params.make_dead_cell());
     }
 }
 

cql3/constants.hh

@@ -197,7 +197,7 @@ public:
 
         virtual void execute(mutation& m, const exploded_clustering_prefix& prefix, const update_parameters& params) override {
             auto value = _t->bind_and_get(params._options);
-            auto cell = value ? make_cell(*value, params) : make_dead_cell(params);
+            auto cell = value ? params.make_cell(*value) : params.make_dead_cell();
             m.set_cell(prefix, column, std::move(cell));
         }
     };

cql3/functions/aggregate_fcts.hh

@@ -90,7 +90,7 @@ public:
         if (!values[0]) {
             return;
         }
-        _sum += value_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
+        _sum += boost::any_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
     }
 };
 
@@ -132,7 +132,7 @@ public:
             return;
         }
         ++_count;
-        _sum += value_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
+        _sum += boost::any_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
     }
 };
 
@@ -169,7 +169,7 @@ public:
         if (!values[0]) {
             return;
         }
-        auto val = value_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
+        auto val = boost::any_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
         if (!_max) {
             _max = val;
         } else {
@@ -216,7 +216,7 @@ public:
         if (!values[0]) {
             return;
         }
-        auto val = value_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
+        auto val = boost::any_cast<Type>(data_type_for<Type>()->deserialize(*values[0]));
         if (!_min) {
             _min = val;
         } else {

cql3/functions/functions.cc

@@ -50,11 +50,6 @@ functions::init() {
         if (type == cql3_type::varchar || type == cql3_type::blob) {
             continue;
         }
-        // counters are not supported yet
-        if (type->is_counter()) {
-            warn(unimplemented::cause::COUNTERS);
-            continue;
-        }
 
         declare(make_to_blob_function(type->get_type()));
         declare(make_from_blob_function(type->get_type()));

cql3/functions/time_uuid_fcts.hh

@@ -71,10 +71,10 @@ make_min_timeuuid_fct() {
             return {};
         }
         auto ts_obj = timestamp_type->deserialize(*bb);
-        if (ts_obj.is_null()) {
+        if (ts_obj.empty()) {
             return {};
         }
-        auto ts = value_cast<db_clock::time_point>(ts_obj);
+        auto ts = boost::any_cast<db_clock::time_point>(ts_obj);
         auto uuid = utils::UUID_gen::min_time_UUID(ts.time_since_epoch().count());
         return {timeuuid_type->decompose(uuid)};
     });
@@ -91,10 +91,10 @@ make_max_timeuuid_fct() {
             return {};
         }
         auto ts_obj = timestamp_type->deserialize(*bb);
-        if (ts_obj.is_null()) {
+        if (ts_obj.empty()) {
             return {};
         }
-        auto ts = value_cast<db_clock::time_point>(ts_obj);
+        auto ts = boost::any_cast<db_clock::time_point>(ts_obj);
         auto uuid = utils::UUID_gen::max_time_UUID(ts.time_since_epoch().count());
         return {timeuuid_type->decompose(uuid)};
     });

cql3/functions/uuid_fcts.hh

@@ -54,7 +54,7 @@ shared_ptr<function>
 make_uuid_fct() {
     return make_native_scalar_function<false>("uuid", uuid_type, {},
             [] (serialization_format sf, const std::vector<bytes_opt>& parameters) -> bytes_opt {
-        return {uuid_type->decompose(utils::make_random_uuid())};
+        return {uuid_type->decompose(boost::any(utils::make_random_uuid()))};
     });
 }
 

cql3/lists.cc

@@ -113,12 +113,12 @@ lists::value::from_serialized(bytes_view v, list_type type, serialization_format
         // Collections have this small hack that validate cannot be called on a serialized object,
         // but compose does the validation (so we're fine).
         // FIXME: deserializeForNativeProtocol()?!
-        auto l = value_cast<list_type_impl::native_type>(type->deserialize(v, sf));
+        auto l = boost::any_cast<list_type_impl::native_type>(type->deserialize(v, sf));
         std::vector<bytes_opt> elements;
         elements.reserve(l.size());
         for (auto&& element : l) {
             // elements can be null in lists that represent a set of IN values
-            elements.push_back(element.is_null() ? bytes_opt() : bytes_opt(type->get_elements_type()->decompose(element)));
+            elements.push_back(element.empty() ? bytes_opt() : bytes_opt(type->get_elements_type()->decompose(element)));
         }
         return value(std::move(elements));
     } catch (marshal_exception& e) {
@@ -274,7 +274,7 @@ lists::setter_by_index::execute(mutation& m, const exploded_clustering_prefix& p
     if (!existing_list_opt) {
         throw exceptions::invalid_request_exception("Attempted to set an element on a list which is null");
     }
-    collection_mutation_view existing_list_ser = *existing_list_opt;
+    collection_mutation::view existing_list_ser = *existing_list_opt;
     auto ltype = dynamic_pointer_cast<const list_type_impl>(column.type);
     collection_type_impl::mutation_view existing_list = ltype->deserialize_mutation_form(existing_list_ser);
     // we verified that index is an int32_type
@@ -339,7 +339,7 @@ lists::do_append(shared_ptr<term> t,
         } else {
             auto&& to_add = list_value->_elements;
             auto deref = [] (const bytes_opt& v) { return *v; };
-            auto&& newv = collection_mutation{list_type_impl::pack(
+            auto&& newv = collection_mutation::one{list_type_impl::pack(
                     boost::make_transform_iterator(to_add.begin(), deref),
                     boost::make_transform_iterator(to_add.end(), deref),
                     to_add.size(), serialization_format::internal())};

cql3/maps.cc

@@ -161,7 +161,7 @@ maps::value::from_serialized(bytes_view value, map_type type, serialization_form
         // Collections have this small hack that validate cannot be called on a serialized object,
         // but compose does the validation (so we're fine).
         // FIXME: deserialize_for_native_protocol?!
-        auto m = value_cast<map_type_impl::native_type>(type->deserialize(value, sf));
+        auto m = boost::any_cast<map_type_impl::native_type>(type->deserialize(value, sf));
         std::map<bytes, bytes, serialized_compare> map(type->get_keys_type()->as_less_comparator());
         for (auto&& e : m) {
             map.emplace(type->get_keys_type()->decompose(e.first),
@@ -350,8 +350,10 @@ maps::discarder_by_key::execute(mutation& m, const exploded_clustering_prefix& p
     if (!key) {
         throw exceptions::invalid_request_exception("Invalid null map key");
     }
+    auto ckey = dynamic_pointer_cast<constants::value>(std::move(key));
+    assert(ckey);
     collection_type_impl::mutation mut;
-    mut.cells.emplace_back(*key->get(params._options), params.make_dead_cell());
+    mut.cells.emplace_back(*ckey->_bytes, params.make_dead_cell());
     auto mtype = static_cast<const map_type_impl*>(column.type.get());
     m.set_cell(prefix, column, mtype->serialize_mutation_form(mut));
 }

cql3/operation.cc

@@ -216,7 +216,7 @@ operation::element_deletion::prepare(database& db, const sstring& keyspace, cons
         return make_shared<lists::discarder_by_index>(receiver, std::move(idx));
     } else if (&ctype->_kind == &collection_type_impl::kind::set) {
         auto&& elt = _element->prepare(db, keyspace, sets::value_spec_of(receiver.column_specification));
-        return make_shared<sets::element_discarder>(receiver, std::move(elt));
+        return make_shared<sets::discarder>(receiver, std::move(elt));
     } else if (&ctype->_kind == &collection_type_impl::kind::map) {
         auto&& key = _element->prepare(db, keyspace, maps::key_spec_of(*receiver.column_specification));
         return make_shared<maps::discarder_by_key>(receiver, std::move(key));

cql3/operation.hh

@@ -45,7 +45,6 @@
 #include "exceptions/exceptions.hh"
 #include "database_fwd.hh"
 #include "term.hh"
-#include "update_parameters.hh"
 
 #include <experimental/optional>
 
@@ -87,14 +86,6 @@ public:
 
     virtual ~operation() {}
 
-    atomic_cell make_dead_cell(const update_parameters& params) const {
-        return params.make_dead_cell();
-    }
-
-    atomic_cell make_cell(bytes_view value, const update_parameters& params) const {
-        return params.make_cell(value);
-    }
-
     virtual bool uses_function(const sstring& ks_name, const sstring& function_name) const {
         return _t && _t->uses_function(ks_name, function_name);
     }

cql3/query_processor.cc

@@ -300,7 +300,7 @@ query_processor::parse_statement(const sstring_view& query)
 
 query_options query_processor::make_internal_options(
         ::shared_ptr<statements::parsed_statement::prepared> p,
-        const std::initializer_list<data_value>& values) {
+        const std::initializer_list<boost::any>& values) {
     if (p->bound_names.size() != values.size()) {
         throw std::invalid_argument(sprint("Invalid number of values. Expecting %d but got %d", p->bound_names.size(), values.size()));
     }
@@ -308,9 +308,9 @@ query_options query_processor::make_internal_options(
     std::vector<bytes_opt> bound_values;
     for (auto& v : values) {
         auto& n = *ni++;
-        if (v.type() == bytes_type) {
-            bound_values.push_back({value_cast<bytes>(v)});
-        } else if (v.is_null()) {
+        if (v.type() == typeid(bytes)) {
+            bound_values.push_back({boost::any_cast<bytes>(v)});
+        } else if (v.empty()) {
             bound_values.push_back({});
         } else {
             bound_values.push_back({n->type->decompose(v)});
@@ -333,7 +333,7 @@ query_options query_processor::make_internal_options(
 
 future<::shared_ptr<untyped_result_set>> query_processor::execute_internal(
         const std::experimental::string_view& query_string,
-        const std::initializer_list<data_value>& values) {
+        const std::initializer_list<boost::any>& values) {
     auto p = prepare_internal(query_string);
     auto opts = make_internal_options(p, values);
     return do_with(std::move(opts),

cql3/query_processor.hh

@@ -323,12 +323,12 @@ public:
 #endif
 private:
     ::shared_ptr<statements::parsed_statement::prepared> prepare_internal(const std::experimental::string_view& query);
-    query_options make_internal_options(::shared_ptr<statements::parsed_statement::prepared>, const std::initializer_list<data_value>&);
+    query_options make_internal_options(::shared_ptr<statements::parsed_statement::prepared>, const std::initializer_list<boost::any>&);
 
 public:
     future<::shared_ptr<untyped_result_set>> execute_internal(
             const std::experimental::string_view& query_string,
-            const std::initializer_list<data_value>& = { });
+            const std::initializer_list<boost::any>& = { });
 
     /*
      * This function provides a timestamp that is guaranteed to be higher than any timestamp

cql3/result_set.hh

@@ -80,7 +80,7 @@ public:
 
 private:
     const uint32_t _column_count;
-    ::shared_ptr<const service::pager::paging_state> _paging_state;
+    ::shared_ptr<service::pager::paging_state> _paging_state;
 
 public:
     metadata(std::vector<::shared_ptr<column_specification>> names_)
@@ -88,7 +88,7 @@ public:
     { }
 
     metadata(flag_enum_set flags, std::vector<::shared_ptr<column_specification>> names_, uint32_t column_count,
-            ::shared_ptr<const service::pager::paging_state> paging_state)
+            ::shared_ptr<service::pager::paging_state> paging_state)
         : _flags(flags)
         , names(std::move(names_))
         , _column_count(column_count)
@@ -121,7 +121,7 @@ private:
     }
 
 public:
-    void set_has_more_pages(::shared_ptr<const service::pager::paging_state> paging_state) {
+    void set_has_more_pages(::shared_ptr<service::pager::paging_state> paging_state) {
         if (!paging_state) {
             return;
         }
@@ -342,10 +342,6 @@ public:
         std::sort(_rows.begin(), _rows.end(), std::forward<RowComparator>(cmp));
     }
 
-    metadata& get_metadata() {
-        return *_metadata;
-    }
-
     const metadata& get_metadata() const {
         return *_metadata;
     }

cql3/selection/selection.cc

@@ -125,7 +125,7 @@ protected:
         }
     };
 
-    std::unique_ptr<selectors> new_selectors() const override {
+    std::unique_ptr<selectors> new_selectors() {
         return std::make_unique<simple_selectors>();
     }
 };
@@ -196,7 +196,7 @@ protected:
         }
     };
 
-    std::unique_ptr<selectors> new_selectors() const override  {
+    std::unique_ptr<selectors> new_selectors() {
         return std::make_unique<selectors_with_processing>(_factories);
     }
 };
@@ -252,7 +252,7 @@ selection::collect_metadata(schema_ptr schema, const std::vector<::shared_ptr<ra
     return r;
 }
 
-result_set_builder::result_set_builder(const selection& s, db_clock::time_point now, serialization_format sf)
+result_set_builder::result_set_builder(selection& s, db_clock::time_point now, serialization_format sf)
     : _result_set(std::make_unique<result_set>(::make_shared<metadata>(*(s.get_result_metadata()))))
     , _selectors(s.new_selectors())
     , _now(now)
@@ -295,7 +295,7 @@ void result_set_builder::add(const column_definition& def, const query::result_a
     }
 }
 
-void result_set_builder::add(const column_definition& def, collection_mutation_view c) {
+void result_set_builder::add(const column_definition& def, collection_mutation::view c) {
     auto&& ctype = static_cast<const collection_type_impl*>(def.type.get());
     current->emplace_back(ctype->to_value(c, _serialization_format));
     // timestamps, ttls meaningless for collections
@@ -330,94 +330,6 @@ std::unique_ptr<result_set> result_set_builder::build() {
     return std::move(_result_set);
 }
 
-result_set_builder::visitor::visitor(
-        cql3::selection::result_set_builder& builder, const schema& s,
-        const selection& selection)
-        : _builder(builder), _schema(s), _selection(selection), _row_count(0) {
-}
-
-void result_set_builder::visitor::add_value(const column_definition& def,
-        query::result_row_view::iterator_type& i) {
-    if (def.type->is_multi_cell()) {
-        auto cell = i.next_collection_cell();
-        if (!cell) {
-            _builder.add_empty();
-            return;
-        }
-        _builder.add(def, *cell);
-    } else {
-        auto cell = i.next_atomic_cell();
-        if (!cell) {
-            _builder.add_empty();
-            return;
-        }
-        _builder.add(def, *cell);
-    }
-}
-
-void result_set_builder::visitor::accept_new_partition(const partition_key& key,
-        uint32_t row_count) {
-    _partition_key = key.explode(_schema);
-    _row_count = row_count;
-}
-
-void result_set_builder::visitor::accept_new_partition(uint32_t row_count) {
-    _row_count = row_count;
-}
-
-void result_set_builder::visitor::accept_new_row(const clustering_key& key,
-        const query::result_row_view& static_row,
-        const query::result_row_view& row) {
-    _clustering_key = key.explode(_schema);
-    accept_new_row(static_row, row);
-}
-
-void result_set_builder::visitor::accept_new_row(
-        const query::result_row_view& static_row,
-        const query::result_row_view& row) {
-    auto static_row_iterator = static_row.iterator();
-    auto row_iterator = row.iterator();
-    _builder.new_row();
-    for (auto&& def : _selection.get_columns()) {
-        switch (def->kind) {
-        case column_kind::partition_key:
-            _builder.add(_partition_key[def->component_index()]);
-            break;
-        case column_kind::clustering_key:
-            _builder.add(_clustering_key[def->component_index()]);
-            break;
-        case column_kind::regular_column:
-            add_value(*def, row_iterator);
-            break;
-        case column_kind::compact_column:
-            add_value(*def, row_iterator);
-            break;
-        case column_kind::static_column:
-            add_value(*def, static_row_iterator);
-            break;
-        default:
-            assert(0);
-        }
-    }
-}
-
-void result_set_builder::visitor::accept_partition_end(
-        const query::result_row_view& static_row) {
-    if (_row_count == 0) {
-        _builder.new_row();
-        auto static_row_iterator = static_row.iterator();
-        for (auto&& def : _selection.get_columns()) {
-            if (def->is_partition_key()) {
-                _builder.add(_partition_key[def->component_index()]);
-            } else if (def->is_static()) {
-                add_value(*def, static_row_iterator);
-            } else {
-                _builder.add_empty();
-            }
-        }
-    }
-}
-
 api::timestamp_type result_set_builder::timestamp_of(size_t idx) {
     return _timestamps[idx];
 }

cql3/selection/selection.hh

@@ -161,7 +161,7 @@ public:
         return std::find(_columns.begin(), _columns.end(), &def) != _columns.end();
     }
 
-    ::shared_ptr<metadata> get_result_metadata() const {
+    ::shared_ptr<metadata> get_result_metadata() {
         return _metadata;
     }
 
@@ -186,16 +186,16 @@ private:
 public:
     static ::shared_ptr<selection> from_selectors(database& db, schema_ptr schema, const std::vector<::shared_ptr<raw_selector>>& raw_selectors);
 
-    virtual std::unique_ptr<selectors> new_selectors() const = 0;
+    virtual std::unique_ptr<selectors> new_selectors() = 0;
 
     /**
      * Returns a range of CQL3 columns this selection needs.
      */
-    auto const& get_columns() const {
+    auto const& get_columns() {
         return _columns;
     }
 
-    uint32_t get_column_count() const {
+    uint32_t get_column_count() {
         return _columns.size();
     }
 
@@ -238,39 +238,15 @@ private:
     const db_clock::time_point _now;
     serialization_format _serialization_format;
 public:
-    result_set_builder(const selection& s, db_clock::time_point now, serialization_format sf);
+    result_set_builder(selection& s, db_clock::time_point now, serialization_format sf);
     void add_empty();
     void add(bytes_opt value);
     void add(const column_definition& def, const query::result_atomic_cell_view& c);
-    void add(const column_definition& def, collection_mutation_view c);
+    void add(const column_definition& def, collection_mutation::view c);
     void new_row();
     std::unique_ptr<result_set> build();
     api::timestamp_type timestamp_of(size_t idx);
     int32_t ttl_of(size_t idx);
-    
-    // Implements ResultVisitor concept from query.hh
-    class visitor {
-    protected:
-        result_set_builder& _builder;
-        const schema& _schema;
-        const selection& _selection;
-        uint32_t _row_count;
-        std::vector<bytes> _partition_key;
-        std::vector<bytes> _clustering_key;
-    public:
-        visitor(cql3::selection::result_set_builder& builder, const schema& s, const selection&);
-        visitor(visitor&&) = default;
-
-        void add_value(const column_definition& def, query::result_row_view::iterator_type& i);
-        void accept_new_partition(const partition_key& key, uint32_t row_count);
-        void accept_new_partition(uint32_t row_count);
-        void accept_new_row(const clustering_key& key,
-                const query::result_row_view& static_row,
-                const query::result_row_view& row);
-        void accept_new_row(const query::result_row_view& static_row,
-                const query::result_row_view& row);
-        void accept_partition_end(const query::result_row_view& static_row);
-    };
 private:
     bytes_opt get_value(data_type t, query::result_atomic_cell_view c);
 };

cql3/sets.cc

@@ -125,7 +125,7 @@ sets::value::from_serialized(bytes_view v, set_type type, serialization_format s
         // Collections have this small hack that validate cannot be called on a serialized object,
         // but compose does the validation (so we're fine).
         // FIXME: deserializeForNativeProtocol?!
-        auto s = value_cast<set_type_impl::native_type>(type->deserialize(v, sf));
+        auto s = boost::any_cast<set_type_impl::native_type>(type->deserialize(v, sf));
         std::set<bytes, serialized_compare> elements(type->get_elements_type()->as_less_comparator());
         for (auto&& element : s) {
             elements.insert(elements.end(), type->get_elements_type()->decompose(element));
@@ -284,11 +284,16 @@ sets::discarder::execute(mutation& m, const exploded_clustering_prefix& row_key,
     auto kill = [&] (bytes idx) {
         mut.cells.push_back({std::move(idx), params.make_dead_cell()});
     };
-    auto svalue = dynamic_pointer_cast<sets::value>(value);
-    assert(svalue);
-    mut.cells.reserve(svalue->_elements.size());
-    for (auto&& e : svalue->_elements) {
-        kill(e);
+    // This can be either a set or a single element
+    auto cvalue = dynamic_pointer_cast<constants::value>(value);
+    if (cvalue) {
+        kill(cvalue->_bytes ? *cvalue->_bytes : bytes());
+    } else {
+        auto svalue = static_pointer_cast<sets::value>(value);
+        mut.cells.reserve(svalue->_elements.size());
+        for (auto&& e : svalue->_elements) {
+            kill(e);
+        }
     }
     auto ctype = static_pointer_cast<const collection_type_impl>(column.type);
     m.set_cell(row_key, column,
@@ -296,17 +301,4 @@ sets::discarder::execute(mutation& m, const exploded_clustering_prefix& row_key,
                     ctype->serialize_mutation_form(mut)));
 }
 
-void sets::element_discarder::execute(mutation& m, const exploded_clustering_prefix& row_key, const update_parameters& params)
-{
-    assert(column.type->is_multi_cell() && "Attempted to remove items from a frozen set");
-    auto elt = _t->bind(params._options);
-    if (!elt) {
-        throw exceptions::invalid_request_exception("Invalid null set element");
-    }
-    collection_type_impl::mutation mut;
-    mut.cells.emplace_back(*elt->get(params._options), params.make_dead_cell());
-    auto ctype = static_pointer_cast<const collection_type_impl>(column.type);
-    m.set_cell(row_key, column, ctype->serialize_mutation_form(mut));
-}
-
 }

cql3/sets.hh

@@ -133,13 +133,6 @@ public:
         }
         virtual void execute(mutation& m, const exploded_clustering_prefix& row_key, const update_parameters& params) override;
     };
-
-    class element_discarder : public operation {
-    public:
-        element_discarder(const column_definition& column, shared_ptr<term> t)
-            : operation(column, std::move(t)) { }
-        virtual void execute(mutation& m, const exploded_clustering_prefix& row_key, const update_parameters& params) override;
-    };
 };
 
 }

cql3/statements/modification_statement.cc

@@ -130,9 +130,9 @@ public:
                     const query::result_row_view& row) {
         update_parameters::prefetch_data::row cells;
 
-        auto add_cell = [&cells] (column_id id, std::experimental::optional<collection_mutation_view>&& cell) {
+        auto add_cell = [&cells] (column_id id, std::experimental::optional<collection_mutation::view>&& cell) {
             if (cell) {
-                cells.emplace(id, collection_mutation{to_bytes(cell->data)});
+                cells.emplace(id, collection_mutation::one{to_bytes(cell->data)});
             }
         };
 

cql3/statements/select_statement.cc

@@ -46,7 +46,6 @@
 #include "core/shared_ptr.hh"
 #include "query-result-reader.hh"
 #include "query_result_merger.hh"
-#include "service/pager/query_pagers.hh"
 
 namespace cql3 {
 
@@ -161,7 +160,7 @@ int32_t select_statement::get_limit(const query_options& options) const {
 
     try {
         int32_type->validate(*val);
-        auto l = value_cast<int32_t>(int32_type->deserialize(*val));
+        auto l = boost::any_cast<int32_t>(int32_type->deserialize(*val));
         if (l <= 0) {
             throw exceptions::invalid_request_exception("LIMIT must be strictly positive");
         }
@@ -196,51 +195,37 @@ select_statement::execute(distributed<service::storage_proxy>& proxy, service::q
         page_size = DEFAULT_COUNT_PAGE_SIZE;
     }
 
-    auto key_ranges = _restrictions->get_partition_key_ranges(options);
+    warn(unimplemented::cause::PAGING);
+    return execute(proxy, command, _restrictions->get_partition_key_ranges(options), state, options, now);
 
-    if (page_size <= 0
-            || !service::pager::query_pagers::may_need_paging(page_size,
-                    *command, key_ranges)) {
-        return execute(proxy, command, std::move(key_ranges), state, options,
-                now);
+#if 0
+    if (page_size <= 0 || !command || !query_pagers::may_need_paging(command, page_size)) {
+        return execute(proxy, command, state, options, now);
     }
 
-    auto p = service::pager::query_pagers::pager(_schema, _selection,
-            state, options, command, std::move(key_ranges));
+    auto pager = query_pagers::pager(command, cl, state.get_client_state(), options.get_paging_state());
 
-    if (_selection->is_aggregate()) {
-        return do_with(
-                cql3::selection::result_set_builder(*_selection, now,
-                        options.get_serialization_format()),
-                [p, page_size, now](auto& builder) {
-                    return do_until([p] {return p->is_exhausted();},
-                            [p, &builder, page_size, now] {
-                                return p->fetch_page(builder, page_size, now);
-                            }
-                    ).then([&builder] {
-                                auto rs = builder.build();
-                                auto msg = ::make_shared<transport::messages::result_message::rows>(std::move(rs));
-                                return make_ready_future<shared_ptr<transport::messages::result_message>>(std::move(msg));
-                            });
-                });
+    if (selection->isAggregate()) {
+        return page_aggregate_query(pager, options, page_size, now);
     }
 
+    // We can't properly do post-query ordering if we page (see #6722)
     if (needs_post_query_ordering()) {
         throw exceptions::invalid_request_exception(
-                "Cannot page queries with both ORDER BY and a IN restriction on the partition key;"
-                        " you must either remove the ORDER BY or the IN and sort client side, or disable paging for this query");
+              "Cannot page queries with both ORDER BY and a IN restriction on the partition key;"
+              " you must either remove the ORDER BY or the IN and sort client side, or disable paging for this query");
     }
 
-    return p->fetch_page(page_size, now).then(
-            [this, p, &options, limit, now](std::unique_ptr<cql3::result_set> rs) {
+    return pager->fetch_page(page_size).then([this, pager, &options, limit, now] (auto page) {
+        auto msg = process_results(page, options, limit, now);
 
-                if (!p->is_exhausted()) {
-                    rs->get_metadata().set_has_more_pages(p->state());
-                }
+        if (!pager->is_exhausted()) {
+            msg->result->metadata->set_has_more_pages(pager->state());
+        }
 
-                auto msg = ::make_shared<transport::messages::result_message::rows>(std::move(rs));
-                return make_ready_future<shared_ptr<transport::messages::result_message>>(std::move(msg));
-            });
+        return msg;
+    });
+#endif
 }
 
 future<shared_ptr<transport::messages::result_message>>
@@ -296,18 +281,114 @@ select_statement::execute_internal(distributed<service::storage_proxy>& proxy, s
     }
 }
 
-shared_ptr<transport::messages::result_message> select_statement::process_results(
-        foreign_ptr<lw_shared_ptr<query::result>> results,
-        lw_shared_ptr<query::read_command> cmd, const query_options& options,
-        db_clock::time_point now) {
+// Implements ResultVisitor concept from query.hh
+class result_set_building_visitor {
+    cql3::selection::result_set_builder& builder;
+    select_statement& stmt;
+    uint32_t _row_count;
+    std::vector<bytes> _partition_key;
+    std::vector<bytes> _clustering_key;
+public:
+    result_set_building_visitor(cql3::selection::result_set_builder& builder, select_statement& stmt)
+        : builder(builder)
+        , stmt(stmt)
+        , _row_count(0)
+    { }
+
+    void add_value(const column_definition& def, query::result_row_view::iterator_type& i) {
+        if (def.type->is_multi_cell()) {
+            auto cell = i.next_collection_cell();
+            if (!cell) {
+                builder.add_empty();
+                return;
+            }
+            builder.add(def, *cell);
+        } else {
+            auto cell = i.next_atomic_cell();
+            if (!cell) {
+                builder.add_empty();
+                return;
+            }
+            builder.add(def, *cell);
+        }
+    };
+
+    void accept_new_partition(const partition_key& key, uint32_t row_count) {
+        _partition_key = key.explode(*stmt._schema);
+        _row_count = row_count;
+    }
+
+    void accept_new_partition(uint32_t row_count) {
+        _row_count = row_count;
+    }
+
+    void accept_new_row(const clustering_key& key, const query::result_row_view& static_row,
+            const query::result_row_view& row) {
+        _clustering_key = key.explode(*stmt._schema);
+        accept_new_row(static_row, row);
+    }
+
+    void accept_new_row(const query::result_row_view& static_row, const query::result_row_view& row) {
+        auto static_row_iterator = static_row.iterator();
+        auto row_iterator = row.iterator();
+        builder.new_row();
+        for (auto&& def : stmt._selection->get_columns()) {
+            switch (def->kind) {
+                case column_kind::partition_key:
+                    builder.add(_partition_key[def->component_index()]);
+                    break;
+                case column_kind::clustering_key:
+                    builder.add(_clustering_key[def->component_index()]);
+                    break;
+                case column_kind::regular_column:
+                    add_value(*def, row_iterator);
+                    break;
+                case column_kind::compact_column:
+                    add_value(*def, row_iterator);
+                    break;
+                case column_kind::static_column:
+                    add_value(*def, static_row_iterator);
+                    break;
+                default:
+                    assert(0);
+            }
+        }
+    }
+
+    void accept_partition_end(const query::result_row_view& static_row) {
+        if (_row_count == 0) {
+            builder.new_row();
+            auto static_row_iterator = static_row.iterator();
+            for (auto&& def : stmt._selection->get_columns()) {
+                if (def->is_partition_key()) {
+                    builder.add(_partition_key[def->component_index()]);
+                } else if (def->is_static()) {
+                    add_value(*def, static_row_iterator);
+                } else {
+                    builder.add_empty();
+                }
+            }
+        }
+    }
+};
+
+shared_ptr<transport::messages::result_message>
+select_statement::process_results(foreign_ptr<lw_shared_ptr<query::result>> results, lw_shared_ptr<query::read_command> cmd,
+        const query_options& options, db_clock::time_point now) {
+    cql3::selection::result_set_builder builder(*_selection, now, options.get_serialization_format());
+
+    // FIXME: This special casing saves us the cost of copying an already
+    // linearized response. When we switch views to scattered_reader this will go away.
+    if (results->buf().is_linearized()) {
+        query::result_view view(results->buf().view());
+        view.consume(cmd->slice, result_set_building_visitor(builder, *this));
+    } else {
+        bytes_ostream w(results->buf());
+        query::result_view view(w.linearize());
+        view.consume(cmd->slice, result_set_building_visitor(builder, *this));
+    }
 
-    cql3::selection::result_set_builder builder(*_selection, now,
-            options.get_serialization_format());
-    query::result_view::consume(results->buf(), cmd->slice,
-            cql3::selection::result_set_builder::visitor(builder, *_schema,
-                    *_selection));
     auto rs = builder.build();
-
     if (needs_post_query_ordering()) {
         rs->sort(_ordering_comparator);
         if (_is_reversed) {

cql3/statements/select_statement.hh

@@ -63,6 +63,7 @@ namespace statements {
  *
  */
 class select_statement : public cql_statement {
+    friend class result_set_building_visitor;
 public:
     class parameters final {
     public:

cql3/tuples.hh

@@ -259,7 +259,7 @@ public:
             try {
                 // Collections have this small hack that validate cannot be called on a serialized object,
                 // but the deserialization does the validation (so we're fine).
-                auto l = value_cast<list_type_impl::native_type>(type->deserialize(value, options.get_serialization_format()));
+                auto l = boost::any_cast<list_type_impl::native_type>(type->deserialize(value, options.get_serialization_format()));
                 auto ttype = dynamic_pointer_cast<const tuple_type_impl>(type->get_elements_type());
                 assert(ttype);
 

cql3/untyped_result_set.hh

@@ -66,7 +66,7 @@ public:
         }
         template<typename T>
         T get_as(const sstring& name) const {
-            return value_cast<T>(data_type_for<T>()->deserialize(get_blob(name)));
+            return boost::any_cast<T>(data_type_for<T>()->deserialize(get_blob(name)));
         }
         // this could maybe be done as an overload of get_as (or something), but that just
         // muddles things for no real gain. Let user (us) attempt to know what he is doing instead.
@@ -75,12 +75,12 @@ public:
                 data_type_for<K>(), data_type valtype =
                 data_type_for<V>()) const {
             auto vec =
-                    value_cast<map_type_impl::native_type>(
+                    boost::any_cast<const map_type_impl::native_type&>(
                             map_type_impl::get_instance(keytype, valtype, false)->deserialize(
                                     get_blob(name)));
             std::transform(vec.begin(), vec.end(), out,
                     [](auto& p) {
-                        return std::pair<K, V>(value_cast<K>(p.first), value_cast<V>(p.second));
+                        return std::pair<K, V>(boost::any_cast<const K&>(p.first), boost::any_cast<const V&>(p.second));
                     });
         }
         template<typename K, typename V, typename ... Rest>

cql3/update_parameters.cc

@@ -43,7 +43,7 @@
 
 namespace cql3 {
 
-std::experimental::optional<collection_mutation_view>
+std::experimental::optional<collection_mutation::view>
 update_parameters::get_prefetched_list(
     const partition_key& pkey,
     const clustering_key& row_key,

cql3/update_parameters.hh

@@ -86,7 +86,7 @@ public:
                 return pk_eq(k1.first, k2.first) && ck_eq(k1.second, k2.second);
             }
         };
-        using row = std::unordered_map<column_id, collection_mutation>;
+        using row = std::unordered_map<column_id, collection_mutation::one>;
     public:
         std::unordered_map<key, row, key_hashing, key_equality> rows;
         schema_ptr schema;
@@ -183,7 +183,7 @@ public:
         return _timestamp;
     }
 
-    std::experimental::optional<collection_mutation_view> get_prefetched_list(
+    std::experimental::optional<collection_mutation::view> get_prefetched_list(
         const partition_key& pkey, const clustering_key& row_key, const column_definition& column) const;
 };
 

database.cc

@@ -546,10 +546,6 @@ column_family::try_flush_memtable_to_sstable(lw_shared_ptr<memtable> old) {
         sstables::sstable::version_types::ka,
         sstables::sstable::format_types::big);
 
-    auto memtable_size = old->occupancy().total_space();
-
-    _config.cf_stats->pending_memtables_flushes_count++;
-    _config.cf_stats->pending_memtables_flushes_bytes += memtable_size;
     newtab->set_unshared();
     dblog.debug("Flushing to {}", newtab->get_filename());
     return newtab->write_components(*old).then([this, newtab, old] {
@@ -573,33 +569,23 @@ column_family::try_flush_memtable_to_sstable(lw_shared_ptr<memtable> old) {
                 return newtab->create_links(dir);
             });
         });
-    }).then_wrapped([this, old, newtab, memtable_size] (future<> ret) {
-        _config.cf_stats->pending_memtables_flushes_count--;
-        _config.cf_stats->pending_memtables_flushes_bytes -= memtable_size;
+    }).then([this, old, newtab] {
         dblog.debug("Flushing done");
+        // We must add sstable before we call update_cache(), because
+        // memtable's data after moving to cache can be evicted at any time.
+        auto old_sstables = _sstables;
+        add_sstable(newtab);
+        old->mark_flushed(newtab);
+        return update_cache(*old, std::move(old_sstables));
+    }).then_wrapped([this, old] (future<> ret) {
         try {
             ret.get();
 
-            // We must add sstable before we call update_cache(), because
-            // memtable's data after moving to cache can be evicted at any time.
-            auto old_sstables = _sstables;
-            add_sstable(newtab);
-            old->mark_flushed(newtab);
-
+            _memtables->erase(boost::range::find(*_memtables, old));
+            dblog.debug("Memtable replaced");
             trigger_compaction();
 
-            return update_cache(*old, std::move(old_sstables)).then_wrapped([this, old] (future<> f) {
-                try {
-                    f.get();
-                } catch(...) {
-                    dblog.error("failed to move memtable to cache: {}", std::current_exception());
-                }
-
-                _memtables->erase(boost::range::find(*_memtables, old));
-                dblog.debug("Memtable replaced");
-
-                return make_ready_future<stop_iteration>(stop_iteration::yes);
-            });
+            return make_ready_future<stop_iteration>(stop_iteration::yes);
         } catch (...) {
             dblog.error("failed to write sstable: {}", std::current_exception());
         }
@@ -924,20 +910,6 @@ database::setup_collectd() {
                 , scollectd::make_typed(scollectd::data_type::GAUGE, [this] {
             return _dirty_memory_region_group.memory_used();
     })));
-
-    _collectd.push_back(
-        scollectd::add_polled_metric(scollectd::type_instance_id("memtables"
-                , scollectd::per_cpu_plugin_instance
-                , "queue_length", "pending_flushes")
-                , scollectd::make_typed(scollectd::data_type::GAUGE, _cf_stats.pending_memtables_flushes_count)
-    ));
-
-    _collectd.push_back(
-        scollectd::add_polled_metric(scollectd::type_instance_id("memtables"
-                , scollectd::per_cpu_plugin_instance
-                , "bytes", "pending_flushes")
-                , scollectd::make_typed(scollectd::data_type::GAUGE, _cf_stats.pending_memtables_flushes_bytes)
-    ));
 }
 
 database::~database() {
@@ -1272,7 +1244,6 @@ keyspace::make_column_family_config(const schema& s) const {
     cfg.enable_cache = _config.enable_cache;
     cfg.max_memtable_size = _config.max_memtable_size;
     cfg.dirty_memory_region_group = _config.dirty_memory_region_group;
-    cfg.cf_stats = _config.cf_stats;
     cfg.enable_incremental_backups = _config.enable_incremental_backups;
 
     return cfg;
@@ -1445,7 +1416,7 @@ column_family::query(const query::read_command& cmd, const std::vector<query::pa
             return do_until([&qs] { return !qs.limit || qs.range_empty; }, [this, &qs] {
                 return qs.reader().then([this, &qs](mutation_opt mo) {
                     if (mo) {
-                        auto p_builder = qs.builder.add_partition(*mo->schema(), mo->key());
+                        auto p_builder = qs.builder.add_partition(mo->key());
                         auto is_distinct = qs.cmd.slice.options.contains(query::partition_slice::option::distinct);
                         auto limit = !is_distinct ? qs.limit : 1;
                         mo->partition().query(p_builder, *_schema, qs.cmd.timestamp, limit);
@@ -1500,18 +1471,6 @@ database::query_mutations(const query::read_command& cmd, const query::partition
     }
 }
 
-std::unordered_set<sstring> database::get_initial_tokens() {
-    std::unordered_set<sstring> tokens;
-    sstring tokens_string = get_config().initial_token();
-    try {
-        boost::split(tokens, tokens_string, boost::is_any_of(sstring(",")));
-    } catch (...) {
-        throw std::runtime_error(sprint("Unable to parse initial_token=%s", tokens_string));
-    }
-    tokens.erase("");
-    return tokens;
-}
-
 std::ostream& operator<<(std::ostream& out, const atomic_cell_or_collection& c) {
     return out << to_hex(c._data);
 }
@@ -1630,7 +1589,6 @@ database::make_keyspace_config(const keyspace_metadata& ksm) {
         cfg.max_memtable_size = std::numeric_limits<size_t>::max();
     }
     cfg.dirty_memory_region_group = &_dirty_memory_region_group;
-    cfg.cf_stats = &_cf_stats;
     cfg.enable_incremental_backups = _cfg->incremental_backups();
     return cfg;
 }

database.hh

@@ -102,16 +102,6 @@ class replay_position_reordered_exception : public std::exception {};
 using memtable_list = std::vector<lw_shared_ptr<memtable>>;
 using sstable_list = sstables::sstable_list;
 
-// The CF has a "stats" structure. But we don't want all fields here,
-// since some of them are fairly complex for exporting to collectd. Also,
-// that structure matches what we export via the API, so better leave it
-// untouched. And we need more fields. We will summarize it in here what
-// we need.
-struct cf_stats {
-    int64_t pending_memtables_flushes_count = 0;
-    int64_t pending_memtables_flushes_bytes = 0;
-};
-
 class column_family {
 public:
     struct config {
@@ -123,7 +113,6 @@ public:
         bool enable_incremental_backups = false;
         size_t max_memtable_size = 5'000'000;
         logalloc::region_group* dirty_memory_region_group = nullptr;
-        ::cf_stats* cf_stats = nullptr;
     };
     struct no_commitlog {};
     struct stats {
@@ -456,7 +445,6 @@ public:
         bool enable_incremental_backups = false;
         size_t max_memtable_size = 5'000'000;
         logalloc::region_group* dirty_memory_region_group = nullptr;
-        ::cf_stats* cf_stats = nullptr;
     };
 private:
     std::unique_ptr<locator::abstract_replication_strategy> _replication_strategy;
@@ -515,7 +503,6 @@ public:
 //   use shard_of() for data
 
 class database {
-    ::cf_stats _cf_stats;
     logalloc::region_group _dirty_memory_region_group;
     std::unordered_map<sstring, keyspace> _keyspaces;
     std::unordered_map<utils::UUID, lw_shared_ptr<column_family>> _column_families;
@@ -646,8 +633,6 @@ public:
     const logalloc::region_group& dirty_memory_region_group() const {
         return _dirty_memory_region_group;
     }
-
-    std::unordered_set<sstring> get_initial_tokens();
 };
 
 // FIXME: stub

db/batchlog_manager.cc

@@ -132,7 +132,7 @@ mutation db::batchlog_manager::get_batch_log_mutation_for(const std::vector<muta
     mutation m(key, schema);
     m.set_cell({}, to_bytes("version"), version, timestamp);
     m.set_cell({}, to_bytes("written_at"), now, timestamp);
-    m.set_cell({}, to_bytes("data"), data_value(std::move(data)), timestamp);
+    m.set_cell({}, to_bytes("data"), std::move(data), timestamp);
 
     return m;
 }

db/commitlog/commitlog.cc

@@ -55,7 +55,6 @@
 #include <core/rwlock.hh>
 #include <core/gate.hh>
 #include <core/fstream.hh>
-#include <seastar/core/memory.hh>
 #include <net/byteorder.hh>
 
 #include "commitlog.hh"
@@ -90,7 +89,7 @@ public:
 
 db::commitlog::config::config(const db::config& cfg)
     : commit_log_location(cfg.commitlog_directory())
-    , commitlog_total_space_in_mb(cfg.commitlog_total_space_in_mb() >= 0 ? cfg.commitlog_total_space_in_mb() : memory::stats().total_memory())
+    , commitlog_total_space_in_mb(cfg.commitlog_total_space_in_mb())
     , commitlog_segment_size_in_mb(cfg.commitlog_segment_size_in_mb())
     , commitlog_sync_period_in_ms(cfg.commitlog_sync_batch_window_in_ms())
     , mode(cfg.commitlog_sync() == "batch" ? sync_mode::BATCH : sync_mode::PERIODIC)
@@ -316,8 +315,7 @@ public:
     // The commit log entry overhead in bytes (int: length + int: head checksum + int: tail checksum)
     static constexpr size_t entry_overhead_size = 3 * sizeof(uint32_t);
     static constexpr size_t segment_overhead_size = 2 * sizeof(uint32_t);
-    static constexpr size_t descriptor_header_size = 5 * sizeof(uint32_t);
-    static constexpr uint32_t segment_magic = ('S'<<24) |('C'<< 16) | ('L' << 8) | 'C';
+    static constexpr size_t descriptor_header_size = 4 * sizeof(uint32_t);
 
     // The commit log (chained) sync marker/header size in bytes (int: length + int: checksum [segmentId, position])
     static constexpr size_t sync_marker_size = 2 * sizeof(uint32_t);
@@ -485,7 +483,6 @@ public:
 
         if (off == 0) {
             // first block. write file header.
-            out.write(segment_magic);
             out.write(_desc.ver);
             out.write(_desc.id);
             crc32_nbo crc;
@@ -1235,20 +1232,16 @@ db::commitlog::read_log_file(file f, commit_load_reader_func next, position_type
                 }
                 // Will throw if we got eof
                 data_input in(buf);
-                auto magic = in.read<uint32_t>();
                 auto ver = in.read<uint32_t>();
                 auto id = in.read<uint64_t>();
                 auto checksum = in.read<uint32_t>();
 
-                if (magic == 0 && ver == 0 && id == 0 && checksum == 0) {
+                if (ver == 0 && id == 0 && checksum == 0) {
                     // let's assume this was an empty (pre-allocated)
                     // file. just skip it.
                     return stop();
                 }
 
-                if (magic != segment::segment_magic) {
-                    throw std::invalid_argument("Not a scylla format commitlog file");
-                }
                 crc32_nbo crc;
                 crc.process(ver);
                 crc.process<int32_t>(id & 0xffffffff);

db/commitlog/commitlog_replayer.cc

@@ -255,14 +255,7 @@ future<> db::commitlog_replayer::recover(std::vector<sstring> files) {
     return parallel_for_each(files, [this](auto f) {
         return this->recover(f).handle_exception([f](auto ep) {
             logger.error("Error recovering {}: {}", f, ep);
-            try {
-                std::rethrow_exception(ep);
-            } catch (std::invalid_argument&) {
-                logger.error("Scylla cannot process {}. Make sure to fully flush all Cassandra commit log files to sstable before migrating.");
-                throw;
-            } catch (...) {
-                throw;
-            }
+            std::rethrow_exception(ep);
         });
     });
 }

db/config.cc

@@ -31,7 +31,6 @@
 #include "core/fstream.hh"
 #include "core/do_with.hh"
 #include "log.hh"
-#include <boost/any.hpp>
 
 static logging::logger logger("config");
 

db/config.hh

@@ -316,7 +316,7 @@ public:
     val(commitlog_sync_batch_window_in_ms, uint32_t, 10000, Used,     \
             "Controls how long the system waits for other writes before performing a sync in \"batch\" mode."    \
     )   \
-    val(commitlog_total_space_in_mb, int64_t, -1, Used,     \
+    val(commitlog_total_space_in_mb, uint32_t, 8192, Used,     \
             "Total space used for commitlogs. If the used space goes above this value, Cassandra rounds up to the next nearest segment multiple and flushes memtables to disk for the oldest commitlog segments, removing those log segments. This reduces the amount of data to replay on startup, and prevents infrequently-updated tables from indefinitely keeping commitlog segments. A small total commitlog space tends to cause more flush activity on less-active tables.\n"  \
             "Related information: Configuring memtable throughput"  \
     )                                                   \
@@ -402,11 +402,11 @@ public:
     val(batch_size_warn_threshold_in_kb, uint32_t, 5, Unused,     \
             "Log WARN on any batch size exceeding this value in kilobytes. Caution should be taken on increasing the size of this threshold as it can lead to node instability."  \
     )   \
-    val(broadcast_address, sstring, /* listen_address */, Used, \
+    val(broadcast_address, sstring, /* listen_address */, Unused, \
             "The IP address a node tells other nodes in the cluster to contact it by. It allows public and private address to be different. For example, use the broadcast_address parameter in topologies where not all nodes have access to other nodes by their private IP addresses.\n" \
             "If your Cassandra cluster is deployed across multiple Amazon EC2 regions and you use the EC2MultiRegionSnitch , set the broadcast_address to public IP address of the node and the listen_address to the private IP."    \
     )   \
-    val(initial_token, sstring, /* N/A */, Used,     \
+    val(initial_token, sstring, /* N/A */, Unused,     \
             "Used in the single-node-per-token architecture, where a node owns exactly one contiguous range in the ring space. Setting this property overrides num_tokens.\n"   \
             "If you not using vnodes or have num_tokens set it to 1 or unspecified (#num_tokens), you should always specify this parameter when setting up a production cluster for the first time and when adding capacity. For more information, see this parameter in the Cassandra 1.1 Node and Cluster Configuration documentation.\n" \
             "This parameter can be used with num_tokens (vnodes ) in special cases such as Restoring from a snapshot." \
@@ -430,7 +430,7 @@ public:
             , "org.apache.cassandra.dht.ByteOrderedPartitioner" \
             , "org.apache.cassandra.dht.OrderPreservingPartitioner" \
     )                                                   \
-    val(storage_port, uint16_t, 7000, Used,                \
+    val(storage_port, uint16_t, 7000, Unused,                \
             "The port for inter-node communication."  \
     )                                                   \
     /* Advanced automatic backup setting */ \

db/query_context.hh

@@ -42,7 +42,7 @@ struct query_context {
     future<::shared_ptr<cql3::untyped_result_set>> execute_cql(sstring text, sstring cf, Args&&... args) {
         // FIXME: Would be better not to use sprint here.
         sstring req = sprint(text, cf);
-        return this->_qp.local().execute_internal(req, { data_value(std::forward<Args>(args))... });
+        return this->_qp.local().execute_internal(req, { boost::any(std::forward<Args>(args))... });
     }
     database& db() {
         return _db.local();
@@ -67,8 +67,9 @@ extern std::unique_ptr<query_context> qctx;
 // we executed the query, and return an empty result
 template <typename... Args>
 static future<::shared_ptr<cql3::untyped_result_set>> execute_cql(sstring text, Args&&... args) {
-    assert(qctx);
-    return qctx->execute_cql(text, std::forward<Args>(args)...);
+    if (qctx) {
+        return qctx->execute_cql(text, std::forward<Args>(args)...);
+    }
+    return make_ready_future<shared_ptr<cql3::untyped_result_set>>(::make_shared<cql3::untyped_result_set>(cql3::untyped_result_set::make_empty()));
 }
-
 }

db/schema_tables.cc

@@ -329,7 +329,7 @@ future<utils::UUID> calculate_schema_digest(distributed<service::storage_proxy>&
             std::vector<query::result> results;
             for (auto&& p : rs->partitions()) {
                 auto mut = p.mut().unfreeze(s);
-                auto partition_key = value_cast<sstring>(utf8_type->deserialize(mut.key().get_component(*s, 0)));
+                auto partition_key = boost::any_cast<sstring>(utf8_type->deserialize(mut.key().get_component(*s, 0)));
                 if (partition_key == system_keyspace::NAME) {
                     continue;
                 }
@@ -368,7 +368,7 @@ future<std::vector<frozen_mutation>> convert_schema_to_mutations(distributed<ser
             std::vector<frozen_mutation> results;
             for (auto&& p : rs->partitions()) {
                 auto mut = p.mut().unfreeze(s);
-                auto partition_key = value_cast<sstring>(utf8_type->deserialize(mut.key().get_component(*s, 0)));
+                auto partition_key = boost::any_cast<sstring>(utf8_type->deserialize(mut.key().get_component(*s, 0)));
                 if (partition_key == system_keyspace::NAME) {
                     continue;
                 }
@@ -468,7 +468,7 @@ future<> do_merge_schema(distributed<service::storage_proxy>& proxy, std::vector
        std::set<sstring> keyspaces;
        std::set<utils::UUID> column_families;
        for (auto&& mutation : mutations) {
-           keyspaces.emplace(value_cast<sstring>(utf8_type->deserialize(mutation.key().get_component(*s, 0))));
+           keyspaces.emplace(boost::any_cast<sstring>(utf8_type->deserialize(mutation.key().get_component(*s, 0))));
            column_families.emplace(mutation.column_family_id());
        }
 

db/serializer.cc

@@ -143,18 +143,18 @@ atomic_cell_view db::serializer<atomic_cell_view>::read(input& in) {
 }
 
 template<>
-db::serializer<collection_mutation_view>::serializer(const collection_mutation_view& c)
+db::serializer<collection_mutation::view>::serializer(const collection_mutation::view& c)
         : _item(c), _size(bytes_view_serializer(c.serialize()).size()) {
 }
 
 template<>
-void db::serializer<collection_mutation_view>::write(output& out, const collection_mutation_view& t) {
+void db::serializer<collection_mutation::view>::write(output& out, const collection_mutation::view& t) {
     bytes_view_serializer::write(out, t.serialize());
 }
 
 template<>
-void db::serializer<collection_mutation_view>::read(collection_mutation_view& c, input& in) {
-    c = collection_mutation_view::from_bytes(bytes_view_serializer::read(in));
+void db::serializer<collection_mutation::view>::read(collection_mutation::view& c, input& in) {
+    c = collection_mutation::view::from_bytes(bytes_view_serializer::read(in));
 }
 
 template<>
@@ -278,7 +278,7 @@ template class db::serializer<bytes> ;
 template class db::serializer<bytes_view> ;
 template class db::serializer<sstring> ;
 template class db::serializer<atomic_cell_view> ;
-template class db::serializer<collection_mutation_view> ;
+template class db::serializer<collection_mutation::view> ;
 template class db::serializer<utils::UUID> ;
 template class db::serializer<partition_key_view> ;
 template class db::serializer<clustering_key_view> ;

db/serializer.hh

@@ -109,9 +109,9 @@ template<> void serializer<atomic_cell_view>::write(output&, const type&);
 template<> void serializer<atomic_cell_view>::read(atomic_cell_view&, input&);
 template<> atomic_cell_view serializer<atomic_cell_view>::read(input&);
 
-template<> serializer<collection_mutation_view>::serializer(const collection_mutation_view &);
-template<> void serializer<collection_mutation_view>::write(output&, const type&);
-template<> void serializer<collection_mutation_view>::read(collection_mutation_view&, input&);
+template<> serializer<collection_mutation::view>::serializer(const collection_mutation::view &);
+template<> void serializer<collection_mutation::view>::write(output&, const type&);
+template<> void serializer<collection_mutation::view>::read(collection_mutation::view&, input&);
 
 template<> serializer<frozen_mutation>::serializer(const frozen_mutation &);
 template<> void serializer<frozen_mutation>::write(output&, const type&);
@@ -160,7 +160,7 @@ typedef serializer<bytes> bytes_serializer; // Compatible with bytes_view_serial
 typedef serializer<bytes_view> bytes_view_serializer; // Compatible with bytes_serializer
 typedef serializer<sstring> sstring_serializer;
 typedef serializer<atomic_cell_view> atomic_cell_view_serializer;
-typedef serializer<collection_mutation_view> collection_mutation_view_serializer;
+typedef serializer<collection_mutation::view> collection_mutation_view_serializer;
 typedef serializer<utils::UUID> uuid_serializer;
 typedef serializer<partition_key_view> partition_key_view_serializer;
 typedef serializer<clustering_key_view> clustering_key_view_serializer;

db/system_keyspace.cc

@@ -486,7 +486,9 @@ future<> init_local_cache() {
 }
 
 void minimal_setup(distributed<database>& db, distributed<cql3::query_processor>& qp) {
-    qctx = std::make_unique<query_context>(db, qp);
+    auto new_ctx = std::make_unique<query_context>(db, qp);
+    qctx.swap(new_ctx);
+    assert(!new_ctx);
 }
 
 future<> setup(distributed<database>& db, distributed<cql3::query_processor>& qp) {
@@ -538,11 +540,10 @@ future<> save_truncation_records(const column_family& cf, db_clock::time_point t
     out.write<db_clock::rep>(truncated_at.time_since_epoch().count());
 
     map_type_impl::native_type tmp;
-    tmp.emplace_back(cf.schema()->id(), data_value(buf));
-    auto map_type = map_type_impl::get_instance(uuid_type, bytes_type, true);
+    tmp.emplace_back(boost::any{ cf.schema()->id() }, boost::any{ buf });
 
     sstring req = sprint("UPDATE system.%s SET truncated_at = truncated_at + ? WHERE key = '%s'", LOCAL, LOCAL);
-    return qctx->qp().execute_internal(req, {make_map_value(map_type, tmp)}).then([](auto rs) {
+    return qctx->qp().execute_internal(req, {tmp}).then([](auto rs) {
         truncation_records = {};
         return force_blocking_flush(LOCAL);
     });
@@ -632,7 +633,7 @@ future<db_clock::time_point> get_truncated_at(utils::UUID cf_id) {
 set_type_impl::native_type prepare_tokens(std::unordered_set<dht::token>& tokens) {
     set_type_impl::native_type tset;
     for (auto& t: tokens) {
-        tset.push_back(dht::global_partitioner().to_sstring(t));
+        tset.push_back(boost::any(dht::global_partitioner().to_sstring(t)));
     }
     return tset;
 }
@@ -640,7 +641,7 @@ set_type_impl::native_type prepare_tokens(std::unordered_set<dht::token>& tokens
 std::unordered_set<dht::token> decode_tokens(set_type_impl::native_type& tokens) {
     std::unordered_set<dht::token> tset;
     for (auto& t: tokens) {
-        auto str = value_cast<sstring>(t);
+        auto str = boost::any_cast<sstring>(t);
         assert(str == dht::global_partitioner().to_sstring(dht::global_partitioner().from_sstring(str)));
         tset.insert(dht::global_partitioner().from_sstring(str));
     }
@@ -657,8 +658,7 @@ future<> update_tokens(gms::inet_address ep, std::unordered_set<dht::token> toke
     }
 
     sstring req = "INSERT INTO system.%s (peer, tokens) VALUES (?, ?)";
-    auto set_type = set_type_impl::get_instance(utf8_type, true);
-    return execute_cql(req, PEERS, ep.addr(), make_set_value(set_type, prepare_tokens(tokens))).discard_result().then([] {
+    return execute_cql(req, PEERS, ep.addr(), prepare_tokens(tokens)).discard_result().then([] {
         return force_blocking_flush(PEERS);
     });
 }
@@ -689,7 +689,7 @@ future<std::unordered_map<gms::inet_address, std::unordered_set<dht::token>>> lo
                 auto blob = row.get_blob("tokens");
                 auto cdef = peers()->get_column_definition("tokens");
                 auto deserialized = cdef->type->deserialize(blob);
-                auto tokens = value_cast<set_type_impl::native_type>(deserialized);
+                auto tokens = boost::any_cast<set_type_impl::native_type>(deserialized);
 
                 ret->emplace(peer, decode_tokens(tokens));
             }
@@ -808,14 +808,16 @@ future<> update_tokens(std::unordered_set<dht::token> tokens) {
     }
 
     sstring req = "INSERT INTO system.%s (key, tokens) VALUES (?, ?)";
-    auto set_type = set_type_impl::get_instance(utf8_type, true);
-    return execute_cql(req, LOCAL, sstring(LOCAL), make_set_value(set_type, prepare_tokens(tokens))).discard_result().then([] {
+    return execute_cql(req, LOCAL, sstring(LOCAL), prepare_tokens(tokens)).discard_result().then([] {
         return force_blocking_flush(LOCAL);
     });
 }
 
 future<> force_blocking_flush(sstring cfname) {
-    assert(qctx);
+    if (!qctx) {
+        return make_ready_future<>();
+    }
+
     return qctx->_db.invoke_on_all([cfname = std::move(cfname)](database& db) {
         // if (!Boolean.getBoolean("cassandra.unsafesystem"))
         column_family& cf = db.find_column_family(NAME, cfname);
@@ -860,7 +862,7 @@ future<std::unordered_set<dht::token>> get_saved_tokens() {
         auto blob = msg->one().get_blob("tokens");
         auto cdef = local()->get_column_definition("tokens");
         auto deserialized = cdef->type->deserialize(blob);
-        auto tokens = value_cast<set_type_impl::native_type>(deserialized);
+        auto tokens = boost::any_cast<set_type_impl::native_type>(deserialized);
 
         return make_ready_future<std::unordered_set<dht::token>>(decode_tokens(tokens));
     });

debian/control

@@ -3,22 +3,18 @@ Maintainer: Takuya ASADA <syuu@scylladb.com>
 Homepage: http://scylladb.com
 Section: database
 Priority: optional
-Standards-Version: 3.9.5
-Build-Depends: debhelper (>= 9), libyaml-cpp-dev, liblz4-dev, libsnappy-dev, libcrypto++-dev, libjsoncpp-dev, libaio-dev, libthrift-dev, thrift-compiler, antlr3-tool, antlr3-c++-dev, ragel, g++-5, ninja-build, git, libboost-program-options1.55-dev, libboost-filesystem1.55-dev, libboost-system1.55-dev, libboost-thread1.55-dev, libboost-test1.55-dev
+Standards-Version: 3.9.2
+Build-Depends: debhelper (>= 9), libyaml-cpp-dev, liblz4-dev, libsnappy-dev, libcrypto++-dev, libjsoncpp-dev, libaio-dev, libthrift-dev, thrift-compiler, antlr3-tool, antlr3-c++-dev, ragel, g++-4.9, ninja-build, git, libboost-program-options1.55-dev, libboost-filesystem1.55-dev, libboost-system1.55-dev, libboost-thread1.55-dev, libboost-test1.55-dev
 
 Package: scylla-server
 Architecture: amd64
-Depends: ${shlibs:Depends}, ${misc:Depends}, hugepages, adduser
+Depends: ${shlibs:Depends}, ${misc:Depends}, hugepages
 Description: Scylla database server binaries 
- Scylla is a highly scalable, eventually consistent, distributed,
- partitioned row DB.
+ Scylla is a highly scalable, eventually consistent, distributed, partitioned row DB.
 
 Package: scylla-server-dbg
-Section: debug
-Priority: extra
 Architecture: amd64
 Depends: scylla-server (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
 Description: debugging symbols for scylla-server
- Scylla is a highly scalable, eventually consistent, distributed,
- partitioned row DB.
+ Scylla is a highly scalable, eventually consistent, distributed, partitioned row DB.
  This package contains the debugging symbols for scylla-server.

debian/copyright

@@ -0,0 +1,16 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: Scylla DB
+Upstream-Contact: http://www.scylladb.com/
+Source: https://github.com/scylladb/scylla
+
+Files: *
+Copyright: Copyright (C) 2015 ScyllaDB
+License: AGPL-3.0
+
+Files: seastar/*
+Copyright: Copyright (C) 2015 ScyllaDB
+License: Apache
+
+Files: seastar/dpdk/*
+Copyright: Copyright(c) 2015 Intel Corporation. All rights reserved.
+License: BSD-3-clause

debian/rules

@@ -4,10 +4,9 @@ DOC = $(CURDIR)/debian/scylla-server/usr/share/doc/scylla-server
 SCRIPTS = $(CURDIR)/debian/scylla-server/usr/lib/scylla
 LIMITS= $(CURDIR)/debian/scylla-server/etc/security/limits.d
 LIBS = $(CURDIR)/debian/scylla-server/usr/lib
-CONF = $(CURDIR)/debian/scylla-server/etc/scylla
 
 override_dh_auto_build:
-	./configure.py --disable-xen --enable-dpdk --mode=release --static-stdc++ --compiler=g++-5
+	./configure.py --disable-xen --enable-dpdk --mode=release --static-stdc++ --compiler=g++-4.9
 	ninja
 
 override_dh_auto_clean:
@@ -16,12 +15,12 @@ override_dh_auto_clean:
 	rm -rf build.ninja seastar/build.ninja
 
 override_dh_auto_install:
-	mkdir -p $(LIMITS) && \
-	cp $(CURDIR)/dist/common/limits.d/scylla.conf  $(LIMITS)
+	mkdir -p $(CURDIR)/debian/scylla-server/etc/default/ && \
+	cp $(CURDIR)/dist/redhat/sysconfig/scylla-server  \
+		$(CURDIR)/debian/scylla-server/etc/default/
 
-	mkdir -p $(CONF) && \
-	cp $(CURDIR)/conf/scylla.yaml $(CONF)
-	cp $(CURDIR)/conf/cassandra-rackdc.properties $(CONF)
+	mkdir -p $(LIMITS) && \
+	cp $(CURDIR)/debian/limits.d/scylla.conf  $(LIMITS)
 
 	mkdir -p $(DOC) && \
 	cp $(CURDIR)/*.md $(DOC)
@@ -39,6 +38,11 @@ override_dh_auto_install:
 
 	mkdir -p $(CURDIR)/debian/scylla-server/var/lib/scylla/data
 	mkdir -p $(CURDIR)/debian/scylla-server/var/lib/scylla/commitlog
+	mkdir -p $(CURDIR)/debian/scylla-server/var/lib/scylla/conf
+	cp $(CURDIR)/conf/scylla.yaml \
+		$(CURDIR)/debian/scylla-server/var/lib/scylla/conf
+	cp $(CURDIR)/conf/cassandra-rackdc.properties \
+		$(CURDIR)/debian/scylla-server/var/lib/scylla/conf
 
 override_dh_strip:
 	dh_strip --dbg-package=scylla-server-dbg

debian/scylla-server.postinst

@@ -0,0 +1,24 @@
+#!/bin/sh
+
+set -e
+
+if [ "$1" = configure ]; then
+    adduser --system \
+            --quiet \
+            --home /var/lib/scylla \
+            --no-create-home \
+            --disabled-password \
+            --group scylla
+    chown -R scylla:scylla /var/lib/scylla
+fi
+
+# Automatically added by dh_installinit
+if [ -x "/etc/init.d/scylla-server" ]; then
+	if [ ! -e "/etc/init/scylla-server.conf" ]; then
+		update-rc.d scylla-server defaults >/dev/null
+	fi
+fi
+# End automatically added section
+# Automatically added by dh_installinit
+update-rc.d -f scylla-server remove >/dev/null || exit $?
+# End automatically added section

debian/scylla-server.preinst

@@ -0,0 +1,9 @@
+# Automatically added by dh_installinit
+if [ "$1" = install ] || [ "$1" = upgrade ]; then
+	if [ -e "/etc/init.d/scylla-server" ] && [ -L "/etc/init.d/scylla-server" ] \
+	   && [ $(readlink -f "/etc/init.d/scylla-server") = /lib/init/upstart-job ]
+	then
+		rm -f "/etc/init.d/scylla-server"
+	fi
+fi
+# End automatically added section

debian/scylla-server.upstart

@@ -14,20 +14,20 @@ console log
 pre-start script
     cd /var/lib/scylla
     . /etc/default/scylla-server
-    export NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_HOME SCYLLA_CONF SCYLLA_ARGS
+    export OPTS_FILE NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_ARGS
     /usr/lib/scylla/scylla_prepare
 end script
 
 script
     cd /var/lib/scylla
     . /etc/default/scylla-server
-    export NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_HOME SCYLLA_CONF SCYLLA_ARGS
+    export OPTS_FILE NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_ARGS
     exec /usr/lib/scylla/scylla_run
 end script
 
 post-stop script
     cd /var/lib/scylla
     . /etc/default/scylla-server
-    export NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_HOME SCYLLA_CONF SCYLLA_ARGS
+    export OPTS_FILE NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_ARGS
     /usr/lib/scylla/scylla_stop
 end script

dht/boot_strapper.cc

@@ -71,33 +71,33 @@ future<> boot_strapper::bootstrap() {
 }
 
 std::unordered_set<token> boot_strapper::get_bootstrap_tokens(token_metadata metadata, database& db) {
-    auto initial_tokens = db.get_initial_tokens();
+#if 0
+    Collection<String> initialTokens = DatabaseDescriptor.getInitialTokens();
     // if user specified tokens, use those
-    if (initial_tokens.size() > 0) {
-        logger.debug("tokens manually specified as {}", initial_tokens);
-        std::unordered_set<token> tokens;
-        for (auto& token_string : initial_tokens) {
-            auto token = dht::global_partitioner().from_sstring(token_string);
-            if (metadata.get_endpoint(token)) {
-                throw std::runtime_error(sprint("Bootstrapping to existing token %s is not allowed (decommission/removenode the old node first).", token_string));
-            }
-            tokens.insert(token);
+    if (initialTokens.size() > 0)
+    {
+        logger.debug("tokens manually specified as {}",  initialTokens);
+        List<Token> tokens = new ArrayList<Token>(initialTokens.size());
+        for (String tokenString : initialTokens)
+        {
+            Token token = StorageService.getPartitioner().getTokenFactory().fromString(tokenString);
+            if (metadata.getEndpoint(token) != null)
+                throw new ConfigurationException("Bootstrapping to existing token " + tokenString + " is not allowed (decommission/removenode the old node first).");
+            tokens.add(token);
         }
-        logger.debug("Get manually specified bootstrap_tokens={}", tokens);
         return tokens;
     }
-
+#endif
     size_t num_tokens = db.get_config().num_tokens();
     if (num_tokens < 1) {
         throw std::runtime_error("num_tokens must be >= 1");
     }
 
-    if (num_tokens == 1) {
-        logger.warn("Picking random token for a single vnode.  You should probably add more vnodes; failing that, you should probably specify the token manually");
-    }
+    // if (numTokens == 1)
+    //     logger.warn("Picking random token for a single vnode.  You should probably add more vnodes; failing that, you should probably specify the token manually");
 
     auto tokens = get_random_tokens(metadata, num_tokens);
-    logger.debug("Get random bootstrap_tokens={}", tokens);
+    logger.debug("Get bootstrap_tokens={}", tokens);
     return tokens;
 }
 

dht/murmur3_partitioner.cc

@@ -75,9 +75,6 @@ token murmur3_partitioner::get_random_token() {
 }
 
 inline int64_t long_token(const token& t) {
-    if (t.is_minimum()) {
-        return std::numeric_limits<long>::min();
-    }
 
     if (t._data.size() != sizeof(int64_t)) {
         throw runtime_exception(sprint("Invalid token. Should have size %ld, has size %ld\n", sizeof(int64_t), t._data.size()));

dht/range_streamer.cc

@@ -41,7 +41,6 @@
 #include "locator/snitch_base.hh"
 #include "database.hh"
 #include "gms/gossiper.hh"
-#include "gms/failure_detector.hh"
 #include "log.hh"
 #include "streaming/stream_plan.hh"
 #include "streaming/stream_state.hh"
@@ -56,7 +55,14 @@ static std::unordered_map<range<token>, std::unordered_set<inet_address>>
 unordered_multimap_to_unordered_map(const std::unordered_multimap<range<token>, inet_address>& multimap) {
     std::unordered_map<range<token>, std::unordered_set<inet_address>> ret;
     for (auto x : multimap) {
-        ret[x.first].emplace(x.second);
+        auto& range_token = x.first;
+        auto& ep = x.second;
+        auto it = ret.find(range_token);
+        if (it != ret.end()) {
+            it->second.emplace(ep);
+        } else {
+            ret.emplace(range_token, std::unordered_set<inet_address>{ep});
+        }
     }
     return ret;
 }
@@ -160,24 +166,23 @@ range_streamer::get_all_ranges_with_strict_sources_for(const sstring& keyspace_n
         for (auto& x : range_addresses) {
             const range<token>& src_range = x.first;
             if (src_range.contains(desired_range, dht::tri_compare)) {
-                std::vector<inet_address> old_endpoints(x.second.begin(), x.second.end());
+                auto old_endpoints = x.second;
                 auto it = pending_range_addresses.find(desired_range);
-                if (it == pending_range_addresses.end()) {
-                    throw std::runtime_error(sprint("Can not find desired_range = {} in pending_range_addresses", desired_range));
-                }
-                std::unordered_set<inet_address> new_endpoints = it->second;
+                assert (it != pending_range_addresses.end());
+                auto new_endpoints = it->second;
 
                 //Due to CASSANDRA-5953 we can have a higher RF then we have endpoints.
                 //So we need to be careful to only be strict when endpoints == RF
                 if (old_endpoints.size() == strat.get_replication_factor()) {
-                    auto it = std::remove_if(old_endpoints.begin(), old_endpoints.end(),
-                        [&new_endpoints] (inet_address ep) { return new_endpoints.count(ep); });
-                    old_endpoints.erase(it, old_endpoints.end());
+                    std::unordered_set<inet_address> diff;
+                    std::set_difference(old_endpoints.begin(), old_endpoints.end(),
+                            new_endpoints.begin(), new_endpoints.end(), std::inserter(diff, diff.begin()));
+                    old_endpoints = std::move(diff);
                     if (old_endpoints.size() != 1) {
-                        throw std::runtime_error(sprint("Expected 1 endpoint but found %d", old_endpoints.size()));
+                        throw std::runtime_error(sprint("Expected 1 endpoint but found ", old_endpoints.size()));
                     }
                 }
-                range_sources.emplace(desired_range, old_endpoints.front());
+                range_sources.emplace(desired_range, *(old_endpoints.begin()));
             }
         }
 
@@ -263,13 +268,4 @@ future<streaming::stream_state> range_streamer::fetch_async() {
     return _stream_plan.execute();
 }
 
-std::unordered_multimap<inet_address, range<token>>
-range_streamer::get_work_map(const std::unordered_multimap<range<token>, inet_address>& ranges_with_source_target,
-             const sstring& keyspace) {
-    auto filter = std::make_unique<dht::range_streamer::failure_detector_source_filter>(gms::get_local_failure_detector());
-    std::unordered_set<std::unique_ptr<i_source_filter>> source_filters;
-    source_filters.emplace(std::move(filter));
-    return get_range_fetch_map(ranges_with_source_target, source_filters, keyspace);
-}
-
 } // dht

dht/range_streamer.hh

@@ -73,7 +73,6 @@ public:
     class i_source_filter {
     public:
         virtual bool should_include(inet_address endpoint) = 0;
-        virtual ~i_source_filter() {}
     };
 
     /**
@@ -149,11 +148,11 @@ private:
                         const std::unordered_set<std::unique_ptr<i_source_filter>>& source_filters,
                         const sstring& keyspace);
 
-public:
-    static std::unordered_multimap<inet_address, range<token>>
-    get_work_map(const std::unordered_multimap<range<token>, inet_address>& ranges_with_source_target,
-                 const sstring& keyspace);
 #if 0
+    public static Multimap<InetAddress, Range<Token>> getWorkMap(Multimap<Range<Token>, InetAddress> rangesWithSourceTarget, String keyspace)
+    {
+        return getRangeFetchMap(rangesWithSourceTarget, Collections.<ISourceFilter>singleton(new FailureDetectorSourceFilter(FailureDetector.instance)), keyspace);
+    }
 
     // For testing purposes
     Multimap<String, Map.Entry<InetAddress, Collection<Range<Token>>>> toFetch()

dht/token_range.hh

@@ -1,39 +0,0 @@
-/*
- * Copyright (C) 2015 ScyllaDB.
- */
-
-/*
- * This file is part of Scylla.
- *
- * Scylla is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * Scylla is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General License for more details.
- *
- * You should have received a copy of the GNU General License
- * along with Scylla.  If not, see <http://www.gnu.org/licenses/>.
- */
-
-#pragma once
-#include <vector>
-
-namespace dht {
-struct endpoint_details {
-    sstring _host;
-    sstring _datacenter;
-    sstring _rack;
-};
-
-struct token_range {
-    sstring _start_token;
-    sstring _end_token;
-    std::vector<sstring> _endpoints;
-    std::vector<sstring> _rpc_endpoints;
-    std::vector<endpoint_details> _endpoint_details;
-};
-}

dist/ami/files/scylla-setup.sh

@@ -27,7 +27,7 @@ if [ $NR -ge 1 ]; then
     mdadm --detail --scan >> /etc/mdadm.conf
     UUID=`blkid /dev/md0 | awk '{print $2}'`
     mkdir /data
-    echo "$UUID /data xfs noatime,discard 0 0" >> /etc/fstab
+    echo "$UUID /data xfs noatime 0 0" >> /etc/fstab
     mount /data
 else
    echo "WARN: Scylla is not using XFS to store data. Perforamnce will suffer." > /home/fedora/WARN_PLEASE_READ.TXT

dist/common/scripts/scylla_run

@@ -1,6 +1,6 @@
 #!/bin/sh -e
 
-args="--log-to-syslog 1 --log-to-stdout 0 --default-log-level info $SCYLLA_ARGS"
+args="--log-to-syslog 1 --log-to-stdout 0 --default-log-level info --options-file $OPTS_FILE $SCYLLA_ARGS"
 
 if [ "$NETWORK_MODE" = "posix" ]; then
     args="$args --network-stack posix"
@@ -14,5 +14,4 @@ if [ "$SET_NIC" == "yes" ]; then
     sudo sh /usr/lib/scylla/posix_net_conf.sh >/dev/null 2>&1 || true
 fi
 
-export HOME=/var/lib/scylla
-exec sudo -E -u $USER /usr/bin/scylla $args
+exec sudo -u $USER env HOME=/var/lib/scylla SCYLLA_HOME=/var/lib/scylla /usr/bin/scylla $args

dist/redhat/limits.d/scylla.conf

@@ -0,0 +1,4 @@
+scylla  -  memlock  unlimited
+scylla  -  nofile   100000
+scylla  -  as       unlimited
+scylla  -  nproc    8096

dist/redhat/scylla-server.spec.in

@@ -32,16 +32,12 @@ rm -rf $RPM_BUILD_ROOT
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/
 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/security/limits.d/
-mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/scylla/
 mkdir -p $RPM_BUILD_ROOT%{_docdir}/scylla/
 mkdir -p $RPM_BUILD_ROOT%{_unitdir}
 mkdir -p $RPM_BUILD_ROOT%{_prefix}/lib/scylla/
 
-install -m644 dist/common/sysconfig/scylla-server $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/
-install -m644 dist/common/limits.d/scylla.conf $RPM_BUILD_ROOT%{_sysconfdir}/security/limits.d/
-install -d -m755 $RPM_BUILD_ROOT%{_sysconfdir}/scylla
-install -m644 conf/scylla.yaml $RPM_BUILD_ROOT%{_sysconfdir}/scylla/
-install -m644 conf/cassandra-rackdc.properties $RPM_BUILD_ROOT%{_sysconfdir}/scylla/
+install -m644 dist/redhat/sysconfig/scylla-server $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/
+install -m644 dist/redhat/limits.d/scylla.conf $RPM_BUILD_ROOT%{_sysconfdir}/security/limits.d/
 install -m644 dist/redhat/systemd/scylla-server.service $RPM_BUILD_ROOT%{_unitdir}/
 install -m755 dist/common/scripts/* $RPM_BUILD_ROOT%{_prefix}/lib/scylla/
 install -m755 seastar/scripts/posix_net_conf.sh  $RPM_BUILD_ROOT%{_prefix}/lib/scylla/
@@ -57,6 +53,9 @@ install -m644 licenses/* $RPM_BUILD_ROOT%{_docdir}/scylla/licenses/
 install -d -m755 $RPM_BUILD_ROOT%{_sharedstatedir}/scylla/
 install -d -m755 $RPM_BUILD_ROOT%{_sharedstatedir}/scylla/data
 install -d -m755 $RPM_BUILD_ROOT%{_sharedstatedir}/scylla/commitlog
+install -d -m755 $RPM_BUILD_ROOT%{_sharedstatedir}/scylla/conf
+install -m644 conf/scylla.yaml $RPM_BUILD_ROOT%{_sharedstatedir}/scylla/conf/
+install -m644 conf/cassandra-rackdc.properties $RPM_BUILD_ROOT%{_sharedstatedir}/scylla/conf/
 
 %pre
 /usr/sbin/groupadd scylla 2> /dev/null || :
@@ -66,11 +65,6 @@ sed -e "s/Defaults    requiretty/#Defaults    requiretty/" /etc/sudoers > /tmp/s
 cp /tmp/sudoers /etc/sudoers
 rm /tmp/sudoers
 %endif
-TMP=""
-# This is for existing users who already installed scylla.yaml on /var/lib/scylla/conf
-if [ -d /var/lib/scylla/conf ] && [ ! -L /var/lib/scylla/conf ]; then
-    cp -a /var/lib/scylla/conf /tmp/%{name}-%{version}-%{release}
-fi
 
 %post
 %systemd_post scylla-server.service
@@ -81,24 +75,14 @@ fi
 %postun
 %systemd_postun
 
-%posttrans
-if  [ -d /tmp/%{name}-%{version}-%{release} ]; then
-    cp -a /tmp/%{name}-%{version}-%{release}/* /etc/scylla/
-    rm -rf /tmp/%{name}-%{version}-%{release}/
-fi
-ln -sfT /etc/scylla /var/lib/scylla/conf
-
 %clean
 rm -rf $RPM_BUILD_ROOT
 
 %files
 %defattr(-,root,root)
 
-%config(noreplace) %{_sysconfdir}/sysconfig/scylla-server
+%{_sysconfdir}/sysconfig/scylla-server
 %{_sysconfdir}/security/limits.d/scylla.conf
-%attr(0755,root,root) %dir %{_sysconfdir}/scylla
-%config(noreplace) %{_sysconfdir}/scylla/scylla.yaml
-%config(noreplace) %{_sysconfdir}/scylla/cassandra-rackdc.properties
 %{_docdir}/scylla/README.md
 %{_docdir}/scylla/README-DPDK.md
 %{_docdir}/scylla/NOTICE.txt
@@ -116,6 +100,9 @@ rm -rf $RPM_BUILD_ROOT
 %attr(0755,scylla,scylla) %dir %{_sharedstatedir}/scylla/
 %attr(0755,scylla,scylla) %dir %{_sharedstatedir}/scylla/data
 %attr(0755,scylla,scylla) %dir %{_sharedstatedir}/scylla/commitlog
+%attr(0755,root,root) %dir %{_sharedstatedir}/scylla/conf/
+%{_sharedstatedir}/scylla/conf/scylla.yaml
+%{_sharedstatedir}/scylla/conf/cassandra-rackdc.properties
 
 %changelog
 * Tue Jul 21 2015 Takuya ASADA <syuu@cloudius-systems.com>

dist/redhat/sysconfig/scylla-server

@@ -1,3 +1,6 @@
+# path for options file:
+OPTS_FILE=/var/lib/scylla/conf/scylla.yaml
+
 # choose following mode: virtio, dpdk, posix
 NETWORK_MODE=posix
 
@@ -22,11 +25,5 @@ USER=scylla
 # group for process
 GROUP=scylla
 
-# scylla home dir
-SCYLLA_HOME=/var/lib/scylla
-
-# scylla config dir
-SCYLLA_CONF=/etc/scylla
-
 # additional arguments
 SCYLLA_ARGS=""

dist/ubuntu/build_deb.sh

@@ -5,26 +5,6 @@ if [ ! -e dist/ubuntu/build_deb.sh ]; then
     exit 1
 fi
 
-if [ -e debian ] || [ -e build/release ]; then
-    rm -rf debian build
-    mkdir build
-fi
-
-VERSION=$(./SCYLLA-VERSION-GEN)
-SCYLLA_VERSION=$(cat build/SCYLLA-VERSION-FILE)
-SCYLLA_RELEASE=$(cat build/SCYLLA-RELEASE-FILE)
-if [ "$SCYLLA_VERSION" = "development" ]; then
-	SCYLLA_VERSION=0development
-fi
-echo $VERSION > version
-./scripts/git-archive-all --extra version --force-submodules --prefix scylla-server ../scylla-server_$SCYLLA_VERSION-$SCYLLA_RELEASE.orig.tar.gz 
-
-cp -a dist/ubuntu/debian debian
-cp dist/common/sysconfig/scylla-server debian/scylla-server.default
-cp dist/ubuntu/changelog.in debian/changelog
-sed -i -e "s/@@VERSION@@/$SCYLLA_VERSION/g" debian/changelog
-sed -i -e "s/@@RELEASE@@/$SCYLLA_RELEASE/g" debian/changelog
-
 sudo apt-get -y update
 
 ./dist/ubuntu/dep/build_dependency.sh
@@ -32,6 +12,16 @@ sudo apt-get -y update
 sudo apt-get -y install libyaml-cpp-dev liblz4-dev libsnappy-dev libcrypto++-dev libboost1.55-dev libjsoncpp-dev libaio-dev ragel ninja-build git libyaml-cpp0.5 liblz4-1 libsnappy1 libcrypto++9 libboost-program-options1.55.0 libboost-program-options1.55-dev libboost-system1.55.0 libboost-system1.55-dev libboost-thread1.55.0 libboost-thread1.55-dev libboost-test1.55.0 libboost-test1.55-dev libjsoncpp0 libaio1 hugepages software-properties-common libboost-filesystem1.55-dev libboost-filesystem1.55.0
 sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
 sudo apt-get -y update
-sudo apt-get -y install g++-5
+sudo apt-get -y install g++-4.9
 
-debuild -r fakeroot -us -uc
+VERSION=$(./SCYLLA-VERSION-GEN)
+SCYLLA_VERSION=$(cat build/SCYLLA-VERSION-FILE)
+SCYLLA_RELEASE=$(cat build/SCYLLA-RELEASE-FILE)
+if [ "$SCYLLA_VERSION" = "development" ]; then
+	SCYLLA_VERSION=0development
+fi
+cp dist/ubuntu/changelog.in debian/changelog
+sed -i -e "s/@@VERSION@@/$SCYLLA_VERSION/g" debian/changelog
+sed -i -e "s/@@RELEASE@@/$SCYLLA_RELEASE/g" debian/changelog
+
+debuild -r fakeroot --no-tgz-check -us -uc

dist/ubuntu/debian/copyright

@@ -1,728 +0,0 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: Scylla DB
-Upstream-Contact: http://www.scylladb.com/
-Source: https://github.com/scylladb/scylla
-
-Files: *
-Copyright: Copyright (C) 2015 ScyllaDB
-License: AGPL-3.0
-
-Files: seastar/*
-Copyright: Copyright (C) 2015 ScyllaDB
-License: Apache-2.0
-
-Files: seastar/dpdk/*
-Copyright: Copyright(c) 2015 Intel Corporation. All rights reserved.
-License: BSD-3-clause
-
-License: AGPL-3.0
-                     GNU AFFERO GENERAL PUBLIC LICENSE
-                        Version 3, 19 November 2007
- .
-  Copyright (C) 2007 Free Software Foundation, Inc. <http://fsf.org/>
-  Everyone is permitted to copy and distribute verbatim copies
-  of this license document, but changing it is not allowed.
- .
-                             Preamble
- .
-   The GNU Affero General Public License is a free, copyleft license for
- software and other kinds of works, specifically designed to ensure
- cooperation with the community in the case of network server software.
- .
-   The licenses for most software and other practical works are designed
- to take away your freedom to share and change the works.  By contrast,
- our General Public Licenses are intended to guarantee your freedom to
- share and change all versions of a program--to make sure it remains free
- software for all its users.
- .
-   When we speak of free software, we are referring to freedom, not
- price.  Our General Public Licenses are designed to make sure that you
- have the freedom to distribute copies of free software (and charge for
- them if you wish), that you receive source code or can get it if you
- want it, that you can change the software or use pieces of it in new
- free programs, and that you know you can do these things.
- .
-   Developers that use our General Public Licenses protect your rights
- with two steps: (1) assert copyright on the software, and (2) offer
- you this License which gives you legal permission to copy, distribute
- and/or modify the software.
- .
-   A secondary benefit of defending all users' freedom is that
- improvements made in alternate versions of the program, if they
- receive widespread use, become available for other developers to
- incorporate.  Many developers of free software are heartened and
- encouraged by the resulting cooperation.  However, in the case of
- software used on network servers, this result may fail to come about.
- The GNU General Public License permits making a modified version and
- letting the public access it on a server without ever releasing its
- source code to the public.
- .
-   The GNU Affero General Public License is designed specifically to
- ensure that, in such cases, the modified source code becomes available
- to the community.  It requires the operator of a network server to
- provide the source code of the modified version running there to the
- users of that server.  Therefore, public use of a modified version, on
- a publicly accessible server, gives the public access to the source
- code of the modified version.
- .
-   An older license, called the Affero General Public License and
- published by Affero, was designed to accomplish similar goals.  This is
- a different license, not a version of the Affero GPL, but Affero has
- released a new version of the Affero GPL which permits relicensing under
- this license.
- .
-   The precise terms and conditions for copying, distribution and
- modification follow.
- .
-                        TERMS AND CONDITIONS
- .
-   0. Definitions.
- .
-   "This License" refers to version 3 of the GNU Affero General Public License.
- .
-   "Copyright" also means copyright-like laws that apply to other kinds of
- works, such as semiconductor masks.
- .
-   "The Program" refers to any copyrightable work licensed under this
- License.  Each licensee is addressed as "you".  "Licensees" and
- "recipients" may be individuals or organizations.
- .
-   To "modify" a work means to copy from or adapt all or part of the work
- in a fashion requiring copyright permission, other than the making of an
- exact copy.  The resulting work is called a "modified version" of the
- earlier work or a work "based on" the earlier work.
- .
-   A "covered work" means either the unmodified Program or a work based
- on the Program.
- .
-   To "propagate" a work means to do anything with it that, without
- permission, would make you directly or secondarily liable for
- infringement under applicable copyright law, except executing it on a
- computer or modifying a private copy.  Propagation includes copying,
- distribution (with or without modification), making available to the
- public, and in some countries other activities as well.
- .
-   To "convey" a work means any kind of propagation that enables other
- parties to make or receive copies.  Mere interaction with a user through
- a computer network, with no transfer of a copy, is not conveying.
- .
-   An interactive user interface displays "Appropriate Legal Notices"
- to the extent that it includes a convenient and prominently visible
- feature that (1) displays an appropriate copyright notice, and (2)
- tells the user that there is no warranty for the work (except to the
- extent that warranties are provided), that licensees may convey the
- work under this License, and how to view a copy of this License.  If
- the interface presents a list of user commands or options, such as a
- menu, a prominent item in the list meets this criterion.
- .
-   1. Source Code.
- .
-   The "source code" for a work means the preferred form of the work
- for making modifications to it.  "Object code" means any non-source
- form of a work.
- .
-   A "Standard Interface" means an interface that either is an official
- standard defined by a recognized standards body, or, in the case of
- interfaces specified for a particular programming language, one that
- is widely used among developers working in that language.
- .
-   The "System Libraries" of an executable work include anything, other
- than the work as a whole, that (a) is included in the normal form of
- packaging a Major Component, but which is not part of that Major
- Component, and (b) serves only to enable use of the work with that
- Major Component, or to implement a Standard Interface for which an
- implementation is available to the public in source code form.  A
- "Major Component", in this context, means a major essential component
- (kernel, window system, and so on) of the specific operating system
- (if any) on which the executable work runs, or a compiler used to
- produce the work, or an object code interpreter used to run it.
- .
-   The "Corresponding Source" for a work in object code form means all
- the source code needed to generate, install, and (for an executable
- work) run the object code and to modify the work, including scripts to
- control those activities.  However, it does not include the work's
- System Libraries, or general-purpose tools or generally available free
- programs which are used unmodified in performing those activities but
- which are not part of the work.  For example, Corresponding Source
- includes interface definition files associated with source files for
- the work, and the source code for shared libraries and dynamically
- linked subprograms that the work is specifically designed to require,
- such as by intimate data communication or control flow between those
- subprograms and other parts of the work.
- .
-   The Corresponding Source need not include anything that users
- can regenerate automatically from other parts of the Corresponding
- Source.
- .
-   The Corresponding Source for a work in source code form is that
- same work.
- .
-   2. Basic Permissions.
- .
-   All rights granted under this License are granted for the term of
- copyright on the Program, and are irrevocable provided the stated
- conditions are met.  This License explicitly affirms your unlimited
- permission to run the unmodified Program.  The output from running a
- covered work is covered by this License only if the output, given its
- content, constitutes a covered work.  This License acknowledges your
- rights of fair use or other equivalent, as provided by copyright law.
- .
-   You may make, run and propagate covered works that you do not
- convey, without conditions so long as your license otherwise remains
- in force.  You may convey covered works to others for the sole purpose
- of having them make modifications exclusively for you, or provide you
- with facilities for running those works, provided that you comply with
- the terms of this License in conveying all material for which you do
- not control copyright.  Those thus making or running the covered works
- for you must do so exclusively on your behalf, under your direction
- and control, on terms that prohibit them from making any copies of
- your copyrighted material outside their relationship with you.
- .
-   Conveying under any other circumstances is permitted solely under
- the conditions stated below.  Sublicensing is not allowed; section 10
- makes it unnecessary.
- .
-   3. Protecting Users' Legal Rights From Anti-Circumvention Law.
- .
-   No covered work shall be deemed part of an effective technological
- measure under any applicable law fulfilling obligations under article
- 11 of the WIPO copyright treaty adopted on 20 December 1996, or
- similar laws prohibiting or restricting circumvention of such
- measures.
- .
-   When you convey a covered work, you waive any legal power to forbid
- circumvention of technological measures to the extent such circumvention
- is effected by exercising rights under this License with respect to
- the covered work, and you disclaim any intention to limit operation or
- modification of the work as a means of enforcing, against the work's
- users, your or third parties' legal rights to forbid circumvention of
- technological measures.
- .
-   4. Conveying Verbatim Copies.
- .
-   You may convey verbatim copies of the Program's source code as you
- receive it, in any medium, provided that you conspicuously and
- appropriately publish on each copy an appropriate copyright notice;
- keep intact all notices stating that this License and any
- non-permissive terms added in accord with section 7 apply to the code;
- keep intact all notices of the absence of any warranty; and give all
- recipients a copy of this License along with the Program.
- .
-   You may charge any price or no price for each copy that you convey,
- and you may offer support or warranty protection for a fee.
- .
-   5. Conveying Modified Source Versions.
- .
-   You may convey a work based on the Program, or the modifications to
- produce it from the Program, in the form of source code under the
- terms of section 4, provided that you also meet all of these conditions:
- .
-     a) The work must carry prominent notices stating that you modified
-     it, and giving a relevant date.
- .
-     b) The work must carry prominent notices stating that it is
-     released under this License and any conditions added under section
-     7.  This requirement modifies the requirement in section 4 to
-     "keep intact all notices".
- .
-     c) You must license the entire work, as a whole, under this
-     License to anyone who comes into possession of a copy.  This
-     License will therefore apply, along with any applicable section 7
-     additional terms, to the whole of the work, and all its parts,
-     regardless of how they are packaged.  This License gives no
-     permission to license the work in any other way, but it does not
-     invalidate such permission if you have separately received it.
- .
-     d) If the work has interactive user interfaces, each must display
-     Appropriate Legal Notices; however, if the Program has interactive
-     interfaces that do not display Appropriate Legal Notices, your
-     work need not make them do so.
- .
-   A compilation of a covered work with other separate and independent
- works, which are not by their nature extensions of the covered work,
- and which are not combined with it such as to form a larger program,
- in or on a volume of a storage or distribution medium, is called an
- "aggregate" if the compilation and its resulting copyright are not
- used to limit the access or legal rights of the compilation's users
- beyond what the individual works permit.  Inclusion of a covered work
- in an aggregate does not cause this License to apply to the other
- parts of the aggregate.
- .
-   6. Conveying Non-Source Forms.
- .
-   You may convey a covered work in object code form under the terms
- of sections 4 and 5, provided that you also convey the
- machine-readable Corresponding Source under the terms of this License,
- in one of these ways:
- .
-     a) Convey the object code in, or embodied in, a physical product
-     (including a physical distribution medium), accompanied by the
-     Corresponding Source fixed on a durable physical medium
-     customarily used for software interchange.
- .
-     b) Convey the object code in, or embodied in, a physical product
-     (including a physical distribution medium), accompanied by a
-     written offer, valid for at least three years and valid for as
-     long as you offer spare parts or customer support for that product
-     model, to give anyone who possesses the object code either (1) a
-     copy of the Corresponding Source for all the software in the
-     product that is covered by this License, on a durable physical
-     medium customarily used for software interchange, for a price no
-     more than your reasonable cost of physically performing this
-     conveying of source, or (2) access to copy the
-     Corresponding Source from a network server at no charge.
- .
-     c) Convey individual copies of the object code with a copy of the
-     written offer to provide the Corresponding Source.  This
-     alternative is allowed only occasionally and noncommercially, and
-     only if you received the object code with such an offer, in accord
-     with subsection 6b.
- .
-     d) Convey the object code by offering access from a designated
-     place (gratis or for a charge), and offer equivalent access to the
-     Corresponding Source in the same way through the same place at no
-     further charge.  You need not require recipients to copy the
-     Corresponding Source along with the object code.  If the place to
-     copy the object code is a network server, the Corresponding Source
-     may be on a different server (operated by you or a third party)
-     that supports equivalent copying facilities, provided you maintain
-     clear directions next to the object code saying where to find the
-     Corresponding Source.  Regardless of what server hosts the
-     Corresponding Source, you remain obligated to ensure that it is
-     available for as long as needed to satisfy these requirements.
- .
-     e) Convey the object code using peer-to-peer transmission, provided
-     you inform other peers where the object code and Corresponding
-     Source of the work are being offered to the general public at no
-     charge under subsection 6d.
- .
-   A separable portion of the object code, whose source code is excluded
- from the Corresponding Source as a System Library, need not be
- included in conveying the object code work.
- .
-   A "User Product" is either (1) a "consumer product", which means any
- tangible personal property which is normally used for personal, family,
- or household purposes, or (2) anything designed or sold for incorporation
- into a dwelling.  In determining whether a product is a consumer product,
- doubtful cases shall be resolved in favor of coverage.  For a particular
- product received by a particular user, "normally used" refers to a
- typical or common use of that class of product, regardless of the status
- of the particular user or of the way in which the particular user
- actually uses, or expects or is expected to use, the product.  A product
- is a consumer product regardless of whether the product has substantial
- commercial, industrial or non-consumer uses, unless such uses represent
- the only significant mode of use of the product.
- .
-   "Installation Information" for a User Product means any methods,
- procedures, authorization keys, or other information required to install
- and execute modified versions of a covered work in that User Product from
- a modified version of its Corresponding Source.  The information must
- suffice to ensure that the continued functioning of the modified object
- code is in no case prevented or interfered with solely because
- modification has been made.
- .
-   If you convey an object code work under this section in, or with, or
- specifically for use in, a User Product, and the conveying occurs as
- part of a transaction in which the right of possession and use of the
- User Product is transferred to the recipient in perpetuity or for a
- fixed term (regardless of how the transaction is characterized), the
- Corresponding Source conveyed under this section must be accompanied
- by the Installation Information.  But this requirement does not apply
- if neither you nor any third party retains the ability to install
- modified object code on the User Product (for example, the work has
- been installed in ROM).
- .
-   The requirement to provide Installation Information does not include a
- requirement to continue to provide support service, warranty, or updates
- for a work that has been modified or installed by the recipient, or for
- the User Product in which it has been modified or installed.  Access to a
- network may be denied when the modification itself materially and
- adversely affects the operation of the network or violates the rules and
- protocols for communication across the network.
- .
-   Corresponding Source conveyed, and Installation Information provided,
- in accord with this section must be in a format that is publicly
- documented (and with an implementation available to the public in
- source code form), and must require no special password or key for
- unpacking, reading or copying.
- .
-   7. Additional Terms.
- .
-   "Additional permissions" are terms that supplement the terms of this
- License by making exceptions from one or more of its conditions.
- Additional permissions that are applicable to the entire Program shall
- be treated as though they were included in this License, to the extent
- that they are valid under applicable law.  If additional permissions
- apply only to part of the Program, that part may be used separately
- under those permissions, but the entire Program remains governed by
- this License without regard to the additional permissions.
- .
-   When you convey a copy of a covered work, you may at your option
- remove any additional permissions from that copy, or from any part of
- it.  (Additional permissions may be written to require their own
- removal in certain cases when you modify the work.)  You may place
- additional permissions on material, added by you to a covered work,
- for which you have or can give appropriate copyright permission.
- .
-   Notwithstanding any other provision of this License, for material you
- add to a covered work, you may (if authorized by the copyright holders of
- that material) supplement the terms of this License with terms:
- .
-     a) Disclaiming warranty or limiting liability differently from the
-     terms of sections 15 and 16 of this License; or
- .
-     b) Requiring preservation of specified reasonable legal notices or
-     author attributions in that material or in the Appropriate Legal
-     Notices displayed by works containing it; or
- .
-     c) Prohibiting misrepresentation of the origin of that material, or
-     requiring that modified versions of such material be marked in
-     reasonable ways as different from the original version; or
- .
-     d) Limiting the use for publicity purposes of names of licensors or
-     authors of the material; or
- .
-     e) Declining to grant rights under trademark law for use of some
-     trade names, trademarks, or service marks; or
- .
-     f) Requiring indemnification of licensors and authors of that
-     material by anyone who conveys the material (or modified versions of
-     it) with contractual assumptions of liability to the recipient, for
-     any liability that these contractual assumptions directly impose on
-     those licensors and authors.
- .
-   All other non-permissive additional terms are considered "further
- restrictions" within the meaning of section 10.  If the Program as you
- received it, or any part of it, contains a notice stating that it is
- governed by this License along with a term that is a further
- restriction, you may remove that term.  If a license document contains
- a further restriction but permits relicensing or conveying under this
- License, you may add to a covered work material governed by the terms
- of that license document, provided that the further restriction does
- not survive such relicensing or conveying.
- .
-   If you add terms to a covered work in accord with this section, you
- must place, in the relevant source files, a statement of the
- additional terms that apply to those files, or a notice indicating
- where to find the applicable terms.
- .
-   Additional terms, permissive or non-permissive, may be stated in the
- form of a separately written license, or stated as exceptions;
- the above requirements apply either way.
- .
-   8. Termination.
- .
-   You may not propagate or modify a covered work except as expressly
- provided under this License.  Any attempt otherwise to propagate or
- modify it is void, and will automatically terminate your rights under
- this License (including any patent licenses granted under the third
- paragraph of section 11).
- .
-   However, if you cease all violation of this License, then your
- license from a particular copyright holder is reinstated (a)
- provisionally, unless and until the copyright holder explicitly and
- finally terminates your license, and (b) permanently, if the copyright
- holder fails to notify you of the violation by some reasonable means
- prior to 60 days after the cessation.
- .
-   Moreover, your license from a particular copyright holder is
- reinstated permanently if the copyright holder notifies you of the
- violation by some reasonable means, this is the first time you have
- received notice of violation of this License (for any work) from that
- copyright holder, and you cure the violation prior to 30 days after
- your receipt of the notice.
- .
-   Termination of your rights under this section does not terminate the
- licenses of parties who have received copies or rights from you under
- this License.  If your rights have been terminated and not permanently
- reinstated, you do not qualify to receive new licenses for the same
- material under section 10.
- .
-   9. Acceptance Not Required for Having Copies.
- .
-   You are not required to accept this License in order to receive or
- run a copy of the Program.  Ancillary propagation of a covered work
- occurring solely as a consequence of using peer-to-peer transmission
- to receive a copy likewise does not require acceptance.  However,
- nothing other than this License grants you permission to propagate or
- modify any covered work.  These actions infringe copyright if you do
- not accept this License.  Therefore, by modifying or propagating a
- covered work, you indicate your acceptance of this License to do so.
- .
-   10. Automatic Licensing of Downstream Recipients.
- .
-   Each time you convey a covered work, the recipient automatically
- receives a license from the original licensors, to run, modify and
- propagate that work, subject to this License.  You are not responsible
- for enforcing compliance by third parties with this License.
- .
-   An "entity transaction" is a transaction transferring control of an
- organization, or substantially all assets of one, or subdividing an
- organization, or merging organizations.  If propagation of a covered
- work results from an entity transaction, each party to that
- transaction who receives a copy of the work also receives whatever
- licenses to the work the party's predecessor in interest had or could
- give under the previous paragraph, plus a right to possession of the
- Corresponding Source of the work from the predecessor in interest, if
- the predecessor has it or can get it with reasonable efforts.
- .
-   You may not impose any further restrictions on the exercise of the
- rights granted or affirmed under this License.  For example, you may
- not impose a license fee, royalty, or other charge for exercise of
- rights granted under this License, and you may not initiate litigation
- (including a cross-claim or counterclaim in a lawsuit) alleging that
- any patent claim is infringed by making, using, selling, offering for
- sale, or importing the Program or any portion of it.
- .
-   11. Patents.
- .
-   A "contributor" is a copyright holder who authorizes use under this
- License of the Program or a work on which the Program is based.  The
- work thus licensed is called the contributor's "contributor version".
- .
-   A contributor's "essential patent claims" are all patent claims
- owned or controlled by the contributor, whether already acquired or
- hereafter acquired, that would be infringed by some manner, permitted
- by this License, of making, using, or selling its contributor version,
- but do not include claims that would be infringed only as a
- consequence of further modification of the contributor version.  For
- purposes of this definition, "control" includes the right to grant
- patent sublicenses in a manner consistent with the requirements of
- this License.
- .
-   Each contributor grants you a non-exclusive, worldwide, royalty-free
- patent license under the contributor's essential patent claims, to
- make, use, sell, offer for sale, import and otherwise run, modify and
- propagate the contents of its contributor version.
- .
-   In the following three paragraphs, a "patent license" is any express
- agreement or commitment, however denominated, not to enforce a patent
- (such as an express permission to practice a patent or covenant not to
- sue for patent infringement).  To "grant" such a patent license to a
- party means to make such an agreement or commitment not to enforce a
- patent against the party.
- .
-   If you convey a covered work, knowingly relying on a patent license,
- and the Corresponding Source of the work is not available for anyone
- to copy, free of charge and under the terms of this License, through a
- publicly available network server or other readily accessible means,
- then you must either (1) cause the Corresponding Source to be so
- available, or (2) arrange to deprive yourself of the benefit of the
- patent license for this particular work, or (3) arrange, in a manner
- consistent with the requirements of this License, to extend the patent
- license to downstream recipients.  "Knowingly relying" means you have
- actual knowledge that, but for the patent license, your conveying the
- covered work in a country, or your recipient's use of the covered work
- in a country, would infringe one or more identifiable patents in that
- country that you have reason to believe are valid.
- .
-   If, pursuant to or in connection with a single transaction or
- arrangement, you convey, or propagate by procuring conveyance of, a
- covered work, and grant a patent license to some of the parties
- receiving the covered work authorizing them to use, propagate, modify
- or convey a specific copy of the covered work, then the patent license
- you grant is automatically extended to all recipients of the covered
- work and works based on it.
- .
-   A patent license is "discriminatory" if it does not include within
- the scope of its coverage, prohibits the exercise of, or is
- conditioned on the non-exercise of one or more of the rights that are
- specifically granted under this License.  You may not convey a covered
- work if you are a party to an arrangement with a third party that is
- in the business of distributing software, under which you make payment
- to the third party based on the extent of your activity of conveying
- the work, and under which the third party grants, to any of the
- parties who would receive the covered work from you, a discriminatory
- patent license (a) in connection with copies of the covered work
- conveyed by you (or copies made from those copies), or (b) primarily
- for and in connection with specific products or compilations that
- contain the covered work, unless you entered into that arrangement,
- or that patent license was granted, prior to 28 March 2007.
- .
-   Nothing in this License shall be construed as excluding or limiting
- any implied license or other defenses to infringement that may
- otherwise be available to you under applicable patent law.
- .
-   12. No Surrender of Others' Freedom.
- .
-   If conditions are imposed on you (whether by court order, agreement or
- otherwise) that contradict the conditions of this License, they do not
- excuse you from the conditions of this License.  If you cannot convey a
- covered work so as to satisfy simultaneously your obligations under this
- License and any other pertinent obligations, then as a consequence you may
- not convey it at all.  For example, if you agree to terms that obligate you
- to collect a royalty for further conveying from those to whom you convey
- the Program, the only way you could satisfy both those terms and this
- License would be to refrain entirely from conveying the Program.
- .
-   13. Remote Network Interaction; Use with the GNU General Public License.
- .
-   Notwithstanding any other provision of this License, if you modify the
- Program, your modified version must prominently offer all users
- interacting with it remotely through a computer network (if your version
- supports such interaction) an opportunity to receive the Corresponding
- Source of your version by providing access to the Corresponding Source
- from a network server at no charge, through some standard or customary
- means of facilitating copying of software.  This Corresponding Source
- shall include the Corresponding Source for any work covered by version 3
- of the GNU General Public License that is incorporated pursuant to the
- following paragraph.
- .
-   Notwithstanding any other provision of this License, you have
- permission to link or combine any covered work with a work licensed
- under version 3 of the GNU General Public License into a single
- combined work, and to convey the resulting work.  The terms of this
- License will continue to apply to the part which is the covered work,
- but the work with which it is combined will remain governed by version
- 3 of the GNU General Public License.
- .
-   14. Revised Versions of this License.
- .
-   The Free Software Foundation may publish revised and/or new versions of
- the GNU Affero General Public License from time to time.  Such new versions
- will be similar in spirit to the present version, but may differ in detail to
- address new problems or concerns.
- .
-   Each version is given a distinguishing version number.  If the
- Program specifies that a certain numbered version of the GNU Affero General
- Public License "or any later version" applies to it, you have the
- option of following the terms and conditions either of that numbered
- version or of any later version published by the Free Software
- Foundation.  If the Program does not specify a version number of the
- GNU Affero General Public License, you may choose any version ever published
- by the Free Software Foundation.
- .
-   If the Program specifies that a proxy can decide which future
- versions of the GNU Affero General Public License can be used, that proxy's
- public statement of acceptance of a version permanently authorizes you
- to choose that version for the Program.
- .
-   Later license versions may give you additional or different
- permissions.  However, no additional obligations are imposed on any
- author or copyright holder as a result of your choosing to follow a
- later version.
- .
-   15. Disclaimer of Warranty.
- .
-   THERE IS NO WARRANTY FOR THE PROGRAM, TO THE EXTENT PERMITTED BY
- APPLICABLE LAW.  EXCEPT WHEN OTHERWISE STATED IN WRITING THE COPYRIGHT
- HOLDERS AND/OR OTHER PARTIES PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY
- OF ANY KIND, EITHER EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO,
- THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- PURPOSE.  THE ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE PROGRAM
- IS WITH YOU.  SHOULD THE PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF
- ALL NECESSARY SERVICING, REPAIR OR CORRECTION.
- .
-   16. Limitation of Liability.
- .
-   IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
- WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MODIFIES AND/OR CONVEYS
- THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, INCLUDING ANY
- GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE
- USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED TO LOSS OF
- DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD
- PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER PROGRAMS),
- EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF
- SUCH DAMAGES.
- .
-   17. Interpretation of Sections 15 and 16.
- .
-   If the disclaimer of warranty and limitation of liability provided
- above cannot be given local legal effect according to their terms,
- reviewing courts shall apply local law that most closely approximates
- an absolute waiver of all civil liability in connection with the
- Program, unless a warranty or assumption of liability accompanies a
- copy of the Program in return for a fee.
- .
-                      END OF TERMS AND CONDITIONS
- .
-             How to Apply These Terms to Your New Programs
- .
-   If you develop a new program, and you want it to be of the greatest
- possible use to the public, the best way to achieve this is to make it
- free software which everyone can redistribute and change under these terms.
- .
-   To do so, attach the following notices to the program.  It is safest
- to attach them to the start of each source file to most effectively
- state the exclusion of warranty; and each file should have at least
- the "copyright" line and a pointer to where the full notice is found.
- .
-     <one line to give the program's name and a brief idea of what it does.>
-     Copyright (C) <year>  <name of author>
- .
-     This program is free software: you can redistribute it and/or modify
-     it under the terms of the GNU Affero General Public License as published by
-     the Free Software Foundation, either version 3 of the License, or
-     (at your option) any later version.
- .
-     This program is distributed in the hope that it will be useful,
-     but WITHOUT ANY WARRANTY; without even the implied warranty of
-     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-     GNU Affero General Public License for more details.
- .
-     You should have received a copy of the GNU Affero General Public License
-     along with this program.  If not, see <http://www.gnu.org/licenses/>.
- .
- Also add information on how to contact you by electronic and paper mail.
- .
-   If your software can interact with users remotely through a computer
- network, you should also make sure that it provides a way for users to
- get its source.  For example, if your program is a web application, its
- interface could display a "Source" link that leads users to an archive
- of the code.  There are many ways you could offer source, and different
- solutions will be better for different programs; see section 13 for the
- specific requirements.
- .
-   You should also get your employer (if you work as a programmer) or school,
- if any, to sign a "copyright disclaimer" for the program, if necessary.
- For more information on this, and how to apply and follow the GNU AGPL, see
- <http://www.gnu.org/licenses/>.
-
-License: Apache-2.0
- Licensed under the Apache License, Version 2.0 (the "License");
- you may not use this file except in compliance with the License.
- You may obtain a copy of the License at
- .
- http://www.apache.org/licenses/LICENSE-2.0
- .
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
- .
- On Debian systems, the complete text of the Apache version 2.0 license
- can be found in "/usr/share/common-licenses/Apache-2.0".
-
-License: BSD-3-clause
- BSD LICENSE
- .
- Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
- Copyright(c) 2012-2014 6WIND S.A.
- All rights reserved.
- .
- Redistribution and use in source and binary forms, with or without
- modification, are permitted provided that the following conditions
- are met:
- .
-   * Redistributions of source code must retain the above copyright
-     notice, this list of conditions and the following disclaimer.
-   * Redistributions in binary form must reproduce the above copyright
-     notice, this list of conditions and the following disclaimer in
-     the documentation and/or other materials provided with the
-     distribution.
-   * Neither the name of Intel Corporation nor the names of its
-     contributors may be used to endorse or promote products derived
-     from this software without specific prior written permission.
- .
- THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

dist/ubuntu/debian/scylla-server.init

@@ -1,103 +0,0 @@
-#! /bin/sh
-### BEGIN INIT INFO
-# Provides:          scylla-server
-# Required-Start:	$remote_fs $syslog
-# Required-Stop:	$remote_fs $syslog
-# Default-Start:     2 3 4 5
-# Default-Stop:      0 1 6
-# Short-Description: Scylla database server
-# Description:        Scylla is a highly scalable, eventually consistent,
-#		      distributed, partitioned row DB.
-### END INIT INFO
-
-#
-# Author: Takuya ASADA<syuu@scylladb.com>
-#
-
-# PATH should only include /usr/* if it runs after the mountnfs.sh script
-PATH=/sbin:/usr/sbin:/bin:/usr/bin
-DESC="Scylla database server"
-NAME=scylla-server
-
-SCYLLA_SERVER=scylla-server
-DAEMON=/usr/lib/scylla/scylla_run
-PIDFILE=/var/run/scylla-server.pid
-
-SCRIPTNAME=/etc/init.d/$NAME
-
-# Exit if the package is not installed
-[ -x "$DAEMON" ] || exit 0
-
-# Read configuration variable file if it is present
-[ -r /etc/default/$NAME ] && . /etc/default/$NAME
-export NETWORK_MODE TAP BRIDGE ETHDRV ETHPCIID NR_HUGEPAGES USER GROUP SCYLLA_HOME SCYLLA_CONF SCYLLA_ARGS
-
-# Define LSB log_* functions.
-. /lib/lsb/init-functions
-
-do_start()
-{
-	/usr/lib/scylla/scylla_prepare	
-	# Return
-	#   0 if daemon has been started
-	#   1 if daemon was already running
-	#   other if daemon could not be started or a failure occured
-	start-stop-daemon --start --quiet --pidfile $PIDFILE --make-pidfile --background --exec $DAEMON
-}
-
-do_stop()
-{
-	# Return
-	#   0 if daemon has been stopped
-	#   1 if daemon was already stopped
-	#   other if daemon could not be stopped or a failure occurred
-	start-stop-daemon --stop --quiet --pidfile $PIDFILE --retry 5
-	 /usr/lib/scylla/scylla_stop
-}
-
-case "$1" in
-  start)
-	if init_is_upstart; then
-		exit 1
-	fi
-	log_daemon_msg "Starting $DESC" "$SCYLLA_SERVER"
-	do_start
-	case "$?" in
-		0) log_end_msg 0 ;;
-		1) log_progress_msg "already started"
-		   log_end_msg 0 ;;
-		*) log_end_msg 1 ;;
-	esac
-
-	;;
-  stop)
-	if init_is_upstart; then
-		exit 0
-	fi
-	log_daemon_msg "Stopping $DESC" "$SCYLLA_SERVER"
-	do_stop
-	case "$?" in
-		0) log_end_msg 0 ;;
-		1) log_progress_msg "already stopped"
-		   log_end_msg 0 ;;
-		*) log_end_msg 1 ;;
-	esac
-
-	;;
-  restart|force-reload)
-	if init_is_upstart; then
-		exit 1
-	fi
-	$0 stop
-	$0 start
-	;;
-  status)
-	status_of_proc -p $PIDFILE $DAEMON $SCYLLA_SERVER && exit 0 || exit $?
-	;;
-  *)
-	echo "Usage: $SCRIPTNAME {start|stop|rotate|restart|force-reload|status}" >&2
-	exit 3
-	;;
-esac
-
-:

dist/ubuntu/debian/scylla-server.postinst

@@ -1,17 +0,0 @@
-#!/bin/sh
-
-set -e
-
-if [ "$1" = configure ]; then
-    adduser --system \
-            --quiet \
-            --home /var/lib/scylla \
-            --no-create-home \
-            --disabled-password \
-            --group scylla
-    chown -R scylla:scylla /var/lib/scylla
-fi
-
-ln -sfT /etc/scylla /var/lib/scylla/conf
-
-#DEBHELPER#

dist/ubuntu/debian/scylla-server.preinst

@@ -1,9 +0,0 @@
-#!/bin/sh
-
-# This is for existing users who already installed scylla.yaml on /var/lib/scylla/conf
-if [ -d /var/lib/scylla/conf ] && [ ! -L /var/lib/scylla/conf ]; then
-    mkdir -p /etc/scylla/
-    cp -a /var/lib/scylla/conf/* /etc/scylla/
-fi
-
-#DEBHELPER#

dist/ubuntu/debian/source/format

@@ -1 +0,0 @@
-3.0 (quilt)

dist/ubuntu/debian/source/lintian-overrides

@@ -1,2 +0,0 @@
-scylla-server source: source-is-missing
-scylla-server binary: postrm-does-not-call-updaterc.d-for-init.d-script

dist/ubuntu/debian/source/options

@@ -1,3 +0,0 @@
-extend-diff-ignore = ^.gitorderfile$
-extend-diff-ignore = ^seastar/.gitorderfile$
-extend-diff-ignore = ^build/

gms/endpoint_state.hh

@@ -85,10 +85,6 @@ public:
         return _heart_beat_state;
     }
 
-    const heart_beat_state& get_heart_beat_state() const {
-        return _heart_beat_state;
-    }
-
     void set_heart_beat_state(heart_beat_state hbs) {
         update_timestamp();
         _heart_beat_state = hbs;
@@ -104,10 +100,6 @@ public:
         return _application_state;
     }
 
-    const std::map<application_state, versioned_value>& get_application_state_map() const {
-        return _application_state;
-    }
-
     void add_application_state(application_state key, versioned_value value) {
         _application_state[key] = value;
     }

gms/gossip_digest.hh

@@ -68,19 +68,19 @@ public:
         , _max_version(version) {
     }
 
-    inet_address get_endpoint() const {
+    inet_address get_endpoint() {
         return _endpoint;
     }
 
-    int32_t get_generation() const {
+    int32_t get_generation() {
         return _generation;
     }
 
-    int32_t get_max_version() const {
+    int32_t get_max_version() {
         return _max_version;
     }
 
-    int32_t compare_to(gossip_digest d) const {
+    int32_t compare_to(gossip_digest d) {
         if (_generation != d.get_generation()) {
             return (_generation - d.get_generation());
         }

gms/gossip_digest_ack.hh

@@ -64,11 +64,11 @@ public:
         , _map(std::move(m)) {
     }
 
-    std::vector<gossip_digest> get_gossip_digest_list() const {
+    std::vector<gossip_digest> get_gossip_digest_list() {
         return _digests;
     }
 
-    std::map<inet_address, endpoint_state> get_endpoint_state_map() const {
+    std::map<inet_address, endpoint_state> get_endpoint_state_map() {
         return _map;
     }
 

gms/gossip_digest_ack2.hh

@@ -65,10 +65,6 @@ public:
         return _map;
     }
 
-    const std::map<inet_address, endpoint_state>& get_endpoint_state_map() const {
-        return _map;
-    }
-
     // The following replaces GossipDigestAck2Serializer from the Java code
     void serialize(bytes::iterator& out) const;
 

gms/gossip_digest_syn.hh

@@ -72,7 +72,7 @@ public:
         return _partioner;
     }
 
-    std::vector<gossip_digest> get_gossip_digests() const {
+    std::vector<gossip_digest> get_gossip_digests() {
         return _digests;
     }
 

gms/gossiper.cc

@@ -353,10 +353,10 @@ void gossiper::notify_failure_detector(inet_address endpoint, endpoint_state rem
     }
 }
 
-future<> gossiper::apply_state_locally(const std::map<inet_address, endpoint_state>& map) {
-    return seastar::async([this, g = this->shared_from_this(), map] () mutable {
+future<> gossiper::apply_state_locally(std::map<inet_address, endpoint_state>& map) {
+    return seastar::async([this, g = this->shared_from_this(), map = std::move(map)] () mutable {
         for (auto& entry : map) {
-            const auto& ep = entry.first;
+            auto& ep = entry.first;
             if (ep == get_broadcast_address() && !is_in_shadow_round()) {
                 continue;
             }
@@ -368,7 +368,7 @@ future<> gossiper::apply_state_locally(const std::map<inet_address, endpoint_sta
                If state does not exist just add it. If it does then add it if the remote generation is greater.
                If there is a generation tie, attempt to break it by heartbeat version.
                */
-            const endpoint_state& remote_state = entry.second;
+            endpoint_state& remote_state = entry.second;
             auto it = endpoint_state_map.find(ep);
             if (it != endpoint_state_map.end()) {
                 endpoint_state& local_ep_state_ptr = it->second;
@@ -1064,7 +1064,7 @@ void gossiper::real_mark_alive(inet_address addr, endpoint_state& local_state) {
     logger.debug("removing expire time for endpoint : {}", addr);
     logger.info("inet_address {} is now UP", addr);
 
-    _subscribers.for_each([addr, local_state] (auto& subscriber) {
+    _subscribers.for_each([addr, &local_state] (auto& subscriber) {
         subscriber->on_alive(addr, local_state);
         logger.trace("Notified {}", subscriber.get());
     });
@@ -1077,18 +1077,14 @@ void gossiper::mark_dead(inet_address addr, endpoint_state& local_state) {
     _live_endpoints.erase(addr);
     _unreachable_endpoints[addr] = now();
     logger.info("inet_address {} is now DOWN", addr);
-    _subscribers.for_each([addr, local_state] (auto& subscriber) {
+    _subscribers.for_each([addr, &local_state] (auto& subscriber) {
         subscriber->on_dead(addr, local_state);
         logger.trace("Notified {}", subscriber.get());
     });
 }
 
 // Runs inside seastar::async context
-void gossiper::handle_major_state_change(inet_address ep, const endpoint_state& eps) {
-    std::experimental::optional<endpoint_state> local_ep_state;
-    if (endpoint_state_map.count(ep) > 0) {
-        local_ep_state = endpoint_state_map.at(ep);
-    }
+void gossiper::handle_major_state_change(inet_address ep, endpoint_state eps) {
     if (!is_dead_state(eps)) {
         if (endpoint_state_map.count(ep))  {
             logger.info("Node {} has restarted, now UP", ep);
@@ -1099,23 +1095,21 @@ void gossiper::handle_major_state_change(inet_address ep, const endpoint_state&
     logger.trace("Adding endpoint state for {}", ep);
     endpoint_state_map[ep] = eps;
 
-    auto& ep_state = endpoint_state_map.at(ep);
+    auto& local_state = endpoint_state_map.at(ep);
 
-    if (local_ep_state) {
-        // the node restarted: it is up to the subscriber to take whatever action is necessary
-        _subscribers.for_each([ep, local_ep_state] (auto& subscriber) {
-            subscriber->on_restart(ep, *local_ep_state);
-        });
-    }
+    // the node restarted: it is up to the subscriber to take whatever action is necessary
+    _subscribers.for_each([ep, &local_state] (auto& subscriber) {
+        subscriber->on_restart(ep, local_state);
+    });
 
-    if (!is_dead_state(ep_state)) {
-        mark_alive(ep, ep_state);
+    if (!is_dead_state(local_state)) {
+        mark_alive(ep, local_state);
     } else {
         logger.debug("Not marking {} alive due to dead state", ep);
-        mark_dead(ep, ep_state);
+        mark_dead(ep, local_state);
     }
-    _subscribers.for_each([ep, ep_state] (auto& subscriber) {
-        subscriber->on_join(ep, ep_state);
+    _subscribers.for_each([ep, &local_state] (auto& subscriber) {
+        subscriber->on_join(ep, local_state);
     });
 }
 
@@ -1137,7 +1131,7 @@ bool gossiper::is_dead_state(const endpoint_state& eps) const {
 }
 
 // Runs inside seastar::async context
-void gossiper::apply_new_states(inet_address addr, endpoint_state& local_state, const endpoint_state& remote_state) {
+void gossiper::apply_new_states(inet_address addr, endpoint_state& local_state, endpoint_state& remote_state) {
     // don't assert here, since if the node restarts the version will go back to zero
     //int oldVersion = local_state.get_heart_beat_state().get_heart_beat_version();
 
@@ -1149,27 +1143,27 @@ void gossiper::apply_new_states(inet_address addr, endpoint_state& local_state,
 
     // we need to make two loops here, one to apply, then another to notify,
     // this way all states in an update are present and current when the notifications are received
-    for (const auto& remote_entry : remote_state.get_application_state_map()) {
-        const auto& remote_key = remote_entry.first;
-        const auto& remote_value = remote_entry.second;
+    for (auto& remote_entry : remote_state.get_application_state_map()) {
+        auto& remote_key = remote_entry.first;
+        auto& remote_value = remote_entry.second;
         assert(remote_state.get_heart_beat_state().get_generation() == local_state.get_heart_beat_state().get_generation());
         local_state.add_application_state(remote_key, remote_value);
     }
-    for (const auto& entry : remote_state.get_application_state_map()) {
+    for (auto& entry : remote_state.get_application_state_map()) {
         do_on_change_notifications(addr, entry.first, entry.second);
     }
 }
 
 // Runs inside seastar::async context
-void gossiper::do_before_change_notifications(inet_address addr, const endpoint_state& ep_state, const application_state& ap_state, const versioned_value& new_value) {
-    _subscribers.for_each([addr, ep_state, ap_state, new_value] (auto& subscriber) {
+void gossiper::do_before_change_notifications(inet_address addr, endpoint_state& ep_state, application_state& ap_state, versioned_value& new_value) {
+    _subscribers.for_each([addr, &ep_state, &ap_state, &new_value] (auto& subscriber) {
         subscriber->before_change(addr, ep_state, ap_state, new_value);
     });
 }
 
 // Runs inside seastar::async context
-void gossiper::do_on_change_notifications(inet_address addr, const application_state& state, const versioned_value& value) {
-    _subscribers.for_each([addr, state, value] (auto& subscriber) {
+void gossiper::do_on_change_notifications(inet_address addr, const application_state& state, versioned_value& value) {
+    _subscribers.for_each([addr, &state, &value] (auto& subscriber) {
         subscriber->on_change(addr, state, value);
     });
 }
@@ -1276,12 +1270,12 @@ future<> gossiper::start(int generation_nbr, std::map<application_state, version
         }
 
         //notify snitches that Gossiper is about to start
-        return locator::i_endpoint_snitch::get_local_snitch_ptr()->gossiper_starting().then([this, &local_state] {
-            logger.trace("gossip started with generation {}", local_state.get_heart_beat_state().get_generation());
-            _enabled = true;
-            _scheduled_gossip_task.arm(INTERVAL);
-            return make_ready_future<>();
-        });
+        locator::i_endpoint_snitch::get_local_snitch_ptr()->gossiper_starting();
+
+        logger.trace("gossip started with generation {}", local_state.get_heart_beat_state().get_generation());
+        _enabled = true;
+        _scheduled_gossip_task.arm(INTERVAL);
+        return make_ready_future<>();
     });
 }
 
@@ -1359,8 +1353,8 @@ void gossiper::add_saved_endpoint(inet_address ep) {
     logger.trace("Adding saved endpoint {} {}", ep, ep_state.get_heart_beat_state().get_generation());
 }
 
-future<> gossiper::add_local_application_state(application_state state, versioned_value value) {
-    return seastar::async([this, g = this->shared_from_this(), state, value = std::move(value)] () mutable {
+void gossiper::add_local_application_state(application_state state, versioned_value value) {
+    seastar::async([this, g = this->shared_from_this(), state, value = std::move(value)] () mutable {
         inet_address ep_addr = get_broadcast_address();
         assert(endpoint_state_map.count(ep_addr));
         endpoint_state& ep_state = endpoint_state_map.at(ep_addr);
@@ -1382,6 +1376,14 @@ future<> gossiper::add_local_application_state(application_state state, versione
     });
 }
 
+void gossiper::add_lccal_application_states(std::list<std::pair<application_state, versioned_value> > states) {
+    // Note: The taskLock in Origin code is removed, we can probaby use a
+    // simple data structure here
+    for (std::pair<application_state, versioned_value>& pair : states) {
+        add_local_application_state(pair.first, pair.second);
+    }
+}
+
 future<> gossiper::stop() {
     logger.debug("gossip::stop on cpu {}", engine().cpu_id());
 
@@ -1397,7 +1399,7 @@ future<> gossiper::stop() {
         for (inet_address addr : _live_endpoints) {
             shard_id id = get_shard_id(addr);
             logger.trace("Sending a GossipShutdown to {}", id);
-            ms().send_gossip_shutdown(id, get_broadcast_address()).then_wrapped([id] (auto&&f) {
+            ms().send_gossip_shutdown(id, addr).then_wrapped([id] (auto&&f) {
                 try {
                     f.get();
                     logger.trace("Got GossipShutdown Reply");

gms/gossiper.hh

@@ -404,22 +404,22 @@ private:
      * @param ep      endpoint
      * @param ep_state EndpointState for the endpoint
      */
-    void handle_major_state_change(inet_address ep, const endpoint_state& eps);
+    void handle_major_state_change(inet_address ep, endpoint_state eps);
 
 public:
     bool is_alive(inet_address ep);
     bool is_dead_state(const endpoint_state& eps) const;
 
-    future<> apply_state_locally(const std::map<inet_address, endpoint_state>& map);
+    future<> apply_state_locally(std::map<inet_address, endpoint_state>& map);
 
 private:
-    void apply_new_states(inet_address addr, endpoint_state& local_state, const endpoint_state& remote_state);
+    void apply_new_states(inet_address addr, endpoint_state& local_state, endpoint_state& remote_state);
 
     // notify that a local application state is going to change (doesn't get triggered for remote changes)
-    void do_before_change_notifications(inet_address addr, const endpoint_state& ep_state, const application_state& ap_state, const versioned_value& new_value);
+    void do_before_change_notifications(inet_address addr, endpoint_state& ep_state, application_state& ap_state, versioned_value& new_value);
 
     // notify that an application state has changed
-    void do_on_change_notifications(inet_address addr, const application_state& state, const versioned_value& value);
+    void do_on_change_notifications(inet_address addr, const application_state& state, versioned_value& value);
     /* Request all the state for the endpoint in the g_digest */
 
     void request_all(gossip_digest& g_digest, std::vector<gossip_digest>& delta_gossip_digest_list, int remote_generation);
@@ -463,7 +463,9 @@ public:
      */
     void add_saved_endpoint(inet_address ep);
 
-    future<> add_local_application_state(application_state state, versioned_value value);
+    void add_local_application_state(application_state state, versioned_value value);
+
+    void add_lccal_application_states(std::list<std::pair<application_state, versioned_value>> states);
 
     future<> stop();
 

gms/heart_beat_state.hh

@@ -66,7 +66,7 @@ public:
         , _version(ver) {
     }
 
-    int32_t get_generation() const {
+    int32_t get_generation() {
         return _generation;
     }
 
@@ -74,7 +74,7 @@ public:
         _version = version_generator::get_next_version();
     }
 
-    int32_t get_heart_beat_version() const {
+    int32_t get_heart_beat_version() {
         return _version;
     }
 

init.cc

@@ -25,8 +25,6 @@
 #include "gms/gossiper.hh"
 #include "service/storage_service.hh"
 #include "service/pending_range_calculator_service.hh"
-#include "to_string.hh"
-#include "gms/inet_address.hh"
 
 //
 // NOTE: there functions are (temporarily)
@@ -45,10 +43,10 @@ future<> init_storage_service(distributed<database>& db) {
     });
 }
 
-future<> init_ms_fd_gossiper(sstring listen_address, uint16_t port, db::seed_provider_type seed_provider, sstring cluster_name) {
+future<> init_ms_fd_gossiper(sstring listen_address, db::seed_provider_type seed_provider, sstring cluster_name) {
     const gms::inet_address listen(listen_address);
     // Init messaging_service
-    return net::get_messaging_service().start(listen, std::move(port)).then([]{
+    return net::get_messaging_service().start(listen).then([]{
         // #293 - do not stop anything
         //engine().at_exit([] { return net::get_messaging_service().stop(); });
     }).then([] {
@@ -72,12 +70,6 @@ future<> init_ms_fd_gossiper(sstring listen_address, uint16_t port, db::seed_pro
         if (seeds.empty()) {
             seeds.emplace(gms::inet_address("127.0.0.1"));
         }
-        auto broadcast_address = utils::fb_utilities::get_broadcast_address();
-        if (broadcast_address != listen_address && seeds.count(listen_address)) {
-            print("Use broadcast_address instead of listen_address for seeds list: seeds=%s, listen_address=%s, broadcast_address=%s\n",
-                  to_string(seeds), listen_address, broadcast_address);
-            throw std::runtime_error("Use broadcast_address for seeds list");
-        }
         return gms::get_gossiper().start().then([seeds, cluster_name] {
             auto& gossiper = gms::get_local_gossiper();
             gossiper.set_seeds(seeds);

init.hh

@@ -27,4 +27,4 @@
 #include "database.hh"
 
 future<> init_storage_service(distributed<database>& db);
-future<> init_ms_fd_gossiper(sstring listen_address, uint16_t storage_port, db::seed_provider_type seed_provider, sstring cluster_name = "Test Cluster");
+future<> init_ms_fd_gossiper(sstring listen_address, db::seed_provider_type seed_provider, sstring cluster_name = "Test Cluster");

keys.hh

@@ -152,7 +152,7 @@ public:
         return TopLevel::from_bytes(get_compound_type(s)->serialize_optionals(v));
     }
 
-    static TopLevel from_deeply_exploded(const schema& s, const std::vector<data_value>& v) {
+    static TopLevel from_deeply_exploded(const schema& s, const std::vector<boost::any>& v) {
         return TopLevel::from_bytes(get_compound_type(s)->serialize_value_deep(v));
     }
 

kvm/README.md

@@ -0,0 +1,55 @@
+# seastar-in-kvm
+Create a VM for Seastar development environment
+
+# Why we need this
+SeaStar scores muximum performance with DPDK, but it cannot live with existing NIC driver/Linux kernel network stack.
+Also it directly accesses NIC device, it's bit hard to try it on remote node.
+
+seastar-in-kvm offers Fedora VM with SeaStar + DPDK without setup, it's easiest way to begin SeaStar application development.
+
+### Prerequire
+
+On Fedora 21:
+```
+yum install @virtualization
+systemctl enable libvirtd
+systemctl start libvirtd
+yum install libguestfs-tools-c virt-install
+```
+
+### How to build & run
+```
+./build.sh
+./register.sh
+virsh start seastar-dev && virsh console seastar-dev
+(Try login as 'seastar' after firstboot.sh finished, Fedora will ask new password for the user)
+```
+
+### Usage of the VM
+
+Wait until finish running setup script on first startup.
+Then login as 'seastar', login prompt will ask for entering new password.
+
+After login to seastar, initialize DPDK module by following instruction:
+```
+sudo su - # entering root user
+resize    # extend console to actual terminal window size
+export TERM=xterm-256color # set terminal type
+cd ~/dpdk
+./tools/setup.sh
+
+# input numbers by following order:
+(type 9 to re-compile DPDK)
+(type 12 to insert IGB UIO module)
+(type 15, then input "64" to setup hugepage mappings)
+(type 18, then input PCI device id something like "0000:xx:yy.z",
+which is shown at 'Network devices using DPDK-compatible driver')
+(type 30 to exit)
+
+cd ~/seastar
+# httpd example
+env LD_LIBRARY_PATH=~/dpdk/x86_64-native-linuxapp-gcc/lib/ \
+./build/release/apps/httpd/httpd --network-stack native --dpdk-pmd --csum-offload off
+```
+
+

kvm/build.sh

@@ -0,0 +1,6 @@
+#!/bin/sh
+
+rm -rf /tmp/seastar
+cp -a ../ /tmp/seastar
+virt-builder fedora-21 -o seastar-dev.qcow2 --format qcow2 --size 20G --hostname seastar-dev --install "@core" --update --selinux-relabel --copy-in /tmp/seastar:/root/ --firstboot scripts/bootstrap.sh
+rm -rf /tmp/seastar

kvm/register.sh

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+virt-install --import --noreboot --name seastar-dev --vcpus 4 --ram 4096 --disk path=`realpath seastar-dev.qcow2`,format=qcow2,bus=virtio --accelerate --network=network:default,model=virtio --serial pty --cpu host --rng=/dev/random

kvm/scripts/bootstrap.sh

@@ -0,0 +1,19 @@
+#!/bin/sh -e
+nmcli c modify eth0 ipv4.ignore-auto-dns "yes"
+systemctl restart network
+echo nameserver 8.8.8.8 > /etc/resolv.conf
+useradd -m -p "" -g wheel seastar
+chage -d 0 seastar
+yum install -y gcc gcc-c++ libaio-devel ninja-build ragel hwloc-devel numactl-devel libpciaccess-devel cryptopp-devel xen-devel boost-devel kernel-devel libxml2-devel zlib-devel libasan libubsan git wget python3 tar pciutils xterm
+cd /root
+wget http://dpdk.org/browse/dpdk/snapshot/dpdk-2.0.0.tar.gz
+tar -xpf dpdk-2.0.0.tar.gz
+mv dpdk-2.0.0 dpdk
+cd dpdk
+cat config/common_linuxapp | sed -e "s/CONFIG_RTE_MBUF_REFCNT_ATOMIC=y/CONFIG_RTE_MBUF_REFCNT_ATOMIC=n/g" | sed -e "s/CONFIG_RTE_BUILD_SHARED_LIB=n/CONFIG_RTE_BUILD_SHARED_LIB=y/g" > /tmp/common_linuxapp
+mv /tmp/common_linuxapp config
+make T=x86_64-native-linuxapp-gcc install
+cd -
+cd seastar
+./configure.py --dpdk-target ~/dpdk/x86_64-native-linuxapp-gcc --disable-xen
+ninja-build -j2

locator/ec2_multi_region_snitch.cc

@@ -96,7 +96,7 @@ void ec2_multi_region_snitch::set_local_private_addr(const sstring& addr_str) {
     _local_private_address = addr_str;
 }
 
-future<> ec2_multi_region_snitch::gossiper_starting() {
+void ec2_multi_region_snitch::gossiper_starting() {
     //
     // Note: currently gossiper "main" instance always runs on CPU0 therefore
     // this function will be executed on CPU0 only.
@@ -107,14 +107,13 @@ future<> ec2_multi_region_snitch::gossiper_starting() {
     auto& g = get_local_gossiper();
     auto& ss = service::get_local_storage_service();
 
-    return g.add_local_application_state(application_state::INTERNAL_IP,
-        ss.value_factory.internal_ip(_local_private_address)).then([this] {
-        if (!_gossip_started) {
-            gms::get_local_gossiper().register_(make_shared<reconnectable_snitch_helper>(_my_dc));
-            _gossip_started = true;
-        }
-    });
+    g.add_local_application_state(application_state::INTERNAL_IP,
+                                  ss.value_factory.internal_ip(_local_private_address));
 
+    if (!_helper_added) {
+        gms::get_local_gossiper().register_(make_shared<reconnectable_snitch_helper>(_my_dc));
+        _helper_added = true;
+    }
 }
 
 using registry_2_params = class_registrator<i_endpoint_snitch, ec2_multi_region_snitch, const sstring&, unsigned>;

locator/ec2_multi_region_snitch.hh

@@ -44,12 +44,13 @@ namespace locator {
 class ec2_multi_region_snitch : public ec2_snitch {
 public:
     ec2_multi_region_snitch(const sstring& fname = "", unsigned io_cpu_id = 0);
-    virtual future<> gossiper_starting() override;
+    virtual void gossiper_starting() override;
     virtual future<> start() override;
     virtual void set_local_private_addr(const sstring& addr_str) override;
 private:
     static constexpr const char* PUBLIC_IP_QUERY_REQ  = "/latest/meta-data/public-ipv4";
     static constexpr const char* PRIVATE_IP_QUERY_REQ = "/latest/meta-data/local-ipv4";
     sstring _local_private_address;
+    bool _helper_added = false;
 };
 } // namespace locator

locator/gossiping_property_file_snitch.cc

@@ -126,7 +126,7 @@ void gossiping_property_file_snitch::periodic_reader_callback() {
     });
 }
 
-future<> gossiping_property_file_snitch::gossiper_starting() {
+void gossiping_property_file_snitch::gossiper_starting() {
     using namespace gms;
     using namespace service;
     //
@@ -141,11 +141,11 @@ future<> gossiping_property_file_snitch::gossiper_starting() {
 
     ostrm<<local_internal_addr<<std::flush;
 
-    return g.add_local_application_state(application_state::INTERNAL_IP,
-        ss.value_factory.internal_ip(ostrm.str())).then([this] {
-        _gossip_started = true;
-        reload_gossiper_state();
-    });
+    g.add_local_application_state(application_state::INTERNAL_IP,
+                                  ss.value_factory.internal_ip(ostrm.str()));
+
+    _gossip_started = true;
+    reload_gossiper_state();
 }
 
 future<> gossiping_property_file_snitch::read_property_file() {
@@ -214,14 +214,12 @@ future<> gossiping_property_file_snitch::reload_configuration() {
             if (engine().cpu_id() != _file_reader_cpu_id) {
                 local_s->set_my_dc(_my_dc);
                 local_s->set_my_rack(_my_rack);
-                local_s->set_prefer_local(_prefer_local);
             }
         }).then([this] {
             return seastar::async([this] {
                 // reload Gossiper state (executed on CPU0 only)
-                smp::submit_to(0, [] {
-                    auto& local_snitch_ptr = get_local_snitch_ptr();
-                    local_snitch_ptr->reload_gossiper_state();
+                smp::submit_to(0, [this] {
+                    this->reload_gossiper_state();
                 }).get();
 
                 // update Storage Service on each shard
@@ -241,13 +239,10 @@ future<> gossiping_property_file_snitch::reload_configuration() {
 
 
                 // spread the word...
-                smp::submit_to(0, [] {
-                    auto& local_snitch_ptr = get_local_snitch_ptr();
-                    if (local_snitch_ptr->local_gossiper_started() && service::get_storage_service().local_is_initialized()) {
-                        return service::get_local_storage_service().gossip_snitch_info();
+                smp::submit_to(0, [this] {
+                    if (this->_gossip_started && service::get_storage_service().local_is_initialized()) {
+                        service::get_local_storage_service().gossip_snitch_info();
                     }
-
-                    return make_ready_future<>();
                 }).get();
             });
         });

locator/gossiping_property_file_snitch.hh

@@ -66,7 +66,7 @@ public:
         return std::chrono::seconds(60);
     }
 
-    virtual future<> gossiper_starting() override;
+    virtual void gossiper_starting() override;
     virtual future<> stop() override;
     virtual future<> start() override;
     virtual future<> pause_io() override;
@@ -79,27 +79,6 @@ public:
         const sstring& fname = "",
         unsigned io_cpuid = 0);
 
-    /**
-     * This function register a Gossiper subscriber to reconnect according to
-     * the new "prefer_local" value, namely use either an internal or extenal IP
-     * address.
-     *
-     * @note Currently in order to be backward compatible we are mimicking the C*
-     *       behavior, which is a bit strange: while allowing the change of
-     *       prefer_local value during the same run it won't actually trigger
-     *       disconnect from all remote nodes as would be logical (in order to
-     *       connect using a new configuration). On the contrary, if the new
-     *       prefer_local value is TRUE, it will trigger the reconnect only when
-     *       there is a corresponding gossip event (e.g. on_change()) from the
-     *       corresponding node has been accepted. If the new value is FALSE
-     *       then it won't trigger disconnect at all! And in any case a remote
-     *       node will be reconnected using the PREFERED_IP value stored in the
-     *       system_table.peer.
-     *
-     * This is currently relevant to EC2/GCE(?) only.
-     */
-    virtual void reload_gossiper_state() override;
-
 private:
     void periodic_reader_callback();
 
@@ -124,6 +103,15 @@ private:
      */
     future<> read_property_file();
 
+    /**
+     * TODO: this function is expected to trigger a Gossiper to reconnect
+     * according to the new "prefer_local" value, namely use either an internal
+     * or extenal IP address.
+     *
+     * This is currently relevant to EC2/GCE(?) only.
+     */
+    void reload_gossiper_state();
+
     /**
      * Indicate that the snitch has stopped its I/O.
      */
@@ -136,6 +124,8 @@ private:
     timer<> _file_reader;
     std::experimental::optional<timespec> _last_file_mod;
     std::istringstream _istrm;
+    bool _gossip_started = false;
+    bool _prefer_local = false;
     bool _file_reader_runs = false;
     unsigned _file_reader_cpu_id;
     shared_ptr<reconnectable_snitch_helper> _reconnectable_helper;