Michał Chojnowski 4e35befcf2 treewide: get rid of incorrect reinterpret casts ...

In some places we use the `*reinterpret_cast<const net::packed<T>*>(&x)`
pattern to reinterpret memory. This is a violation of C++'s aliasing rules,
which invokes undefined behaviour.

The blessed way to correctly reinterpret memory is to copy it into a new
object. Let's do that.

Note: the reinterpret_cast way has no performance advantage. Compilers
recognize the memory copy pattern and optimize it away.

2021-03-17 17:00:38 +01:00

3.7 KiB

Raw Blame History

View Raw