mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-02 06:05:53 +00:00
in in {fmt} before v10, it provides the specialization of `fmt::formatter<..>`
for `std::string_view` as well as the specialization of `fmt::formatter<..>`
for `fmt::string_view` which is an implementation builtin in {fmt} for
compatibility of pre-C++17. and this type is used even if the code is
compiled with C++ stadandard greater or equal to C++17. also, before v10,
the `fmt::formatter<std::string_view>::format()` is defined so it accepts
`std::string_view`. after v10, `fmt::formatter<std::string_view>` still
exists, but it is now defined using `format_as()` machinery, so it's
`format()` method does not actually accept `std::string_view`, it
accepts `fmt::string_view`, as the former can be converted to
`fmt::string_view`.
this is why we can inherit from `fmt::formatter<std::string_view>` and
use `formatter<std::string_view>::format(foo, ctx);` to implement the
`format()` method with {fmt} v9, but we cannot do this with {fmt} v10,
and we would have following compilation failure:
```
FAILED: service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o
/home/kefu/.local/bin/clang++ -DFMT_DEPRECATED_OSTREAM -DFMT_SHARED -DSCYLLA_BUILD_MODE=release -DSEASTAR_API_LEVEL=7 -DSEASTAR_LOGGER_COMPILE_TIME_FMT -DSEASTAR_LOGGER_TYPE_STDOUT -DSEASTAR_SCHEDULING_GROUPS_COUNT=16 -DSEASTAR_SSTRING -DXXH_PRIVATE_API -DCMAKE_INTDIR=\"RelWithDebInfo\" -I/home/kefu/dev/scylladb -I/home/kefu/dev/scylladb/build/gen -I/home/kefu/dev/scylladb/seastar/include -I/home/kefu/dev/scylladb/build/seastar/gen/include -I/home/kefu/dev/scylladb/build/seastar/gen/src -ffunction-sections -fdata-sections -O3 -g -gz -std=gnu++20 -fvisibility=hidden -Wall -Werror -Wextra -Wno-error=deprecated-declarations -Wimplicit-fallthrough -Wno-c++11-narrowing -Wno-deprecated-copy -Wno-mismatched-tags -Wno-missing-field-initializers -Wno-overloaded-virtual -Wno-unsupported-friend -Wno-enum-constexpr-conversion -Wno-unused-parameter -ffile-prefix-map=/home/kefu/dev/scylladb=. -march=westmere -mllvm -inline-threshold=2500 -fno-slp-vectorize -U_FORTIFY_SOURCE -Werror=unused-result -MD -MT service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -MF service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o.d -o service/CMakeFiles/service.dir/RelWithDebInfo/topology_state_machine.cc.o -c /home/kefu/dev/scylladb/service/topology_state_machine.cc
/home/kefu/dev/scylladb/service/topology_state_machine.cc:254:41: error: no matching member function for call to 'format'
254 | return formatter<std::string_view>::format(it->second, ctx);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/fmt/core.h:2759:22: note: candidate function template not viable: no known conversion from 'seastar::basic_sstring<char, unsigned int, 15>' to 'const fmt::basic_string_view<char>' for 1st argument
2759 | FMT_CONSTEXPR auto format(const T& val, FormatContext& ctx) const
| ^ ~~~~~~~~~~~~
```
because the inherited `format()` method actually comes from
`fmt::formatter<fmt::string_view>`. to reduce the confusion, in this
change, we just inherit from `fmt::format<string_view>`, where
`string_view` is actually `fmt::string_view`. this follows
the document at
https://fmt.dev/latest/api.html#formatting-user-defined-types,
and since there is less indirection under the hood -- we do not
use the specialization created by `FMT_FORMAT_AS` which inherit
from `formatter<fmt::string_view>`, hopefully this can improve
the compilation speed a little bit. also, this change addresses
the build failure with {fmt} v10.
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Closes scylladb/scylladb#18299
324 lines
9.7 KiB
C++
324 lines
9.7 KiB
C++
/*
|
|
* Copyright (C) 2016-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <string_view>
|
|
#include <optional>
|
|
#include <stdexcept>
|
|
#include <tuple>
|
|
#include <vector>
|
|
#include <unordered_set>
|
|
|
|
#include <fmt/core.h>
|
|
#include <boost/range/adaptor/transformed.hpp>
|
|
#include <seastar/core/print.hh>
|
|
#include <seastar/core/sstring.hh>
|
|
|
|
#include "auth/permission.hh"
|
|
#include "seastarx.hh"
|
|
#include "utils/hash.hh"
|
|
#include "utils/small_vector.hh"
|
|
#include "cql3/cql3_type.hh"
|
|
|
|
namespace auth {
|
|
|
|
class invalid_resource_name : public std::invalid_argument {
|
|
public:
|
|
explicit invalid_resource_name(std::string_view name)
|
|
: std::invalid_argument(format("The resource name '{}' is invalid.", name)) {
|
|
}
|
|
};
|
|
|
|
enum class resource_kind {
|
|
data, role, service_level, functions
|
|
};
|
|
|
|
///
|
|
/// Type tag for constructing data resources.
|
|
///
|
|
struct data_resource_t final {};
|
|
|
|
///
|
|
/// Type tag for constructing role resources.
|
|
///
|
|
struct role_resource_t final {};
|
|
|
|
///
|
|
/// Type tag for constructing service_level resources.
|
|
///
|
|
struct service_level_resource_t final {};
|
|
|
|
///
|
|
/// Type tag for constructing function resources.
|
|
///
|
|
struct functions_resource_t final {};
|
|
|
|
///
|
|
/// Resources are entities that users can be granted permissions on.
|
|
///
|
|
/// There are data (keyspaces and tables), role and function resources. There may be other kinds of resources in the future.
|
|
///
|
|
/// When they are stored as system metadata, resources have the form `root/part_0/part_1/.../part_n`. Each kind of
|
|
/// resource has a specific root prefix, followed by a maximum of `n` parts (where `n` is distinct for each kind of
|
|
/// resource as well). In this code, this form is called the "name".
|
|
///
|
|
/// Since all resources have this same structure, all the different kinds are stored in instances of the same class:
|
|
/// \ref resource. When we wish to query a resource for kind-specific data (like the table of a "data" resource), we
|
|
/// create a kind-specific "view" of the resource.
|
|
///
|
|
class resource final {
|
|
resource_kind _kind;
|
|
|
|
utils::small_vector<sstring, 3> _parts;
|
|
|
|
public:
|
|
///
|
|
/// A root resource of a particular kind.
|
|
///
|
|
explicit resource(resource_kind);
|
|
resource(data_resource_t, std::string_view keyspace);
|
|
resource(data_resource_t, std::string_view keyspace, std::string_view table);
|
|
resource(role_resource_t, std::string_view role);
|
|
resource(service_level_resource_t);
|
|
explicit resource(functions_resource_t);
|
|
resource(functions_resource_t, std::string_view keyspace);
|
|
resource(functions_resource_t, std::string_view keyspace, std::string_view function_signature);
|
|
resource(functions_resource_t, std::string_view keyspace, std::string_view function_name,
|
|
std::vector<::shared_ptr<cql3::cql3_type::raw>> function_args);
|
|
|
|
resource_kind kind() const noexcept {
|
|
return _kind;
|
|
}
|
|
|
|
///
|
|
/// A machine-friendly identifier unique to each resource.
|
|
///
|
|
sstring name() const;
|
|
|
|
std::optional<resource> parent() const;
|
|
|
|
permission_set applicable_permissions() const;
|
|
|
|
private:
|
|
resource(resource_kind, utils::small_vector<sstring, 3> parts);
|
|
|
|
friend class std::hash<resource>;
|
|
friend class data_resource_view;
|
|
friend class role_resource_view;
|
|
friend class service_level_resource_view;
|
|
friend class functions_resource_view;
|
|
|
|
friend bool operator<(const resource&, const resource&);
|
|
friend bool operator==(const resource&, const resource&) = default;
|
|
friend resource parse_resource(std::string_view);
|
|
};
|
|
|
|
bool operator<(const resource&, const resource&);
|
|
|
|
class resource_kind_mismatch : public std::invalid_argument {
|
|
public:
|
|
explicit resource_kind_mismatch(resource_kind expected, resource_kind actual)
|
|
: std::invalid_argument(
|
|
format("This resource has kind '{}', but was expected to have kind '{}'.", actual, expected)) {
|
|
}
|
|
};
|
|
|
|
/// A "data" view of \ref resource.
|
|
///
|
|
/// If neither `keyspace` nor `table` is present, this is the root resource.
|
|
class data_resource_view final {
|
|
const resource& _resource;
|
|
|
|
public:
|
|
///
|
|
/// \throws `resource_kind_mismatch` if the argument is not a `data` resource.
|
|
///
|
|
explicit data_resource_view(const resource& r);
|
|
|
|
std::optional<std::string_view> keyspace() const;
|
|
|
|
std::optional<std::string_view> table() const;
|
|
};
|
|
|
|
///
|
|
/// A "role" view of \ref resource.
|
|
///
|
|
/// If `role` is not present, this is the root resource.
|
|
///
|
|
class role_resource_view final {
|
|
const resource& _resource;
|
|
|
|
public:
|
|
///
|
|
/// \throws \ref resource_kind_mismatch if the argument is not a "role" resource.
|
|
///
|
|
explicit role_resource_view(const resource&);
|
|
|
|
std::optional<std::string_view> role() const;
|
|
};
|
|
|
|
///
|
|
/// A "service_level" view of \ref resource.
|
|
///
|
|
class service_level_resource_view final {
|
|
public:
|
|
///
|
|
/// \throws \ref resource_kind_mismatch if the argument is not a "service_level" resource.
|
|
///
|
|
explicit service_level_resource_view(const resource&);
|
|
|
|
};
|
|
|
|
///
|
|
/// A "function" view of \ref resource.
|
|
///
|
|
class functions_resource_view final {
|
|
const resource& _resource;
|
|
public:
|
|
///
|
|
/// \throws \ref resource_kind_mismatch if the argument is not a "function" resource.
|
|
///
|
|
explicit functions_resource_view(const resource&);
|
|
|
|
std::optional<std::string_view> keyspace() const;
|
|
std::optional<std::string_view> function_signature() const;
|
|
std::optional<std::string_view> function_name() const;
|
|
std::optional<std::vector<std::string_view>> function_args() const;
|
|
};
|
|
|
|
///
|
|
/// Parse a resource from its name.
|
|
///
|
|
/// \throws \ref invalid_resource_name when the name is malformed.
|
|
///
|
|
resource parse_resource(std::string_view name);
|
|
|
|
const resource& root_data_resource();
|
|
|
|
inline resource make_data_resource(std::string_view keyspace) {
|
|
return resource(data_resource_t{}, keyspace);
|
|
}
|
|
inline resource make_data_resource(std::string_view keyspace, std::string_view table) {
|
|
return resource(data_resource_t{}, keyspace, table);
|
|
}
|
|
|
|
const resource& root_role_resource();
|
|
|
|
inline resource make_role_resource(std::string_view role) {
|
|
return resource(role_resource_t{}, role);
|
|
}
|
|
|
|
const resource& root_service_level_resource();
|
|
|
|
inline resource make_service_level_resource() {
|
|
return resource(service_level_resource_t{});
|
|
}
|
|
|
|
const resource& root_function_resource();
|
|
|
|
inline resource make_functions_resource() {
|
|
return resource(functions_resource_t{});
|
|
}
|
|
|
|
inline resource make_functions_resource(std::string_view keyspace) {
|
|
return resource(functions_resource_t{}, keyspace);
|
|
}
|
|
|
|
inline resource make_functions_resource(std::string_view keyspace, std::string_view function_signature) {
|
|
return resource(functions_resource_t{}, keyspace, function_signature);
|
|
}
|
|
|
|
inline resource make_functions_resource(std::string_view keyspace, std::string_view function_name, std::vector<::shared_ptr<cql3::cql3_type::raw>> function_signature) {
|
|
return resource(functions_resource_t{}, keyspace, function_name, function_signature);
|
|
}
|
|
|
|
sstring encode_signature(std::string_view name, std::vector<data_type> args);
|
|
|
|
std::pair<sstring, std::vector<data_type>> decode_signature(std::string_view encoded_signature);
|
|
|
|
}
|
|
|
|
template <>
|
|
struct fmt::formatter<auth::resource_kind> : fmt::formatter<string_view> {
|
|
template <typename FormatContext>
|
|
auto format(const auth::resource_kind kind, FormatContext& ctx) const {
|
|
using enum auth::resource_kind;
|
|
switch (kind) {
|
|
case data:
|
|
return formatter<string_view>::format("data", ctx);
|
|
case role:
|
|
return formatter<string_view>::format("role", ctx);
|
|
case service_level:
|
|
return formatter<string_view>::format("service_level", ctx);
|
|
case functions:
|
|
return formatter<string_view>::format("functions", ctx);
|
|
}
|
|
std::abort();
|
|
}
|
|
};
|
|
|
|
namespace std {
|
|
|
|
template <>
|
|
struct hash<auth::resource> {
|
|
static size_t hash_data(const auth::data_resource_view& dv) {
|
|
return utils::tuple_hash()(std::make_tuple(auth::resource_kind::data, dv.keyspace(), dv.table()));
|
|
}
|
|
|
|
static size_t hash_role(const auth::role_resource_view& rv) {
|
|
return utils::tuple_hash()(std::make_tuple(auth::resource_kind::role, rv.role()));
|
|
}
|
|
|
|
static size_t hash_service_level(const auth::service_level_resource_view& rv) {
|
|
return utils::tuple_hash()(std::make_tuple(auth::resource_kind::service_level));
|
|
}
|
|
|
|
static size_t hash_function(const auth::functions_resource_view& fv) {
|
|
return utils::tuple_hash()(std::make_tuple(auth::resource_kind::functions, fv.keyspace(), fv.function_signature()));
|
|
}
|
|
|
|
size_t operator()(const auth::resource& r) const {
|
|
std::size_t value;
|
|
|
|
switch (r._kind) {
|
|
case auth::resource_kind::data: value = hash_data(auth::data_resource_view(r)); break;
|
|
case auth::resource_kind::role: value = hash_role(auth::role_resource_view(r)); break;
|
|
case auth::resource_kind::service_level: value = hash_service_level(auth::service_level_resource_view(r)); break;
|
|
case auth::resource_kind::functions: value = hash_function(auth::functions_resource_view(r)); break;
|
|
}
|
|
|
|
return value;
|
|
}
|
|
};
|
|
|
|
}
|
|
|
|
namespace auth {
|
|
|
|
using resource_set = std::unordered_set<resource>;
|
|
|
|
//
|
|
// A resource and all of its parents.
|
|
//
|
|
resource_set expand_resource_family(const resource&);
|
|
|
|
}
|
|
|
|
template <> struct fmt::formatter<auth::data_resource_view> {
|
|
constexpr auto parse(format_parse_context& ctx) { return ctx.begin(); }
|
|
auto format(const auth::data_resource_view&, fmt::format_context& ctx) const -> decltype(ctx.out());
|
|
};
|
|
|
|
template <> struct fmt::formatter<auth::resource> {
|
|
constexpr auto parse(format_parse_context& ctx) { return ctx.begin(); }
|
|
auto format(const auth::resource&, fmt::format_context& ctx) const -> decltype(ctx.out());
|
|
};
|