7a05cc3a06
in c642ca9e73, a reference to the
a parameter `config` passed to the `thrift_server` 's constructor is
passed down to `create_handler_factory()`, which keeps it so it can
create connection handler on demand. but unfortunately,
- the `config` parameter is a temporary variable
- the `config` parameter is moved away in the constructor after
`create_handler_factory()` is called
hence we have a dangling reference when the factory created by
`create_handler_factory()` tries to deference the reference when
handling a new incoming connection.
in this change,
- the definitions of `_config` and `_handler_factory` member
variables are transposed, so that the former is initialized
first.
- `_handler_factory` now keeps a reference to `_config`'s member
variable, so that the weak reference it holds is always valid.
Fixes #13455
Branches: none
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Closes #13456
141 lines
4.1 KiB
C++
141 lines
4.1 KiB
C++
/*
|
|
* Copyright (C) 2014-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#ifndef APPS_SEASTAR_THRIFT_SERVER_HH_
|
|
#define APPS_SEASTAR_THRIFT_SERVER_HH_
|
|
|
|
#include <seastar/core/seastar.hh>
|
|
#include <seastar/core/distributed.hh>
|
|
#include "cql3/query_processor.hh"
|
|
#include "timeout_config.hh"
|
|
#include "service/memory_limiter.hh"
|
|
#include <seastar/core/gate.hh>
|
|
#include <memory>
|
|
#include <cstdint>
|
|
#include <boost/intrusive/list.hpp>
|
|
#include "utils/updateable_value.hh"
|
|
#include "service_permit.hh"
|
|
|
|
class thrift_server;
|
|
class thrift_stats;
|
|
|
|
#ifdef THRIFT_USES_BOOST
|
|
namespace thrift_std = boost;
|
|
#else
|
|
namespace thrift_std = std;
|
|
#endif
|
|
|
|
namespace cassandra {
|
|
|
|
static const sstring thrift_version = "20.1.0";
|
|
|
|
class CassandraCobSvIfFactory;
|
|
|
|
}
|
|
|
|
namespace apache { namespace thrift { namespace protocol {
|
|
|
|
class TProtocolFactory;
|
|
class TProtocol;
|
|
|
|
}}}
|
|
|
|
namespace apache { namespace thrift { namespace async {
|
|
|
|
class TAsyncProcessor;
|
|
class TAsyncProcessorFactory;
|
|
|
|
}}}
|
|
|
|
namespace apache { namespace thrift { namespace transport {
|
|
|
|
class TMemoryBuffer;
|
|
|
|
}}}
|
|
|
|
namespace auth {
|
|
class service;
|
|
}
|
|
|
|
namespace service { class storage_service; }
|
|
|
|
namespace data_dictionary {
|
|
class database;
|
|
}
|
|
|
|
struct thrift_server_config {
|
|
::updateable_timeout_config timeout_config;
|
|
uint64_t max_request_size;
|
|
std::function<semaphore& ()> get_service_memory_limiter_semaphore;
|
|
};
|
|
|
|
class thrift_server {
|
|
class connection : public boost::intrusive::list_base_hook<> {
|
|
struct fake_transport;
|
|
thrift_server& _server;
|
|
connected_socket _fd;
|
|
input_stream<char> _read_buf;
|
|
output_stream<char> _write_buf;
|
|
temporary_buffer<char> _in_tmp;
|
|
thrift_std::shared_ptr<fake_transport> _transport;
|
|
thrift_std::shared_ptr<apache::thrift::transport::TMemoryBuffer> _input;
|
|
thrift_std::shared_ptr<apache::thrift::transport::TMemoryBuffer> _output;
|
|
thrift_std::shared_ptr<apache::thrift::protocol::TProtocol> _in_proto;
|
|
thrift_std::shared_ptr<apache::thrift::protocol::TProtocol> _out_proto;
|
|
thrift_std::shared_ptr<apache::thrift::async::TAsyncProcessor> _processor;
|
|
promise<> _processor_promise;
|
|
public:
|
|
connection(thrift_server& server, connected_socket&& fd, socket_address addr);
|
|
~connection();
|
|
connection(connection&&);
|
|
future<> process();
|
|
future<> read();
|
|
future<> write();
|
|
void shutdown();
|
|
private:
|
|
future<> process_one_request();
|
|
};
|
|
private:
|
|
std::vector<server_socket> _listeners;
|
|
std::unique_ptr<thrift_stats> _stats;
|
|
service_permit _current_permit = empty_service_permit();
|
|
thrift_server_config _config;
|
|
thrift_std::shared_ptr<::cassandra::CassandraCobSvIfFactory> _handler_factory;
|
|
std::unique_ptr<apache::thrift::protocol::TProtocolFactory> _protocol_factory;
|
|
thrift_std::shared_ptr<apache::thrift::async::TAsyncProcessorFactory> _processor_factory;
|
|
uint64_t _total_connections = 0;
|
|
uint64_t _current_connections = 0;
|
|
uint64_t _requests_served = 0;
|
|
uint64_t _requests_serving = 0;
|
|
uint64_t _requests_blocked_memory = 0;
|
|
semaphore& _memory_available;
|
|
utils::updateable_value<uint32_t> _max_concurrent_requests;
|
|
size_t _requests_shed;
|
|
boost::intrusive::list<connection> _connections_list;
|
|
seastar::gate _stop_gate;
|
|
public:
|
|
thrift_server(data_dictionary::database db, distributed<cql3::query_processor>& qp, sharded<service::storage_service>& ss, sharded<service::storage_proxy>& proxy, auth::service&, service::memory_limiter& ml, thrift_server_config config);
|
|
~thrift_server();
|
|
future<> listen(socket_address addr, bool keepalive);
|
|
future<> stop();
|
|
void do_accepts(int which, bool keepalive, int num_attempts);
|
|
uint64_t total_connections() const;
|
|
uint64_t current_connections() const;
|
|
uint64_t requests_served() const;
|
|
uint64_t requests_serving() const;
|
|
size_t max_request_size() const;
|
|
const semaphore& memory_available() const;
|
|
uint64_t requests_blocked_memory() const;
|
|
uint64_t requests_shed() const;
|
|
|
|
private:
|
|
void maybe_retry_accept(int which, bool keepalive, std::exception_ptr ex);
|
|
};
|
|
|
|
#endif /* APPS_SEASTAR_THRIFT_SERVER_HH_ */
|