Botond Dénes b61822900b utils/http: make dns_connection_factory::initialize() static ...

Said method can out-live the factory instance. This was not a problem
because the method takes care to keep all its need from `this` alive, by
copying them to the coroutine stack. However, this fact that this method
can out-live the instance is not obvious, and an unsuspecting developer
(me) added a new member (_logger) which was not kept alive.
This can cause a use-after-free in the factory. Fix by making
initialize() static, forcing the instance to pass all parameters
explicitely and add a comment explaining that this method can out-live
the instance.

2023-11-07 04:39:33 -05:00

2.7 KiB

Raw Blame History

View Raw