mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-21 00:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
4e2d7aa2a20fa32fcf025a1d87219b5fcbc08445
scylladb/test/boost
History
Tomasz Grabiec c1de4859d8 Merge 'tablets: Fix race between repair and split' from Raphael "Raph" Carvalho 
Consider the following:

```
T
0   split prepare starts
1                               repair starts
2   split prepare finishes
3                               repair adds unsplit sstables
4                               repair ends
5   split executes
```

If repair produces sstable after split prepare phase, the replica will not split that sstable later, as prepare phase is considered completed already. That causes split execution to fail as replicas weren't really prepared. This also can be triggered with load-and-stream which shares the same write (consumer) path.

The approach to fix this is the same employed to prevent a race between split and migration. If migration happens during prepare phase, it can happen source misses the split request, but the tablet will still be split on the destination (if needed). Similarly, the repair writer becomes responsible for splitting the data if underlying table is in split mode. That's implemented in replica::table for correctness, so if node crashes, the new sstable missing split is still split before added to the set.

Fixes #19378.
Fixes #19416.

**Please replace this line with justification for the backport/\* labels added to this PR**

Closes scylladb/scylladb#19427

* github.com:scylladb/scylladb:
  tablets: Fix race between repair and split
  compaction: Allow "offline" sstable to be split
2024-08-19 14:44:28 +02:00
..
aggregate_fcts_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
allocation_strategy_test.cc
…
alternator_unit_test.cc
…
anchorless_list_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
auth_passwords_test.cc
…
auth_resource_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
auth_test.cc
treewide: include seastar headers with brackets
2024-06-21 19:20:27 +03:00
batchlog_manager_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
big_decimal_test.cc
…
bloom_filter_test.cc
boost/bloom_filter_test: wait for total memory reclaimed update
2024-07-26 08:15:11 +03:00
bptree_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
broken_sstable_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
btree_test.cc
…
bytes_ostream_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
cache_algorithm_test.cc
auth: do not include unused headers
2024-06-17 17:33:55 +03:00
cache_mutation_reader_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
cached_file_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
caching_options_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
canonical_mutation_test.cc
canonical_mutation: add make_canonical_mutation_gently
2024-05-02 19:37:04 +03:00
cartesian_product_test.cc
…
castas_fcts_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cdc_generation_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
cdc_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
cell_locker_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
checksum_utils_test.cc
…
chunked_managed_vector_test.cc
test/boost/chunked_managed_vector_test: fix testcase tests_reserve_partial
2024-06-14 13:47:10 +05:30
chunked_vector_test.cc
chunked_vector_test: add tests for value-initialization constructor
2024-06-25 12:08:11 +03:00
clustering_ranges_walker_test.cc
…
CMakeLists.txt
test/boost: test abort behaviour during index read
2024-07-16 20:42:50 +05:30
column_mapping_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
commitlog_cleanup_test.cc
auth: do not include unused headers
2024-06-17 17:33:55 +03:00
commitlog_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
compaction_group_test.cc
compaction: replace optional<task_info> with task_info param
2024-08-02 14:38:46 +02:00
compound_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
compress_test.cc
…
config_test.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
continuous_data_consumer_test.cc
reader_permit: store schema_ptr instead of raw schema pointer
2024-01-11 08:37:56 +02:00
counter_test.cc
mutation_partition: drop reverse parameter in compact_for_query
2024-08-13 10:07:12 +02:00
cql_auth_query_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
cql_auth_syntax_test.cc
…
cql_functions_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
cql_query_group_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_large_test.cc
compaction: replace optional<task_info> with task_info param
2024-08-02 14:38:46 +02:00
cql_query_like_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
crc_test.cc
…
data_listeners_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
database_test.cc
Merge 'compaction: drop compaction executors' possibility to bypass task manager' from Aleksandra Martyniuk
2024-08-11 10:26:43 +03:00
dirty_memory_manager_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
double_decker_test.cc
utils: do not include unused headers
2024-01-18 12:50:06 +02:00
duration_test.cc
…
dynamic_bitset_test.cc
…
enum_option_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
enum_set_test.cc
treewide: replace formatter<std::string_view> with formatter<string_view>
2024-04-19 07:44:07 +03:00
error_injection_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
estimated_histogram_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
exception_container_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
exceptions_fallback_test.cc
…
exceptions_optimized_test.cc
…
exceptions_test.inc.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
expr_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
extensions_test.cc
…
filtering_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
flush_queue_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
fragmented_temporary_buffer_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
frozen_mutation_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
gossiping_property_file_snitch_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
group0_cmd_merge_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
group0_test.cc
raft: use the abort source reference in raft group0 client interface
2024-07-31 09:18:54 +02:00
hash_test.cc
…
hashers_test.cc
reader_permit: store schema_ptr instead of raw schema pointer
2024-01-11 08:37:56 +02:00
hint_test.cc
test/boost/hint_test.cc: Add missing parse() callback
2024-06-19 23:19:33 +02:00
idl_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
index_reader_test.cc
test/boost: test abort behaviour during index read
2024-07-16 20:42:50 +05:30
index_with_paging_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
input_stream_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
intrusive_array_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
json_cql_query_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
json_test.cc
…
keys_test.cc
…
large_paging_state_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
like_matcher_test.cc
…
limiting_data_source_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
linearizing_input_stream_test.cc
…
lister_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
loading_cache_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
locator_topology_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
log_heap_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
logalloc_standard_allocator_segment_pool_backend_test.cc
…
logalloc_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
managed_bytes_test.cc
…
managed_vector_test.cc
…
map_difference_test.cc
…
memtable_test.cc
extensions: Add exception types for IO extensions and handle in memtable write path
2024-08-11 13:52:35 +03:00
multishard_combining_reader_as_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
multishard_mutation_query_test.cc
query::trim_clustering_row_ranges_to: require reversed schema for native reversed ranges
2024-08-13 10:07:10 +02:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mutation_query_test.cc
readers: Use reversed schema and native reversed slices
2024-08-13 10:03:46 +02:00
mutation_reader_another_test.cc
readers: Use reversed schema and native reversed slices
2024-08-13 10:03:46 +02:00
mutation_reader_test.cc
query::trim_clustering_row_ranges_to: require reversed schema for native reversed ranges
2024-08-13 10:07:10 +02:00
mutation_test.cc
mutation_partition: drop reverse parameter in compact_for_query
2024-08-13 10:07:12 +02:00
mutation_writer_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mvcc_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
network_topology_strategy_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
nonwrapping_interval_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
observable_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
partitioner_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
per_partition_rate_limit_test.cc
test: Avoid using deprecated sharded API
2024-05-16 00:28:47 +02:00
pretty_printers_test.cc
utils/pretty_printers: add "I" specifier support
2024-01-11 14:33:47 +08:00
querier_cache_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
query_processor_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
radix_tree_test.cc
…
range_assert.hh
…
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
clustering_bounds_comparator: add fmt::formtter for bound_{kind,view}
2024-03-11 11:37:48 +02:00
rate_limiter_test.cc
…
reader_concurrency_semaphore_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
recent_entries_map_test.cc
…
repair_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
restrictions_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
result_utils_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
reusable_buffer_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
role_manager_test.cc
cql3: auth: use mutation collector for alter role
2024-06-04 15:43:04 +02:00
row_cache_test.cc
readers: Use reversed schema and native reversed slices
2024-08-13 10:03:46 +02:00
rust_test.cc
…
s3_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
schema_change_test.cc
service/migration_listener: update_tablet_metadata(): add hint parameter
2024-08-11 09:53:19 -04:00
schema_changes_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
schema_loader_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
schema_registry_test.cc
treewide: don't #include "gms/feature_service.hh" from other headers
2024-03-26 15:31:18 +02:00
secondary_index_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
serialization_test.cc
gms: remove unused operator<<
2024-06-18 15:55:22 +08:00
serialized_action_test.cc
…
service_level_controller_test.cc
service/qos/service_level_controller: notify subscribers on effective
2024-08-08 10:42:09 +02:00
sessions_test.cc
…
small_vector_test.cc
treewide: do not define FMT_DEPRECATED_OSTREAM
2024-04-19 22:57:36 +08:00
snitch_reset_test.cc
treewide: include used headers
2024-05-27 17:34:38 +03:00
sorting_test.cc
test/boost: add test for topological sorting
2024-05-16 13:30:03 +02:00
sstable_3_x_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
sstable_compaction_test.cc
compaction: Allow "offline" sstable to be split
2024-08-12 17:27:16 -03:00
sstable_conforms_to_mutation_source_test.cc
readers: Use reversed schema and native reversed slices
2024-08-13 10:03:46 +02:00
sstable_datafile_test.cc
treewide: change assert() to SCYLLA_ASSERT()
2024-08-05 08:23:35 +03:00
sstable_directory_test.cc
distributed_loader: Lock table via global table ptr
2024-08-14 20:53:21 +03:00
sstable_generation_test.cc
…
sstable_move_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_mutation_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_partition_index_cache_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_resharding_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_set_test.cc
boost/sstable_set_test: add testcase to test tablet_sstable_set copy constructor
2024-08-17 23:38:05 +05:30
sstable_test.cc
test/sstable: merge test_using_reusable_sst*()
2024-08-12 17:52:01 +03:00
sstable_test.hh
boost/sstable_set_test: add testcase to test tablet_sstable_set copy constructor
2024-08-17 23:38:05 +05:30
stall_free_test.cc
utils/stall_free: introduce reserve_gently
2024-06-18 23:36:30 +05:30
statement_restrictions_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
storage_proxy_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
string_format_test.cc
test: string_format_test: disable test if {fmt} >= 10.0.0
2024-05-03 11:34:23 +03:00
suite.yaml
boost/bloom_filter_test: add testcase to verify unlinked sstables are not reloaded
2024-07-19 13:15:57 +05:30
summary_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
tablets_test.cc
test/boost/tablets_test: add test for partial tablet metadata updates
2024-08-11 09:53:19 -04:00
tagged_integer_test.cc
…
token_metadata_test.cc
treewide: do not define FMT_DEPRECATED_OSTREAM
2024-04-19 22:57:36 +08:00
top_k_test.cc
treewide: include used headers
2024-05-27 17:34:38 +03:00
total_order_check.hh
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
tracing_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
transport_test.cc
Revert "Introduce TABLET_KEYSPACE event to differentiate processing path of a vnode vs tablets ks"
2024-06-04 15:43:04 +02:00
types_test.cc
types: remove unused operator<<
2024-06-18 15:55:22 +08:00
user_function_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
user_types_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
utf8_test.cc
…
UUID_test.cc
treewide: use fmt::to_string() to transform a UUID to std::string
2024-03-26 13:38:37 +08:00
view_build_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
view_complex_test.cc
compaction: replace optional<task_info> with task_info param
2024-08-02 14:38:46 +02:00
view_schema_ckey_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
view_schema_pkey_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
view_schema_test.cc
node_update_backlog: divide adding and fetching backlogs
2024-06-06 10:45:13 +02:00
vint_serialization_test.cc
…
virtual_reader_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
virtual_table_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
virtual_table_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
wasm_alloc_test.cc
…
wasm_test.cc
…
wrapping_interval_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00