mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
574c81eac6fb79cd3052d01ac1889544e03e545f
scylladb/cql3/statements
History
Wojciech Mitros 88d3fc68b5 alter_table_statement: fix renaming multiple columns in tables with views 
When we rename columns in a table which has materialized views depending
on it, we need to also rename them in the materialized views' WHERE
clauses.
Currently, we do that by creating a new WHERE clause after each rename,
with the updated column. This is later converted to a mutation that
overwrites the WHERE clause. After multiple renames, we have multiple
mutations, each overwriting the WHERE clause with one column renamed.
As a result, the final WHERE clause is one of the modified clauses with
one column renamed.
Instead, we should prepare one new WHERE clause which includes all the
renamed columns. This patch accomplishes this by processing all the
column renames first, and only preparing the new view schema with the
new WHERE clause afterwards.

This patch also includes a test reproducer for this scenario.

Fixes scylladb/scylladb#22194

Closes scylladb/scylladb#23152
2025-03-25 09:58:58 +01:00
..
raw
cql3/select_statement: reject PER PARTITION LIMIT with SELECT DISTINCT
2025-02-24 14:50:18 +02:00
alter_keyspace_statement.cc
cql3: Ensure that CREATE and ALTER never lead to RF-rack-invalid keyspaces
2025-03-19 14:51:47 +01:00
alter_keyspace_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
alter_role_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
alter_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
alter_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
alter_table_statement.cc
alter_table_statement: fix renaming multiple columns in tables with views
2025-03-25 09:58:58 +01:00
alter_table_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
alter_type_statement.cc
tree: Remove unused boost headers
2025-02-15 20:32:22 +02:00
alter_type_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
alter_view_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
alter_view_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
attach_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
attach_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
authentication_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
authentication_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
authorization_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
authorization_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
batch_statement.cc
cql3, test: switch from boost::adaptors::uniqued to utils::views:unique
2025-01-21 16:24:45 +08:00
batch_statement.hh
audit: Add the audit subsystem
2025-01-15 11:10:35 +01:00
bound.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
cas_request.cc
db: cql3: add comments regarding unsafe interval<clustering_key_prefix>
2025-02-26 12:01:28 +01:00
cas_request.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
cf_prop_defs.cc
schema: add per-table tablet options
2025-02-06 08:55:51 +02:00
cf_prop_defs.hh
schema: add per-table tablet options
2025-02-06 08:55:51 +02:00
cf_properties.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
cf_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
create_aggregate_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_aggregate_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_function_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_function_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_index_statement.cc
Materialized view name length should be limited
2025-02-11 22:16:09 +02:00
create_index_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
create_keyspace_statement.cc
cql3: Ensure that CREATE and ALTER never lead to RF-rack-invalid keyspaces
2025-03-19 14:51:47 +01:00
create_keyspace_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
create_role_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
create_table_statement.cc
cql3,test: replace boost::range::adjacent_find with std::ranges
2025-03-04 10:08:02 +02:00
create_table_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_type_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_type_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
create_view_statement.cc
Materialized view name length should be limited
2025-02-11 22:16:09 +02:00
create_view_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
delete_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
delete_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
describe_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
describe_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
detach_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
detach_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_aggregate_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_aggregate_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_function_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_function_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_index_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_index_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_keyspace_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_keyspace_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_role_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_table_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_table_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_type_statement.cc
tree: Remove unused boost headers
2025-02-15 20:32:22 +02:00
drop_type_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_view_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_view_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
function_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
function_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
grant_role_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
grant_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
grant_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
index_prop_defs.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
index_prop_defs.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
index_target.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
index_target.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
ks_prop_defs.cc
network_topology_strategy/alter ks: Remove dc:s from options once rf=0
2025-02-15 20:32:22 +02:00
ks_prop_defs.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_effective_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_effective_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_permissions_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_permissions_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_roles_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_service_level_attachments_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_service_level_attachments_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_service_level_statement.cc
audit: Add shares support to service level management
2025-01-15 15:01:05 +01:00
list_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_users_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_users_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
modification_statement.cc
utils: config_file: forward_declare boost::program_options classes
2025-01-27 10:45:43 +03:00
modification_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
permission_altering_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
permission_altering_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
prepared_statement.hh
config: add enable_create_table_with_compact_storage
2025-01-20 08:03:25 +02:00
property_definitions.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
property_definitions.hh
Allow to use memtable_flush_period_in_ms schema option for system tables
2025-02-07 10:33:05 +02:00
prune_materialized_view_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
prune_materialized_view_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
request_validations.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
revoke_role_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
revoke_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
revoke_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
role-management-statements.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
schema_altering_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
schema_altering_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
select_statement.cc
Merge 'Apply hard limit to partition range vectors in secondary index queries' from Nikos Dragazis
2025-03-14 15:06:07 +02:00
select_statement.hh
cql3/select_statement: require LIMIT and PER PARTITION LIMIT to be strictly positive
2025-03-03 08:13:27 +02:00
service_level_statement.cc
audit: Add shares support to service level management
2025-01-15 15:01:05 +01:00
service_level_statement.hh
audit: Add shares support to service level management
2025-01-15 15:01:05 +01:00
sl_prop_defs.cc
cql3/statements: update SL statements for workload prioritization
2025-01-02 07:13:34 +01:00
sl_prop_defs.hh
cql3/statements: update SL statements for workload prioritization
2025-01-02 07:13:34 +01:00
statement_type.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_modification_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_modification_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_select_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_select_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
truncate_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
truncate_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
update_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
update_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
use_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
use_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00