a51529dd15
In early versions of the series which proposed protocol servers, the interface had two methods answering pretty much the same question of whether the server is running or not: * listen_addresses(): empty list -> server not running * is_server_running() To reduce redundancy and to avoid possible inconsistencies between the two methods, `is_server_running()` was scrapped, but re-added by a follow-up patch because `listen_addresses()` proved to be unreliable as a source for whether the server is running or not. This patch restores the previous state of having only `listen_addresses()` with two additional changes: * rephrase the comment on `listen_addresses()` to make it clear that implementations must return empty list when the server is not running; * those implementations that have a reliable source of whether the server is running or not, use it to force-return an empty list when the server is not running Tests: dtest(nodetool_additional_test.py) Signed-off-by: Botond Dénes <bdenes@scylladb.com> Message-Id: <20211117062539.16932-1-bdenes@scylladb.com>
92 lines
2.8 KiB
C++
92 lines
2.8 KiB
C++
/*
|
|
* Copyright (C) 2019 pengjian.uestc @ gmail.com
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "seastar/core/future.hh"
|
|
#include "seastar/core/shared_ptr.hh"
|
|
#include "seastar/core/sharded.hh"
|
|
|
|
#include "protocol_server.hh"
|
|
|
|
namespace db {
|
|
class config;
|
|
};
|
|
|
|
namespace redis {
|
|
class query_processor;
|
|
}
|
|
|
|
namespace redis_transport {
|
|
class redis_server;
|
|
}
|
|
|
|
namespace auth {
|
|
class service;
|
|
}
|
|
|
|
namespace service {
|
|
class storage_proxy;
|
|
class migration_manager;
|
|
}
|
|
|
|
namespace gms {
|
|
class gossiper;
|
|
}
|
|
|
|
class database;
|
|
|
|
namespace redis {
|
|
|
|
// As defined in: https://redis.io/topics/protocol
|
|
// "The RESP protocol was introduced in Redis 1.2, but it became the standard way
|
|
// for talking with the Redis server in Redis 2.0. This is the protocol you
|
|
// should implement in your Redis client."
|
|
// The protocol itself doesn't seem to have a version, but it was stabilized in
|
|
// Redis 2.0 according to the above quite so that is the version we are going to use.
|
|
constexpr const char* version = "2.0";
|
|
|
|
class controller : public protocol_server {
|
|
seastar::sharded<redis::query_processor> _query_processor;
|
|
seastar::shared_ptr<seastar::sharded<redis_transport::redis_server>> _server;
|
|
seastar::sharded<service::storage_proxy>& _proxy;
|
|
seastar::sharded<auth::service>& _auth_service;
|
|
seastar::sharded<service::migration_manager>& _mm;
|
|
db::config& _cfg;
|
|
seastar::sharded<gms::gossiper>& _gossiper;
|
|
std::vector<socket_address> _listen_addresses;
|
|
private:
|
|
seastar::future<> listen(seastar::sharded<auth::service>& auth_service, db::config& cfg);
|
|
public:
|
|
controller(seastar::sharded<service::storage_proxy>& proxy, seastar::sharded<auth::service>& auth_service,
|
|
seastar::sharded<service::migration_manager>& mm, db::config& cfg, seastar::sharded<gms::gossiper>& gossiper);
|
|
~controller();
|
|
virtual sstring name() const override;
|
|
virtual sstring protocol() const override;
|
|
virtual sstring protocol_version() const override;
|
|
virtual std::vector<socket_address> listen_addresses() const override;
|
|
virtual future<> start_server() override;
|
|
virtual future<> stop_server() override;
|
|
virtual future<> request_stop_server() override;
|
|
};
|
|
|
|
}
|