Tomasz Grabiec 567da3e063 memtable, cache: Fix exception safety of partition entry insertions ...

boost::intrusive::set::insert() may throw if keys require
linearization and that fails, in which case we will leak the entry.

When this happens in cache, we will also violate the invariant for
entry eviction, which assumes all tracked entries are linked, and
cause a SEGFAULT.

Use the non-throwing and faster insert_before() instead. Where we
can't use insert_before(), use alloc_strategy_unique_ptr<> to ensure
that entry is deallocated on insert failure.

Fixes #3585.

2018-07-17 16:30:01 +02:00

54 KiB

Raw Blame History

View Raw