assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
133 lines
5.3 KiB
C++
133 lines
5.3 KiB
C++
/*
|
|
* Copyright (C) 2020-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "utils/assert.hh"
|
|
#include "schema/schema_fwd.hh"
|
|
#include "mutation/position_in_partition.hh"
|
|
#include <boost/icl/interval_set.hpp>
|
|
|
|
// Represents a non-contiguous subset of clustering_key domain of a particular schema.
|
|
// Can be treated like an ordered and non-overlapping sequence of position_range:s.
|
|
class clustering_interval_set {
|
|
// Needed to make position_in_partition comparable, required by boost::icl::interval_set.
|
|
class position_in_partition_with_schema {
|
|
schema_ptr _schema;
|
|
position_in_partition _pos;
|
|
public:
|
|
position_in_partition_with_schema()
|
|
: _pos(position_in_partition::for_static_row())
|
|
{ }
|
|
position_in_partition_with_schema(schema_ptr s, position_in_partition pos)
|
|
: _schema(std::move(s))
|
|
, _pos(std::move(pos))
|
|
{ }
|
|
bool operator<(const position_in_partition_with_schema& other) const {
|
|
return position_in_partition::less_compare(*_schema)(_pos, other._pos);
|
|
}
|
|
bool operator==(const position_in_partition_with_schema& other) const {
|
|
return position_in_partition::equal_compare(*_schema)(_pos, other._pos);
|
|
}
|
|
const position_in_partition& position() const { return _pos; }
|
|
};
|
|
private:
|
|
// We want to represent intervals of clustering keys, not position_in_partitions,
|
|
// but clustering_key domain is not enough to represent all kinds of clustering ranges.
|
|
// All intervals in this set are of the form [x, y).
|
|
using set_type = boost::icl::interval_set<position_in_partition_with_schema>;
|
|
using interval = boost::icl::interval<position_in_partition_with_schema>;
|
|
set_type _set;
|
|
public:
|
|
clustering_interval_set() = default;
|
|
// Constructs from legacy clustering_row_ranges
|
|
clustering_interval_set(const schema& s, const query::clustering_row_ranges& ranges) {
|
|
for (auto&& r : ranges) {
|
|
add(s, position_range::from_range(r));
|
|
}
|
|
}
|
|
query::clustering_row_ranges to_clustering_row_ranges() const {
|
|
query::clustering_row_ranges result;
|
|
for (position_range r : *this) {
|
|
result.push_back(query::clustering_range::make(
|
|
{r.start().key(), r.start()._bound_weight != bound_weight::after_all_prefixed},
|
|
{r.end().key(), r.end()._bound_weight == bound_weight::after_all_prefixed}));
|
|
}
|
|
return result;
|
|
}
|
|
class position_range_iterator {
|
|
public:
|
|
using iterator_category = std::input_iterator_tag;
|
|
using value_type = const position_range;
|
|
using difference_type = std::ptrdiff_t;
|
|
using pointer = const position_range*;
|
|
using reference = const position_range&;
|
|
private:
|
|
set_type::iterator _i;
|
|
public:
|
|
position_range_iterator(set_type::iterator i) : _i(i) {}
|
|
position_range operator*() const {
|
|
// FIXME: Produce position_range view. Not performance critical yet.
|
|
const interval::interval_type& iv = *_i;
|
|
return position_range{iv.lower().position(), iv.upper().position()};
|
|
}
|
|
bool operator==(const position_range_iterator& other) const = default;
|
|
position_range_iterator& operator++() {
|
|
++_i;
|
|
return *this;
|
|
}
|
|
position_range_iterator operator++(int) {
|
|
auto tmp = *this;
|
|
++_i;
|
|
return tmp;
|
|
}
|
|
};
|
|
static interval::type make_interval(const schema& s, const position_range& r) {
|
|
SCYLLA_ASSERT(r.start().has_clustering_key());
|
|
SCYLLA_ASSERT(r.end().has_clustering_key());
|
|
return interval::right_open(
|
|
position_in_partition_with_schema(s.shared_from_this(), r.start()),
|
|
position_in_partition_with_schema(s.shared_from_this(), r.end()));
|
|
}
|
|
public:
|
|
bool equals(const schema& s, const clustering_interval_set& other) const {
|
|
return boost::equal(_set, other._set);
|
|
}
|
|
bool contains(const schema& s, position_in_partition_view pos) const {
|
|
// FIXME: Avoid copy
|
|
return _set.find(position_in_partition_with_schema(s.shared_from_this(), position_in_partition(pos))) != _set.end();
|
|
}
|
|
// Returns true iff this set is fully contained in the other set.
|
|
bool contained_in(clustering_interval_set& other) const {
|
|
return boost::icl::within(_set, other._set);
|
|
}
|
|
bool overlaps(const schema& s, const position_range& range) const {
|
|
// FIXME: Avoid copy
|
|
auto r = _set.equal_range(make_interval(s, range));
|
|
return r.first != r.second;
|
|
}
|
|
// Adds given clustering range to this interval set.
|
|
// The range may overlap with this set.
|
|
void add(const schema& s, const position_range& r) {
|
|
_set += make_interval(s, r);
|
|
}
|
|
void add(const schema& s, const clustering_interval_set& other) {
|
|
for (auto&& r : other) {
|
|
add(s, r);
|
|
}
|
|
}
|
|
position_range_iterator begin() const { return {_set.begin()}; }
|
|
position_range_iterator end() const { return {_set.end()}; }
|
|
};
|
|
|
|
template <> struct fmt::formatter<clustering_interval_set> : fmt::formatter<string_view> {
|
|
auto format(const clustering_interval_set& set, fmt::format_context& ctx) const {
|
|
return fmt::format_to(ctx.out(), "{{{}}}", fmt::join(set, ",\n "));
|
|
}
|
|
};
|