mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-28 04:06:59 +00:00
aa1270a00c
assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
92 lines
2.6 KiB
C++
92 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 2018-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "utils/assert.hh"
|
|
#include "partition_version.hh"
|
|
|
|
// Double-ended chained list of partition_version objects
|
|
// utilizing partition_version's intrinsic anchorless_list_base_hook.
|
|
class partition_version_list {
|
|
// All references have unique_owner set to true
|
|
// so that partition_version::is_referenced_from_entry() is false
|
|
// so that versions owned here (by mutation_cleaner) are not evicted-from.
|
|
partition_version_ref _head;
|
|
partition_version_ref _tail; // nullptr means _tail == _head.
|
|
public:
|
|
// Appends v to the tail of this deque.
|
|
// The version must not be already referenced.
|
|
void push_back(partition_version& v) noexcept {
|
|
if (!_tail) {
|
|
if (_head) {
|
|
v.insert_before(*_head);
|
|
_tail = std::move(_head);
|
|
}
|
|
_head = partition_version_ref(v, true);
|
|
#ifdef SEASTAR_DEBUG
|
|
SCYLLA_ASSERT(!_head->is_referenced_from_entry());
|
|
#endif
|
|
} else {
|
|
v.insert_after(*_tail);
|
|
_tail = partition_version_ref(v, true);
|
|
#ifdef SEASTAR_DEBUG
|
|
SCYLLA_ASSERT(!_tail->is_referenced_from_entry());
|
|
#endif
|
|
}
|
|
}
|
|
|
|
// Returns a reference to the first version in this deque.
|
|
// Call only if !empty().
|
|
partition_version& front() noexcept {
|
|
return *_head;
|
|
}
|
|
|
|
// Returns true iff contains any versions.
|
|
bool empty() const noexcept {
|
|
return !_head;
|
|
}
|
|
|
|
// Detaches the first version from the list.
|
|
// Assumes !empty().
|
|
void pop_front() noexcept {
|
|
if (_tail && _head->next() == &*_tail) {
|
|
_tail = {};
|
|
}
|
|
partition_version* next = _head->next();
|
|
_head->erase();
|
|
_head.release();
|
|
if (next) {
|
|
_head = partition_version_ref(*next, true);
|
|
#ifdef SEASTAR_DEBUG
|
|
SCYLLA_ASSERT(!_head->is_referenced_from_entry());
|
|
#endif
|
|
}
|
|
}
|
|
|
|
// Appends other to the tail of this deque.
|
|
// The other deque will be left empty.
|
|
void splice(partition_version_list& other) noexcept {
|
|
if (!other._head) {
|
|
return;
|
|
}
|
|
if (!_head) {
|
|
_head = std::move(other._head);
|
|
_tail = std::move(other._tail);
|
|
} else {
|
|
(_tail ? _tail : _head)->splice(*other._head);
|
|
if (other._tail) {
|
|
_tail = std::move(other._tail);
|
|
other._head = {};
|
|
} else {
|
|
_tail = std::move(other._head);
|
|
}
|
|
}
|
|
}
|
|
};
|