mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-21 17:10:35 +00:00
aa1270a00c
assert() is traditionally disabled in release builds, but not in
scylladb. This hasn't caused problems so far, but the latest abseil
release includes a commit [1] that causes a 1000 insn/op regression when
NDEBUG is not defined.
Clearly, we must move towards a build system where NDEBUG is defined in
release builds. But we can't just define it blindly without vetting
all the assert() calls, as some were written with the expectation that
they are enabled in release mode.
To solve the conundrum, change all assert() calls to a new SCYLLA_ASSERT()
macro in utils/assert.hh. This macro is always defined and is not conditional
on NDEBUG, so we can later (after vetting Seastar) enable NDEBUG in release
mode.
[1] 66ef711d68
Closes scylladb/scylladb#20006
76 lines
2.1 KiB
C++
76 lines
2.1 KiB
C++
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (AGPL-3.0-or-later and Apache-2.0)
|
|
*/
|
|
|
|
#include "utils/assert.hh"
|
|
#include "transport/event.hh"
|
|
|
|
namespace cql_transport {
|
|
|
|
event::event(const event_type& type_)
|
|
: type{type_}
|
|
{ }
|
|
|
|
event::topology_change::topology_change(change_type change, const socket_address& node)
|
|
: event{event_type::TOPOLOGY_CHANGE}
|
|
, change{change}
|
|
, node{node}
|
|
{ }
|
|
|
|
event::topology_change event::topology_change::new_node(const gms::inet_address& host, uint16_t port)
|
|
{
|
|
return topology_change{change_type::NEW_NODE, socket_address{host, port}};
|
|
}
|
|
|
|
event::topology_change event::topology_change::removed_node(const gms::inet_address& host, uint16_t port)
|
|
{
|
|
return topology_change{change_type::REMOVED_NODE, socket_address{host, port}};
|
|
}
|
|
|
|
event::status_change::status_change(status_type status, const socket_address& node)
|
|
: event{event_type::STATUS_CHANGE}
|
|
, status{status}
|
|
, node{node}
|
|
{ }
|
|
|
|
event::status_change event::status_change::node_up(const gms::inet_address& host, uint16_t port)
|
|
{
|
|
return status_change{status_type::UP, socket_address{host, port}};
|
|
}
|
|
|
|
event::status_change event::status_change::node_down(const gms::inet_address& host, uint16_t port)
|
|
{
|
|
return status_change{status_type::DOWN, socket_address{host, port}};
|
|
}
|
|
|
|
event::schema_change::schema_change(change_type change, target_type target, sstring keyspace, std::vector<sstring> arguments)
|
|
: event(event_type::SCHEMA_CHANGE)
|
|
, change(change)
|
|
, target(target)
|
|
, keyspace(std::move(keyspace))
|
|
, arguments(std::move(arguments))
|
|
{
|
|
switch (target) {
|
|
case event::schema_change::target_type::KEYSPACE:
|
|
SCYLLA_ASSERT(this->arguments.empty());
|
|
break;
|
|
case event::schema_change::target_type::TYPE:
|
|
case event::schema_change::target_type::TABLE:
|
|
// just the name
|
|
SCYLLA_ASSERT(this->arguments.size() == 1);
|
|
break;
|
|
case event::schema_change::target_type::FUNCTION:
|
|
case event::schema_change::target_type::AGGREGATE:
|
|
// at least the name
|
|
SCYLLA_ASSERT(this->arguments.size() >= 1);
|
|
break;
|
|
}
|
|
}
|
|
}
|