mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
d5af86bd8a016e3fd72d70923375bd457c4eaadd
scylladb/test/boost
History
Avi Kivity dde209390f Merge 'sstables: fix some mixups between the writer's schema and the sstable's schema' from Michał Chojnowski 
There are two schemas associated with a sstable writer:
the sstable's schema (i.e. the schema of the table at the time when the
sstable object was created), and the writer's schema (equal to the schema
of the reader which is feeding into the writer).

It's easy to mix up the two and break something as a result.

The writer's schema is needed to correctly interpret and serialize the data
passing through the writer, and to populate the on-disk metadata about the
on-disk schema.

The sstables's schema is used to configure some parameters for newly created
sstable, such as bloom filter false positive ratio, or compression.

This series fixes the known mixups between the two — when setting up compression,
and when setting up the bloom filters.

Fixes #16065

The bug is present in all supported versions, so the patch has to be backported to all of them.

Closes scylladb/scylladb#19695

* github.com:scylladb/scylladb:
  sstables/mx/writer: when creating local_compression, use the sstables's schema, not the writer's
  sstables/mx/writer: when creating filter, use the sstables's schema, not the writer's
  sstables: for i_filter downcasts, use dynamic_cast instead of static_cast
2024-07-16 12:17:41 +03:00
..
aggregate_fcts_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
allocation_strategy_test.cc
…
alternator_unit_test.cc
…
anchorless_list_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
auth_passwords_test.cc
…
auth_resource_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
auth_test.cc
treewide: include seastar headers with brackets
2024-06-21 19:20:27 +03:00
batchlog_manager_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
big_decimal_test.cc
…
bloom_filter_test.cc
bloom_filter_test: add testcase to verify filter rebuilds
2024-06-24 12:11:37 +05:30
bptree_test.cc
…
broken_sstable_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
btree_test.cc
…
bytes_ostream_test.cc
…
cache_algorithm_test.cc
auth: do not include unused headers
2024-06-17 17:33:55 +03:00
cache_mutation_reader_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
cached_file_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
caching_options_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
canonical_mutation_test.cc
canonical_mutation: add make_canonical_mutation_gently
2024-05-02 19:37:04 +03:00
cartesian_product_test.cc
…
castas_fcts_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cdc_generation_test.cc
…
cdc_test.cc
test: do not use operator<< for std::optional
2024-06-18 10:41:48 +08:00
cell_locker_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
checksum_utils_test.cc
…
chunked_managed_vector_test.cc
test/boost/chunked_managed_vector_test: fix testcase tests_reserve_partial
2024-06-14 13:47:10 +05:30
chunked_vector_test.cc
chunked_vector_test: add tests for value-initialization constructor
2024-06-25 12:08:11 +03:00
clustering_ranges_walker_test.cc
…
CMakeLists.txt
test/boost: move bloom filter tests from sstable_datafile_test into a new file
2024-06-24 12:06:02 +05:30
column_mapping_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
commitlog_cleanup_test.cc
auth: do not include unused headers
2024-06-17 17:33:55 +03:00
commitlog_test.cc
replica: get rid of fragile compaction group intrusive list
2024-07-09 16:53:35 -03:00
compaction_group_test.cc
compaction: Check for key presence in memtable when calculating max purgeable timestamp
2024-03-18 13:37:44 +02:00
compound_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
compress_test.cc
…
config_test.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
continuous_data_consumer_test.cc
reader_permit: store schema_ptr instead of raw schema pointer
2024-01-11 08:37:56 +02:00
counter_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
cql_auth_query_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
cql_auth_syntax_test.cc
…
cql_functions_test.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
cql_query_group_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_large_test.cc
bytes: drop unused operator<<
2024-06-25 12:11:28 +03:00
cql_query_like_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_test.cc
test/boost/cql_query_test: add test for single-partition aggregation
2024-06-19 09:24:17 +02:00
crc_test.cc
…
data_listeners_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
database_test.cc
test: Avoid using deprecated sharded API
2024-05-16 00:28:47 +02:00
dirty_memory_manager_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
double_decker_test.cc
utils: do not include unused headers
2024-01-18 12:50:06 +02:00
duration_test.cc
…
dynamic_bitset_test.cc
…
enum_option_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
enum_set_test.cc
treewide: replace formatter<std::string_view> with formatter<string_view>
2024-04-19 07:44:07 +03:00
error_injection_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
estimated_histogram_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
exception_container_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
exceptions_fallback_test.cc
…
exceptions_optimized_test.cc
…
exceptions_test.inc.cc
…
expr_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
extensions_test.cc
…
filtering_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
flush_queue_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
fragmented_temporary_buffer_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
frozen_mutation_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
gossiping_property_file_snitch_test.cc
test: use generic boost_test_print_type()
2024-05-20 12:56:20 +03:00
group0_cmd_merge_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
group0_test.cc
raft: rename mutations_collector to group0_batch
2024-06-06 13:26:34 +02:00
hash_test.cc
…
hashers_test.cc
reader_permit: store schema_ptr instead of raw schema pointer
2024-01-11 08:37:56 +02:00
hint_test.cc
test/boost/hint_test.cc: Add missing parse() callback
2024-06-19 23:19:33 +02:00
idl_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
index_with_paging_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
input_stream_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
intrusive_array_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
json_cql_query_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
json_test.cc
…
keys_test.cc
…
large_paging_state_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
like_matcher_test.cc
…
limiting_data_source_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
linearizing_input_stream_test.cc
…
lister_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
loading_cache_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
locator_topology_test.cc
test: locator_topology: s/get0()/get()/
2024-04-25 16:03:01 +03:00
log_heap_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
logalloc_standard_allocator_segment_pool_backend_test.cc
…
logalloc_test.cc
logalloc: add hold_reserve
2024-07-08 16:08:27 +02:00
managed_bytes_test.cc
…
managed_vector_test.cc
…
map_difference_test.cc
…
memtable_test.cc
replica: get rid of fragile compaction group intrusive list
2024-07-09 16:53:35 -03:00
multishard_combining_reader_as_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
multishard_mutation_query_test.cc
test: Avoid using deprecated sharded API
2024-05-16 00:28:47 +02:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mutation_query_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mutation_reader_another_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mutation_reader_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mutation_test.cc
replica: get rid of fragile compaction group intrusive list
2024-07-09 16:53:35 -03:00
mutation_writer_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
mvcc_test.cc
row_cache: use preemption_source in update()
2024-02-07 18:31:36 +01:00
network_topology_strategy_test.cc
gms: remove unused operator<<
2024-06-18 15:55:22 +08:00
nonwrapping_interval_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
observable_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
partitioner_test.cc
test: Avoid using deprecated sharded API
2024-05-16 00:28:47 +02:00
per_partition_rate_limit_test.cc
test: Avoid using deprecated sharded API
2024-05-16 00:28:47 +02:00
pretty_printers_test.cc
utils/pretty_printers: add "I" specifier support
2024-01-11 14:33:47 +08:00
querier_cache_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
query_processor_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
radix_tree_test.cc
…
range_assert.hh
…
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
clustering_bounds_comparator: add fmt::formtter for bound_{kind,view}
2024-03-11 11:37:48 +02:00
rate_limiter_test.cc
…
reader_concurrency_semaphore_test.cc
test/boost/reader_concurrency_semaphore_test: add test for live-configurable cpu concurrenc
2024-06-27 09:57:11 -04:00
recent_entries_map_test.cc
…
repair_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
restrictions_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
result_utils_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
reusable_buffer_test.cc
…
role_manager_test.cc
cql3: auth: use mutation collector for alter role
2024-06-04 15:43:04 +02:00
row_cache_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
rust_test.cc
…
s3_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
schema_change_test.cc
treewide: drop thrift support
2024-06-07 06:44:59 +08:00
schema_changes_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
schema_loader_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
schema_registry_test.cc
treewide: don't #include "gms/feature_service.hh" from other headers
2024-03-26 15:31:18 +02:00
secondary_index_test.cc
test: Avoid using deprecated sharded API
2024-05-16 00:28:47 +02:00
serialization_test.cc
gms: remove unused operator<<
2024-06-18 15:55:22 +08:00
serialized_action_test.cc
…
service_level_controller_test.cc
test/boost: define fmt::formatter for service_level_controller_test.cc
2024-05-26 12:32:43 +08:00
sessions_test.cc
…
small_vector_test.cc
treewide: do not define FMT_DEPRECATED_OSTREAM
2024-04-19 22:57:36 +08:00
snitch_reset_test.cc
treewide: include used headers
2024-05-27 17:34:38 +03:00
sorting_test.cc
test/boost: add test for topological sorting
2024-05-16 13:30:03 +02:00
sstable_3_x_test.cc
sstables/mx/writer: when creating local_compression, use the sstables's schema, not the writer's
2024-07-11 12:53:54 +02:00
sstable_compaction_test.cc
test: Fix max_ongoing_compaction_test test
2024-07-16 07:29:10 +03:00
sstable_conforms_to_mutation_source_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_datafile_test.cc
test/boost: move bloom filter tests from sstable_datafile_test into a new file
2024-06-24 12:06:02 +05:30
sstable_directory_test.cc
test: sstable_directory_test: use THREADSAFE_BOOST_REQUIRE_EQUAL when appropriate
2024-07-09 10:54:23 +03:00
sstable_generation_test.cc
…
sstable_move_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_mutation_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_partition_index_cache_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_resharding_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_set_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
sstable_test.hh
replica: replace table::as_table_state
2024-05-10 14:56:38 +02:00
stall_free_test.cc
utils/stall_free: introduce reserve_gently
2024-06-18 23:36:30 +05:30
statement_restrictions_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
storage_proxy_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
string_format_test.cc
test: string_format_test: disable test if {fmt} >= 10.0.0
2024-05-03 11:34:23 +03:00
suite.yaml
test: boost: add commitlog_cleanup_test
2024-01-24 10:37:39 +01:00
summary_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
tablets_test.cc
config: Remove experimental TABLETS feature
2024-05-30 18:03:51 +03:00
tagged_integer_test.cc
…
token_metadata_test.cc
treewide: do not define FMT_DEPRECATED_OSTREAM
2024-04-19 22:57:36 +08:00
top_k_test.cc
treewide: include used headers
2024-05-27 17:34:38 +03:00
total_order_check.hh
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
tracing_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
transport_test.cc
Revert "Introduce TABLET_KEYSPACE event to differentiate processing path of a vnode vs tablets ks"
2024-06-04 15:43:04 +02:00
types_test.cc
types: remove unused operator<<
2024-06-18 15:55:22 +08:00
user_function_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00
user_types_test.cc
treewide: include fmt/ranges.h and/or fmt/std.h
2024-04-19 22:56:16 +08:00
utf8_test.cc
…
UUID_test.cc
treewide: use fmt::to_string() to transform a UUID to std::string
2024-03-26 13:38:37 +08:00
view_build_test.cc
treewide: rename flat_mutation_reader_v2 to mutation_reader
2024-06-21 07:12:06 +03:00
view_complex_test.cc
replica: replace table::as_table_state
2024-05-10 14:56:38 +02:00
view_schema_ckey_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
view_schema_pkey_test.cc
test/lib: do not include unused headers
2024-05-05 23:31:48 +03:00
view_schema_test.cc
node_update_backlog: divide adding and fetching backlogs
2024-06-06 10:45:13 +02:00
vint_serialization_test.cc
…
virtual_reader_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
virtual_table_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
virtual_table_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
wasm_alloc_test.cc
…
wasm_test.cc
…
wrapping_interval_test.cc
test/boost: include test/lib/test_utils.hh
2024-05-26 12:32:43 +08:00