mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-24 18:40:38 +00:00
2953d3ebe0
`validate_options` needs to be extended with `topology` parameter, because NetworkTopologyStrategy needs to validate if every explicitly listed DC is really existing. I did cut corner a bit and trimmed the message thrown when it's not the case, just to avoid passing and extra parameter (ks name) to the `validate_options` function, as I find the longer message to be a bit redundant (the driver will receive info which KS modification failed). The tests that have been commented out in the previous commit have been restored.
93 lines
3.1 KiB
C++
93 lines
3.1 KiB
C++
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
*/
|
|
|
|
#include <seastar/core/coroutine.hh>
|
|
#include <seastar/coroutine/maybe_yield.hh>
|
|
|
|
#include "simple_strategy.hh"
|
|
#include "exceptions/exceptions.hh"
|
|
#include "utils/assert.hh"
|
|
#include "utils/class_registrator.hh"
|
|
#include <boost/algorithm/string.hpp>
|
|
|
|
namespace locator {
|
|
|
|
simple_strategy::simple_strategy(replication_strategy_params params) :
|
|
abstract_replication_strategy(params, replication_strategy_type::simple) {
|
|
for (auto& config_pair : _config_options) {
|
|
auto& key = config_pair.first;
|
|
auto& val = config_pair.second;
|
|
|
|
if (boost::iequals(key, "replication_factor")) {
|
|
_replication_factor = parse_replication_factor(val);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
future<host_id_set> simple_strategy::calculate_natural_endpoints(const token& t, const token_metadata& tm) const {
|
|
const std::vector<token>& tokens = tm.sorted_tokens();
|
|
|
|
if (tokens.empty()) {
|
|
co_return host_id_set{};
|
|
}
|
|
|
|
size_t replicas = _replication_factor;
|
|
host_id_set endpoints;
|
|
endpoints.reserve(replicas);
|
|
|
|
for (auto& token : tm.ring_range(t)) {
|
|
// If the number of nodes in the cluster is smaller than the desired
|
|
// replication factor we should return the loop when endpoints already
|
|
// contains all the nodes in the cluster because no more nodes could be
|
|
// added to endpoints lists.
|
|
if (endpoints.size() == replicas || endpoints.size() == tm.count_normal_token_owners()) {
|
|
break;
|
|
}
|
|
|
|
auto ep = tm.get_endpoint(token);
|
|
SCYLLA_ASSERT(ep);
|
|
|
|
endpoints.push_back(*ep);
|
|
co_await coroutine::maybe_yield();
|
|
}
|
|
|
|
co_return endpoints;
|
|
}
|
|
|
|
size_t simple_strategy::get_replication_factor(const token_metadata&) const {
|
|
return _replication_factor;
|
|
}
|
|
|
|
void simple_strategy::validate_options(const gms::feature_service&, const locator::topology&) const {
|
|
auto it = _config_options.find("replication_factor");
|
|
if (it == _config_options.end()) {
|
|
throw exceptions::configuration_exception("SimpleStrategy requires a replication_factor strategy option.");
|
|
}
|
|
parse_replication_factor(it->second);
|
|
if (_uses_tablets) {
|
|
throw exceptions::configuration_exception("SimpleStrategy doesn't support tablet replication");
|
|
}
|
|
}
|
|
|
|
sstring simple_strategy::sanity_check_read_replicas(const effective_replication_map& erm, const host_id_vector_replica_set& read_replicas) const {
|
|
if (read_replicas.size() > _replication_factor) {
|
|
return seastar::format("ERM inconsistency, the read replica set for simple strategy has higher count of"
|
|
" read replicas [{}] than its replication factor [{}]",
|
|
read_replicas.size(),
|
|
_replication_factor);
|
|
}
|
|
return {};
|
|
}
|
|
|
|
using registry = class_registrator<abstract_replication_strategy, simple_strategy, replication_strategy_params>;
|
|
static registry registrator("org.apache.cassandra.locator.SimpleStrategy");
|
|
static registry registrator_short_name("SimpleStrategy");
|
|
|
|
}
|