Currently, we use std::vector<*mutation> to keep
a list of mutations for processing.
This can lead to large allocation, e.g. when the vector
size is a function of the number of tables.
Use a chunked vector instead to prevent oversized allocations.
`perf-simple-query --smp 1` results obtained for fixed 400MHz frequency
and PGO disabled:
Before (read path):
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=read, query_single_key=no, counters=no}
Disabling auto compaction
Creating 10000 partitions...
89055.97 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39417 insns/op, 18003 cycles/op, 0 errors)
103372.72 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39380 insns/op, 17300 cycles/op, 0 errors)
98942.27 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39413 insns/op, 17336 cycles/op, 0 errors)
103752.93 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39407 insns/op, 17252 cycles/op, 0 errors)
102516.77 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39403 insns/op, 17288 cycles/op, 0 errors)
throughput:
mean= 99528.13 standard-deviation=6155.71
median= 102516.77 median-absolute-deviation=3844.59
maximum=103752.93 minimum=89055.97
instructions_per_op:
mean= 39403.99 standard-deviation=14.25
median= 39406.75 median-absolute-deviation=9.30
maximum=39416.63 minimum=39380.39
cpu_cycles_per_op:
mean= 17435.81 standard-deviation=318.24
median= 17300.40 median-absolute-deviation=147.59
maximum=18002.53 minimum=17251.75
```
After (read path)
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=read, query_single_key=no, counters=no}
Disabling auto compaction
Creating 10000 partitions...
59755.04 tps ( 66.2 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39466 insns/op, 22834 cycles/op, 0 errors)
71854.16 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39417 insns/op, 17883 cycles/op, 0 errors)
82149.45 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.2 tasks/op, 39411 insns/op, 17409 cycles/op, 0 errors)
49640.04 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.3 tasks/op, 39474 insns/op, 19975 cycles/op, 0 errors)
54963.22 tps ( 66.1 allocs/op, 0.0 logallocs/op, 14.3 tasks/op, 39474 insns/op, 18235 cycles/op, 0 errors)
throughput:
mean= 63672.38 standard-deviation=13195.12
median= 59755.04 median-absolute-deviation=8709.16
maximum=82149.45 minimum=49640.04
instructions_per_op:
mean= 39448.38 standard-deviation=31.60
median= 39466.17 median-absolute-deviation=25.75
maximum=39474.12 minimum=39411.42
cpu_cycles_per_op:
mean= 19267.01 standard-deviation=2217.03
median= 18234.80 median-absolute-deviation=1384.25
maximum=22834.26 minimum=17408.67
```
`perf-simple-query --smp 1 --write` results obtained for fixed 400MHz frequency
and PGO disabled:
Before (write path):
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=write, query_single_key=no, counters=no}
Disabling auto compaction
63736.96 tps ( 59.4 allocs/op, 16.4 logallocs/op, 14.3 tasks/op, 49667 insns/op, 19924 cycles/op, 0 errors)
64109.41 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 49992 insns/op, 20084 cycles/op, 0 errors)
56950.47 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50005 insns/op, 20501 cycles/op, 0 errors)
44858.42 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50014 insns/op, 21947 cycles/op, 0 errors)
28592.87 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50027 insns/op, 27659 cycles/op, 0 errors)
throughput:
mean= 51649.63 standard-deviation=15059.74
median= 56950.47 median-absolute-deviation=12087.33
maximum=64109.41 minimum=28592.87
instructions_per_op:
mean= 49941.18 standard-deviation=153.76
median= 50005.24 median-absolute-deviation=73.01
maximum=50027.07 minimum=49667.05
cpu_cycles_per_op:
mean= 22023.01 standard-deviation=3249.92
median= 20500.74 median-absolute-deviation=1938.76
maximum=27658.75 minimum=19924.32
```
After (write path)
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=write, query_single_key=no, counters=no}
Disabling auto compaction
53395.93 tps ( 59.4 allocs/op, 16.5 logallocs/op, 14.3 tasks/op, 50326 insns/op, 21252 cycles/op, 0 errors)
46527.83 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50704 insns/op, 21555 cycles/op, 0 errors)
55846.30 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50731 insns/op, 21060 cycles/op, 0 errors)
55669.30 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50735 insns/op, 21521 cycles/op, 0 errors)
52130.17 tps ( 59.3 allocs/op, 16.0 logallocs/op, 14.3 tasks/op, 50757 insns/op, 21334 cycles/op, 0 errors)
throughput:
mean= 52713.91 standard-deviation=3795.38
median= 53395.93 median-absolute-deviation=2955.40
maximum=55846.30 minimum=46527.83
instructions_per_op:
mean= 50650.57 standard-deviation=182.46
median= 50731.38 median-absolute-deviation=84.09
maximum=50756.62 minimum=50325.87
cpu_cycles_per_op:
mean= 21344.42 standard-deviation=202.86
median= 21334.00 median-absolute-deviation=176.37
maximum=21554.61 minimum=21060.24
```
Fixes #24815
Improvement for rare corner cases. No backport required
Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
Closes scylladb/scylladb#24919
155 lines
6.1 KiB
C++
155 lines
6.1 KiB
C++
/*
|
|
* Copyright (C) 2024-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
*/
|
|
|
|
#include <seastar/core/coroutine.hh>
|
|
|
|
#include "mutation/async_utils.hh"
|
|
#include "mutation/mutation_partition_view.hh"
|
|
#include "mutation/partition_version.hh"
|
|
#include "partition_builder.hh"
|
|
#include "mutation/canonical_mutation.hh"
|
|
#include "converting_mutation_partition_applier.hh"
|
|
#include "mutation/mutation_partition_serializer.hh"
|
|
#include "idl/mutation.dist.impl.hh"
|
|
#include "schema/schema_registry.hh"
|
|
|
|
future<> apply_gently(mutation_partition& target, const schema& s, mutation_partition_view p,
|
|
const schema& p_schema, mutation_application_stats& app_stats) {
|
|
mutation_partition p2(target, mutation_partition::copy_comparators_only{});
|
|
partition_builder b(p_schema, p2);
|
|
co_await p.accept_gently(p_schema, b);
|
|
if (s.version() != p_schema.version()) {
|
|
p2.upgrade(p_schema, s);
|
|
}
|
|
apply_resume res;
|
|
// we only move from p2.static_row() in the first iteration when target.static_row() is empty
|
|
// NOLINTNEXTLINE(bugprone-use-after-move)
|
|
while (target.apply_monotonically(s, std::move(p2), no_cache_tracker, app_stats, is_preemptible::yes, res) == stop_iteration::no) {
|
|
co_await yield();
|
|
}
|
|
}
|
|
|
|
future<> apply_gently(mutation_partition& target, const schema& s, const mutation_partition& p,
|
|
const schema& p_schema, mutation_application_stats& app_stats) {
|
|
mutation_partition p2(p_schema, p);
|
|
if (s.version() != p_schema.version()) {
|
|
p2.upgrade(p_schema, s);
|
|
}
|
|
apply_resume res;
|
|
// we only move from p2.static_row() in the first iteration when target.static_row() is empty
|
|
// NOLINTNEXTLINE(bugprone-use-after-move)
|
|
while (target.apply_monotonically(s, std::move(p2), no_cache_tracker, app_stats, is_preemptible::yes, res) == stop_iteration::no) {
|
|
co_await yield();
|
|
}
|
|
}
|
|
|
|
future<> apply_gently(mutation_partition& target, const schema& s, mutation_partition&& p, mutation_application_stats& app_stats) {
|
|
apply_resume res;
|
|
// we only move from p2.static_row() in the first iteration when target.static_row() is empty
|
|
// NOLINTNEXTLINE(bugprone-use-after-move)
|
|
while (target.apply_monotonically(s, std::move(p), no_cache_tracker, app_stats, is_preemptible::yes, res) == stop_iteration::no) {
|
|
co_await yield();
|
|
}
|
|
}
|
|
|
|
future<> apply_gently(mutation& target, mutation&& m) {
|
|
mutation_application_stats app_stats;
|
|
co_await apply_gently(target.partition(), *target.schema(), std::move(m.partition()), *m.schema(), app_stats);
|
|
}
|
|
|
|
future<> apply_gently(mutation& target, const mutation& m) {
|
|
auto m2 = m;
|
|
mutation_application_stats app_stats;
|
|
co_await apply_gently(target.partition(), *target.schema(), std::move(m2.partition()), *m.schema(), app_stats);
|
|
}
|
|
|
|
future<mutation> to_mutation_gently(const canonical_mutation& cm, schema_ptr s) {
|
|
auto in = ser::as_input_stream(cm.representation());
|
|
auto mv = ser::deserialize(in, std::type_identity<ser::canonical_mutation_view>());
|
|
|
|
auto cf_id = mv.table_id();
|
|
if (s->id() != cf_id) {
|
|
throw std::runtime_error(format("Attempted to deserialize canonical_mutation of table {} with schema of table {} ({}.{})",
|
|
cf_id, s->id(), s->ks_name(), s->cf_name()));
|
|
}
|
|
|
|
auto version = mv.schema_version();
|
|
auto pk = mv.key();
|
|
|
|
mutation m(std::move(s), std::move(pk));
|
|
|
|
if (version == m.schema()->version()) {
|
|
auto partition_view = mutation_partition_view::from_view(mv.partition());
|
|
mutation_application_stats app_stats;
|
|
co_await apply_gently(m.partition(), *m.schema(), partition_view, *m.schema(), app_stats);
|
|
} else {
|
|
column_mapping cm = mv.mapping();
|
|
converting_mutation_partition_applier v(cm, *m.schema(), m.partition());
|
|
auto partition_view = mutation_partition_view::from_view(mv.partition());
|
|
co_await partition_view.accept_gently(cm, v);
|
|
}
|
|
co_return m;
|
|
}
|
|
|
|
future<canonical_mutation> make_canonical_mutation_gently(const mutation& m)
|
|
{
|
|
mutation_partition_serializer part_ser(*m.schema(), m.partition());
|
|
|
|
canonical_mutation res;
|
|
ser::writer_of_canonical_mutation<bytes_ostream> wr(res.representation());
|
|
auto w = co_await std::move(wr).write_table_id(m.schema()->id())
|
|
.write_schema_version(m.schema()->version())
|
|
.write_key(m.key())
|
|
.write_mapping(m.schema()->get_column_mapping())
|
|
.partition_gently([&] (auto wr) {
|
|
return part_ser.write_gently(std::move(wr));
|
|
});
|
|
w.end_canonical_mutation();
|
|
co_return res;
|
|
}
|
|
|
|
future<frozen_mutation>
|
|
freeze_gently(const mutation& m) {
|
|
auto fm = frozen_mutation(m.key());
|
|
mutation_partition_serializer part_ser(*m.schema(), m.partition());
|
|
|
|
ser::writer_of_mutation<bytes_ostream> wom(fm.representation());
|
|
auto wr = co_await std::move(wom).write_table_id(m.schema()->id())
|
|
.write_schema_version(m.schema()->version())
|
|
.write_key(m.key())
|
|
.partition_gently([&] (auto wr) {
|
|
return part_ser.write_gently(std::move(wr));
|
|
});
|
|
wr.end_mutation();
|
|
fm.representation().reduce_chunk_count();
|
|
co_return fm;
|
|
}
|
|
|
|
future<mutation>
|
|
unfreeze_gently(const frozen_mutation& fm, schema_ptr schema) {
|
|
check_schema_version(fm.schema_version(), *schema);
|
|
mutation m(schema, fm.key());
|
|
partition_builder b(*schema, m.partition());
|
|
try {
|
|
co_await fm.partition().accept_gently(*schema, b);
|
|
} catch (...) {
|
|
std::throw_with_nested(std::runtime_error(format(
|
|
"frozen_mutation::unfreeze_gently(): failed unfreezing mutation {} of {}.{}", fm.key(), schema->ks_name(), schema->cf_name())));
|
|
}
|
|
co_return m;
|
|
}
|
|
|
|
future<utils::chunked_vector<mutation>> unfreeze_gently(const utils::chunked_vector<frozen_mutation>& muts) {
|
|
utils::chunked_vector<mutation> result;
|
|
result.reserve(muts.size());
|
|
for (auto& fm : muts) {
|
|
result.push_back(co_await unfreeze_gently(fm, local_schema_registry().get(fm.schema_version())));
|
|
}
|
|
co_return result;
|
|
}
|