mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-08-18 13:17:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: apply maintenance script defaults in gRPC handler

Browse Source 
The gRPC handler for GetMasterConfiguration read maintenance scripts
from viper without calling SetDefault, relying on startAdminScripts
having run first. If the admin server calls GetMasterConfiguration
before startAdminScripts sets the defaults, viper returns empty
strings and the seeding is silently skipped.

Apply SetDefault in the gRPC handler itself so it is self-contained.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Chris Lu
2026-03-04 21:43:55 -08:00
co-authored by Claude Opus 4.6
parent 4b2a231913
commit 068a506330
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/server/master_grpc_server.go
+4
View File
@@ -456,7 +456,11 @@ func (ms *MasterServer) GetMasterConfiguration(ctx context.Context, req *master_
leader, _ := ms.Topo.Leader()
// MIGRATION: expose maintenance scripts for admin server seeding. Remove after March 2027.
// Apply defaults here rather than relying on startAdminScripts having called SetDefault,
// since this gRPC handler can be reached before startAdminScripts runs.
v := util.GetViper()
v.SetDefault("master.maintenance.scripts", maintenance.DefaultMasterMaintenanceScripts)
v.SetDefault("master.maintenance.sleep_minutes", maintenance.DefaultMaintenanceSleepMinutes)
maintenanceScripts := v.GetString("master.maintenance.scripts")
maintenanceSleepMinutes := v.GetInt("master.maintenance.sleep_minutes")
if maintenanceSleepMinutes <= 0 {