Change bucket creation errors from skip to fatal

Tests should fail, not skip, when bucket creation fails. This ensures
that credential mismatches and other configuration issues are caught
rather than silently skipped.
This commit is contained in:
Chris Lu
2025-12-26 18:13:33 -08:00
parent 67f1ad7db0
commit 096072ca60

View File

@@ -35,7 +35,7 @@ func TestS3VolumeEncryptionRoundtrip(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket (server may not be running): %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)
@@ -127,7 +127,7 @@ func TestS3VolumeEncryptionMultiChunk(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket: %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)
@@ -223,7 +223,7 @@ func TestS3VolumeEncryptionMultiChunkRangeRead(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket: %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)
@@ -347,7 +347,7 @@ func TestS3VolumeEncryptionCopy(t *testing.T) {
Bucket: aws.String(bucket),
})
if err != nil {
t.Skipf("Skipping test - could not create bucket: %v", err)
t.Fatalf("Failed to create bucket: %v", err)
}
defer cleanupBucket(t, svc, bucket)