mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-08-20 22:27:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(s3/lifecycle): backdate both versions for NoncurrentDays clock

Browse Source 
Per codex review: NoncurrentDays is clocked from the SUCCESSOR
version's mtime (when the displaced version became noncurrent), not
from the displaced version's own mtime. Backdating only v1 left the
clock (v2's mtime) at "now" and the rule never fired — the test was
wrong, not the production path.

Backdate v1=31d and v2=30d so v1 sits past the 1-day threshold
relative to v2, the noncurrent rule fires, and v2 stays current.
This commit is contained in:
Chris Lu
2026-05-09 23:07:33 -07:00
parent 470339aa21
commit 155600829a
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/s3/lifecycle/s3_lifecycle_versioning_test.go
+7 -2
View File
@@ -200,8 +200,13 @@ func TestLifecycleNoncurrentVersionExpiration(t *testing.T) {
v2 := aws.ToString(put2.VersionId)
require.NotEqual(t, v1, v2)
// Age the noncurrent (v1) past the 1-day threshold.
backdateVersionedMtime(t, fc, bucket, key, v1, 30)
// NoncurrentDays is clocked from the SUCCESSOR's mtime — i.e. when
// the version became noncurrent — not from the displaced version's
// own mtime. Backdating only v1 leaves the noncurrent clock (v2's
// mtime) at "now" and the rule never fires. Age both with v1 older
// than v2 so the ordering is realistic.
backdateVersionedMtime(t, fc, bucket, key, v1, 31)
backdateVersionedMtime(t, fc, bucket, key, v2, 30)
out := runLifecycleShard(t)
t.Logf("shell output:\n%s", out)