mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-09-19 14:34:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: rename rebuild test to match actual path, use t.Skipf for V1 catch-up limitation

Browse Source 
HIGH: renamed TestP2_RebuildClosure_FullBase_OneChain → TestP2_RebuildClosure_OneChain.
Log now shows actual source (snapshot_tail or full_base) from plan, not hardcoded claim.

MED: catch-up test uses t.Skipf when V1 interim prevents OutcomeCatchUp.
No longer silently passes — explicitly reports the V1 limitation as a skip.
One-chain wiring exists and would be exercised when planner yields CatchUp.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
pingqiu
2026-03-31 15:17:34 -07:00
co-authored by Claude Opus 4.6
parent 8b1b6ec1c0
commit 1c178c0853
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/storage/blockvol/v2bridge/execution_chain_test.go
+9 -9
View File
@@ -110,20 +110,19 @@ func TestP2_CatchUpClosure_OneChain(t *testing.T) {
}
t.Log("catch-up: ONE CHAIN proven: plan → CatchUpExecutor → complete → InSync → pins released")
} else if plan.Outcome == engine.OutcomeZeroGap {
// V1 interim: committed = checkpoint. If replica at committed-1 is still
// within the tail, it's CatchUp. If not, it's ZeroGap or NeedsRebuild.
t.Logf("catch-up: V1 interim → %s (replica=%d committed=%d tail=%d)",
plan.Outcome, replicaLSN, state.CommittedLSN, state.WALTailLSN)
t.Log("catch-up: V1 interim prevents engine-triggered CatchUp when committed=tail")
} else {
t.Logf("catch-up: outcome=%s", plan.Outcome)
// V1 interim: CommittedLSN = TailLSN after flush.
// No gap between tail and committed → OutcomeCatchUp structurally unreachable.
// This is a known V1 limitation, NOT a test failure.
t.Skipf("catch-up: V1 interim → %s (replica=%d committed=%d tail=%d). "+
"One-chain wiring exists but V1 model prevents OutcomeCatchUp when committed=tail.",
plan.Outcome, replicaLSN, state.CommittedLSN, state.WALTailLSN)
}
}
// --- ONE CHAIN: Full-base rebuild closure ---
func TestP2_RebuildClosure_FullBase_OneChain(t *testing.T) {
func TestP2_RebuildClosure_OneChain(t *testing.T) {
driver, ca, reader, executor, pinner := setupChainTest(t)
vol := reader.vol
@@ -175,7 +174,8 @@ func TestP2_RebuildClosure_FullBase_OneChain(t *testing.T) {
t.Fatalf("rebuild: %d pins leaked", pinner.ActiveHoldCount())
}
t.Logf("rebuild: ONE CHAIN proven: plan → RebuildExecutor → TransferFullBase → complete → InSync → pins released")
t.Logf("rebuild: ONE CHAIN proven: plan(source=%s) → RebuildExecutor(IO=v2bridge) → complete → InSync → pins released",
rebuildPlan.RebuildSource)
}
// --- Cleanup: cancel releases all resources ---