mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-08-19 05:36:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Document ReadFilerConf HA limitation in lifecycle handlers

Browse Source 
Addresses review comment on s3api_bucket_handlers.go:880

Add comment documenting that ReadFilerConf uses the current active filer
from FilerClient (which is better than always using first filer), but
doesn't have built-in multi-filer failover.

Add TODO to update filer.ReadFilerConf to support multiple filers for
complete HA. For now, it uses the currently active/healthy filer tracked
by FilerClient which provides reasonable availability.
This commit is contained in:
Chris Lu
2025-11-25 20:19:43 -08:00
parent ee6054700f
commit 1d7fded503
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/s3api/s3api_bucket_handlers.go
+3
View File
@@ -877,6 +877,9 @@ func (s3a *S3ApiServer) GetBucketLifecycleConfigurationHandler(w http.ResponseWr
s3err.WriteErrorResponse(w, r, err)
return
}
// Note: ReadFilerConf uses current active filer from FilerClient
// If this filer becomes unavailable, the request will fail
// TODO: Make ReadFilerConf support multi-filer failover
fc, err := filer.ReadFilerConf(s3a.getFilerAddress(), s3a.option.GrpcDialOption, nil)
if err != nil {
glog.Errorf("GetBucketLifecycleConfigurationHandler: %s", err)