volume server: fill in ModifiedAtSecond on the /status volume list (#10351)

Only the heartbeat path read the .dat mtime; collectStatForOneVolume left
the field at 0, so /status consumers could not tell how long a volume had
been idle.
This commit is contained in:
Chris Lu
2026-07-16 15:18:38 -07:00
committed by GitHub
parent 267f595660
commit 1f8d0a9ccf
2 changed files with 36 additions and 0 deletions
+5
View File
@@ -389,6 +389,11 @@ func collectStatForOneVolume(vid needle.VolumeId, v *Volume) (s *VolumeInfo) {
s.DeleteCount = v.nm.DeletedCount()
s.DeletedByteCount = v.nm.DeletedSize()
s.Size = v.nm.ContentSize()
if v.DataBackend != nil {
if _, modTime, e := v.DataBackend.GetStat(); e == nil {
s.ModifiedAtSecond = modTime.Unix()
}
}
return
}
+31
View File
@@ -0,0 +1,31 @@
package storage
import (
"testing"
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
"github.com/seaweedfs/seaweedfs/weed/storage/types"
)
// The /status handler builds VolumeInfo via collectStatForOneVolume, which
// used to leave ModifiedAtSecond at 0; only the heartbeat path filled it in.
func TestCollectStatForOneVolumeModifiedAtSecond(t *testing.T) {
dir := t.TempDir()
v, err := NewVolume(dir, dir, "", 1, NeedleMapInMemory, &super_block.ReplicaPlacement{}, &needle.TTL{}, 0, needle.GetCurrentVersion(), 0, 0)
if err != nil {
t.Fatalf("create volume: %v", err)
}
defer v.Close()
v.location = &DiskLocation{Directory: dir, DiskType: types.HardDriveType}
if _, _, _, err := v.writeNeedle2(newRandomNeedle(1), true, false); err != nil {
t.Fatalf("write: %v", err)
}
s := collectStatForOneVolume(v.Id, v)
if s.ModifiedAtSecond <= 0 {
t.Fatalf("ModifiedAtSecond = %d, want > 0", s.ModifiedAtSecond)
}
}