mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-05-22 17:51:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(s3api): look up NewUser by name in CreateAccessKey collision test

Browse Source 
The memory credential store backs LoadConfiguration with a map, so the
identity order is not stable across a save/load round trip. Indexing
Identities[1] intermittently pointed at the owner identity and produced
a spurious credential leak.
This commit is contained in:
Chris Lu
2026-04-23 11:09:17 -07:00
parent 1a7ab2ea82
commit 34b236acfa
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
weed/s3api/s3api_embedded_iam_test.go
View File

@@ -1081,8 +1081,18 @@ func TestEmbeddedIamCreateAccessKeyRejectsCollision(t *testing.T) {
assert.Contains(t, rr.Body.String(), "already in use")
assert.NotContains(t, rr.Body.String(), ownerName, "should not leak owner name")
// Verify no credentials were added to NewUser
assert.Len(t, api.mockConfig.Identities[1].Credentials, 0)
// Verify no credentials were added to NewUser. Look up by name because the
// memory store backs LoadConfiguration with a map, so Identities order is
// not stable across a save/load round trip.
var newUser *iam_pb.Identity
for _, ident := range api.mockConfig.Identities {
if ident.Name == "NewUser" {
newUser = ident
break
}
}
require.NotNil(t, newUser, "NewUser identity should still exist")
assert.Len(t, newUser.Credentials, 0)
}
// TestEmbeddedIamCreateAccessKeyRejectsPartialSupply tests that supplying only