mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-08-21 22:56:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add nil check for RetainedHistory in sender APIs

Browse Source 
RecordHandshakeFromHistory and SelectRebuildFromHistory now
return an error instead of panicking on nil history input.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
pingqiu
2026-03-29 23:57:19 -07:00
co-authored by Claude Opus 4.6
parent cc8c529962
commit 4d06622c01
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sw-block/engine/replication/sender.go
+6
View File
@@ -272,6 +272,9 @@ func (s *Sender) RecordHandshakeWithOutcome(sessionID uint64, result HandshakeRe
// preferred engine-level API — it ensures recovery decisions are backed
// by actual retention state, not caller-supplied values.
func (s *Sender) RecordHandshakeFromHistory(sessionID uint64, replicaFlushedLSN uint64, history *RetainedHistory) (RecoveryOutcome, *RecoverabilityProof, error) {
if history == nil {
return OutcomeNeedsRebuild, nil, fmt.Errorf("nil RetainedHistory")
}
proof := history.ProveRecoverability(replicaFlushedLSN)
hr := history.MakeHandshakeResult(replicaFlushedLSN)
outcome, err := s.RecordHandshakeWithOutcome(sessionID, hr)
@@ -283,6 +286,9 @@ func (s *Sender) RecordHandshakeFromHistory(sessionID uint64, replicaFlushedLSN
// the rebuild-source decision accounts for both checkpoint trust AND
// tail replayability.
func (s *Sender) SelectRebuildFromHistory(sessionID uint64, history *RetainedHistory) error {
if history == nil {
return fmt.Errorf("nil RetainedHistory")
}
source, snapLSN := history.RebuildSourceDecision()
valid := source == RebuildSnapshotTail
return s.SelectRebuildSource(sessionID, snapLSN, valid, history.CommittedLSN)