fix(util): ignore comment only sql input (#9933)

* fix(util): ignore comment only sql input

Problem: sqlutil.SplitStatements strips SQL comments while scanning, but when no statements remain it falls back to returning the original query. Inputs that contain only comments are therefore reported as executable SQL statements.

Root cause: The no-statements fallback did not distinguish a real single statement from input that had been fully removed by comment filtering.

Fix: Remove the original-query fallback and return an explicit empty slice when scanning produces no statements.

Reproduction: env GOCACHE=/private/tmp/seaweedfs-go-cache go test ./weed/util/sqlutil -run TestSplitStatements -count=1 failed before the fix because comment-only inputs returned the comment text as a statement.

Validation: gofmt -w weed/util/sqlutil/splitter.go weed/util/sqlutil/splitter_test.go; env GOCACHE=/private/tmp/seaweedfs-go-cache go test ./weed/util/sqlutil -run TestSplitStatements -count=1; env GOCACHE=/private/tmp/seaweedfs-go-cache go test ./weed/util/sqlutil -count=1; git diff --check; git diff --cached --check.

Duplicate check: Searched /private/tmp/seaweedfs-codex0610-old-branch-index.tsv and existing tests for sqlutil, SplitStatements, comments, and comment-only. Old PostgreSQL query branches cover malformed wire frames and SQL engine numeric parsing, not comment-only statement splitting.

Co-authored-by: Codex <noreply@openai.com>

* Update weed/util/sqlutil/splitter.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This commit is contained in:
7y-9
2026-06-12 10:10:27 -07:00
committed by GitHub
co-authored by Codex gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
parent 0345658ea8
commit 5468707289
2 changed files with 11 additions and 3 deletions
+1 -3
View File
@@ -133,10 +133,8 @@ func SplitStatements(query string) []string {
}
}
// If no statements found, return the original query as a single statement
if len(statements) == 0 {
return []string{strings.TrimSpace(strings.TrimSuffix(strings.TrimSpace(query), ";"))}
return []string{}
}
return statements
}
+10
View File
@@ -96,6 +96,16 @@ func TestSplitStatements(t *testing.T) {
input: " \n\t ",
expected: []string{},
},
{
name: "Only single line comment",
input: "-- just a comment",
expected: []string{},
},
{
name: "Only multi-line comment",
input: "/* just a comment; with separator */",
expected: []string{},
},
}
for _, tt := range tests {