mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-08-15 11:47:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

debug: Add request routing and control plane logging

Browse Source 
CRITICAL FINDING: ListOffsets (apiKey=2) is DROPPED before routing!

Evidence:
1. REQUEST LOOP logs show apiKey=2 detected
2. REQUEST ROUTING logs show apiKey=18,3,19,60,22,32 but NO apiKey=2!
3. Requests are dropped between request parsing and routing decision

This means the filter/drop happens in:
- Lines 980-1050 in handler.go (between REQUEST LOOP and REQUEST QUEUE)
- Likely a validation check or explicit filtering

ListOffsets is being silently dropped at the request parsing level,
never reaching the routing logic that would send it to control plane.

Next: Search for explicit filtering or drop logic for apiKey=2 in
the request parsing section (lines 980-1050).
This commit is contained in:
chrislu
2025-10-16 15:54:49 -07:00
parent cc16e42162
commit 920e7c6b41
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/mq/kafka/protocol/handler.go
+11
View File
@@ -643,6 +643,9 @@ func (h *Handler) HandleConn(ctx context.Context, conn net.Conn) error {
// Channel closed, exit
return
}
if req.apiKey == 2 { // ListOffsets
glog.Warningf("🟡 CONTROL PLANE: Received ListOffsets (apiKey=2), correlationID=%d", req.correlationID)
}
glog.V(4).Infof("[%s] Control plane processing correlation=%d, apiKey=%d", connectionID, req.correlationID, req.apiKey)
// Wrap request processing with panic recovery to prevent deadlocks
@@ -656,7 +659,13 @@ func (h *Handler) HandleConn(ctx context.Context, conn net.Conn) error {
err = fmt.Errorf("internal server error: panic in request handler: %v", r)
}
}()
if req.apiKey == 2 { // ListOffsets
glog.Warningf("🟡 CONTROL PLANE: Calling processRequestSync for ListOffsets, correlationID=%d", req.correlationID)
}
response, err = h.processRequestSync(req)
if req.apiKey == 2 { // ListOffsets
glog.Warningf("🟡 CONTROL PLANE: processRequestSync returned for ListOffsets, correlationID=%d, err=%v", req.correlationID, err)
}
}()
glog.V(4).Infof("[%s] Control plane completed correlation=%d, sending to responseChan", connectionID, req.correlationID)
@@ -1050,8 +1059,10 @@ func (h *Handler) HandleConn(ctx context.Context, conn net.Conn) error {
var targetChan chan *kafkaRequest
if isDataPlaneAPI(apiKey) {
targetChan = dataChan
glog.Warningf("🔴 REQUEST ROUTING: apiKey=%d routed to DATA plane", apiKey)
} else {
targetChan = controlChan
glog.Warningf("🔴 REQUEST ROUTING: apiKey=%d routed to CONTROL plane", apiKey)
}
// Only add to correlation queue AFTER successful channel send