mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-08-16 12:16:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mini): raise admin readiness timeout to 2 minutes (#9329)

Browse Source 
The 30-second ceiling on waitForAdminServerReady was too tight on busy
CI runners. master + filer + volume + admin all start in parallel on a
shared worker, and S3 Policy Shell Integration Tests has been flaking
across multiple PRs with "admin server did not become ready... after
60 attempts" even though the server still comes up within a minute or
two. Two minutes (240 attempts at 500ms) leaves headroom for runner
contention without being absurd in a local-dev run.
This commit is contained in:
Chris Lu
2026-05-05 07:59:25 -07:00
committed by GitHub
parent 22ebe9feb0
commit 95560076e6
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
weed/command/mini.go
+6 -1
View File
@@ -1275,7 +1275,12 @@ func startMiniAdminWithWorker(allServicesReady chan struct{}) {
// waitForAdminServerReady pings the admin server HTTP endpoint to check if it's ready
func waitForAdminServerReady(adminAddr string) error {
healthAddr := getHealthCheckAddr(fmt.Sprintf("%s/health", adminAddr))
maxAttempts := 60 // 60 * 500ms = 30 seconds max wait
// 240 * 500ms = 120 seconds max wait. The previous 30-second ceiling was
// too tight on busy CI runners where master + filer + volume + admin all
// initialise on a shared worker — the S3 Policy Shell Integration Tests
// flaked regularly even though the admin server still came up within a
// minute or two. Two minutes leaves headroom without being absurd locally.
maxAttempts := 240
attempt := 0
client := &http.Client{
Timeout: 1 * time.Second,