mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-05-17 15:21:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: only log endpoint_changed when endpoint actually changed

Browse Source 
ProcessAssignment now compares pre/post endpoint state before
logging session_invalidated with "endpoint_changed" reason.
Normal session supersede (same endpoint, assignment_intent) no
longer mislabeled as endpoint change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
pingqiu
2026-03-30 08:10:35 -07:00
parent 5cdee4a011
commit adaff8ddb3
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
sw-block/engine/replication/orchestrator.go
View File

@@ -28,10 +28,11 @@ func NewRecoveryOrchestrator() *RecoveryOrchestrator {
// ProcessAssignment applies an assignment intent and logs the result.
// Detects endpoint-change invalidations automatically.
func (o *RecoveryOrchestrator) ProcessAssignment(intent AssignmentIntent) AssignmentResult {
// Snapshot pre-assignment session state for invalidation detection.
// Snapshot pre-assignment state for invalidation detection.
type preState struct {
hadSession bool
sessionID uint64
endpoint Endpoint
}
pre := map[string]preState{}
for _, ra := range intent.Replicas {
@@ -39,6 +40,7 @@ func (o *RecoveryOrchestrator) ProcessAssignment(intent AssignmentIntent) Assign
pre[ra.ReplicaID] = preState{
hadSession: s.HasActiveSession(),
sessionID: s.SessionID(),
endpoint: s.Endpoint(),
}
}
}
@@ -52,12 +54,12 @@ func (o *RecoveryOrchestrator) ProcessAssignment(intent AssignmentIntent) Assign
o.Log.Record(id, 0, "sender_removed", "")
}
// Detect endpoint-change invalidations: if the session ID changed
// (old session was invalidated and possibly replaced), log the old one.
// Detect endpoint-change invalidations: only log "endpoint_changed" when
// the endpoint actually changed, not on normal session supersede.
for id, p := range pre {
if p.hadSession {
s := o.Registry.Sender(id)
if s != nil && s.SessionID() != p.sessionID {
if s != nil && s.SessionID() != p.sessionID && s.Endpoint().Changed(p.endpoint) {
o.Log.Record(id, p.sessionID, "session_invalidated", "endpoint_changed")
}
}