notification: name the webhook target in failure and dead letter logs

Every target dead-letters to the same topic, so without the name there
is no way to tell which endpoint failed or needs a replay.
This commit is contained in:
Devin
2026-10-21 15:08:26 -07:00
parent c872298c8b
commit cff6fd1f4c
+4 -2
View File
@@ -318,7 +318,7 @@ func (t *target) handleWebhook(msg *message.Message) error {
}
if err := t.client.sendMessage(webhookMsg); err != nil {
glog.Errorf("failed to send message to webhook %s: %v", webhookMsg.Key, err)
glog.Errorf("webhook target %q failed to send message for %s: %v", t.name, webhookMsg.Key, err)
return err
}
@@ -344,10 +344,12 @@ func (w *Queue) logDeadLetterMessages() error {
continue
}
key := "unknown"
targetName := ""
if msg.Metadata != nil {
if keyValue, exists := msg.Metadata["key"]; exists {
key = keyValue
}
targetName = msg.Metadata["target"]
}
payload := ""
if msg.Payload != nil {
@@ -358,7 +360,7 @@ func (w *Queue) logDeadLetterMessages() error {
payload = n.String()
}
}
glog.Errorf("received dead letter message: %s, key: %s", payload, key)
glog.Errorf("received dead letter message: %s, key: %s, target: %s", payload, key, targetName)
case <-w.ctx.Done():
return
}