mirrors/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2026-05-29 21:20:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

de-support alter table and drop table

Browse Source
This commit is contained in:
chrislu
2025-09-02 17:23:46 -07:00
parent 8e15fdf2c7
commit d29f54e0be
2 changed files with 7 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
weed/command/sql.go
View File

@@ -552,7 +552,7 @@ QUERY ANALYSIS:
DDL OPERATIONS:
CREATE TABLE topic (field1 INT, field2 STRING); - Create topic
DROP TABLE table_name; - Delete topic
Note: ALTER TABLE and DROP TABLE are not supported
SPECIAL COMMANDS:
USE database_name; - Switch database context

54
weed/query/engine/engine.go
View File

@@ -411,16 +411,18 @@ func (e *SQLEngine) formatOptimization(opt string) string {
}
}
// executeDDLStatement handles CREATE, ALTER, DROP operations
// Assumption: These operations modify the underlying MQ topic structure
// executeDDLStatement handles CREATE operations only
// Note: ALTER TABLE and DROP TABLE are not supported to protect topic data
func (e *SQLEngine) executeDDLStatement(ctx context.Context, stmt *sqlparser.DDL) (*QueryResult, error) {
switch stmt.Action {
case sqlparser.CreateStr:
return e.createTable(ctx, stmt)
case sqlparser.AlterStr:
return e.alterTable(ctx, stmt)
err := fmt.Errorf("ALTER TABLE is not supported")
return &QueryResult{Error: err}, err
case sqlparser.DropStr:
return e.dropTable(ctx, stmt)
err := fmt.Errorf("DROP TABLE is not supported")
return &QueryResult{Error: err}, err
default:
err := fmt.Errorf("unsupported DDL action: %s", stmt.Action)
return &QueryResult{Error: err}, err
@@ -1399,50 +1401,6 @@ func (e *SQLEngine) createTable(ctx context.Context, stmt *sqlparser.DDL) (*Quer
return result, nil
}
func (e *SQLEngine) alterTable(ctx context.Context, stmt *sqlparser.DDL) (*QueryResult, error) {
// TODO: Implement table alteration
// This will modify the MQ topic schema with versioning
err := fmt.Errorf("ALTER TABLE not yet implemented")
return &QueryResult{Error: err}, err
}
func (e *SQLEngine) dropTable(ctx context.Context, stmt *sqlparser.DDL) (*QueryResult, error) {
// Parse DROP TABLE statement
// Assumption: Table name is in stmt.NewName for DROP operations
tableName := stmt.NewName.Name.String()
database := ""
// Check if database is specified in table name
if stmt.NewName.Qualifier.String() != "" {
database = stmt.NewName.Qualifier.String()
} else {
// Use current database context or default
database = e.catalog.GetCurrentDatabase()
if database == "" {
database = "default"
}
}
// Delete the topic via broker
err := e.catalog.brokerClient.DeleteTopic(ctx, database, tableName)
if err != nil {
return &QueryResult{Error: err}, err
}
// Remove from catalog cache
// TODO: Implement catalog cache removal
// Return success result
result := &QueryResult{
Columns: []string{"Result"},
Rows: [][]sqltypes.Value{
{sqltypes.NewVarChar(fmt.Sprintf("Table '%s.%s' dropped successfully", database, tableName))},
},
}
return result, nil
}
// ExecutionPlanBuilder handles building execution plans for queries
type ExecutionPlanBuilder struct {
engine *SQLEngine