chrislu
eaaef569ce
fixes
...
✅ Return 409 (Conflict) with InvalidBucketState for bucket-level object lock configuration operations on buckets without object lock enabled
✅ Allow increasing retention periods and overriding retention with same/later dates
✅ Only block decreasing retention periods without proper bypass permissions
✅ Handle all object lock validation errors consistently with proper error codes
2025-07-18 16:11:14 -07:00
chrislu
1807f4e94d
fixes
...
✅ Return MalformedXML when both Days and Years are specified in the same retention configuration
✅ Return 400 (Bad Request) with InvalidRequest when object lock operations are attempted on buckets without object lock enabled
✅ Handle all object lock validation errors consistently with proper error codes
2025-07-18 16:03:06 -07:00
chrislu
7203c78e4d
constants and fixes
...
✅ Return InvalidRetentionPeriod for invalid retention values (0 days, negative years)
✅ Return ObjectLockConfigurationNotFoundError when object lock configuration doesn't exist
✅ Handle all object lock validation errors consistently with proper error codes
2025-07-18 15:58:07 -07:00
chrislu
1bc503530a
fixes
...
With these final fixes, the s3-tests should now:
✅ Return MalformedXML for ObjectLockEnabled: 'Disabled'
✅ Return MalformedXML when both Days and Years are specified in retention configuration
✅ Return InvalidBucketState (409 Conflict) when trying to suspend versioning on buckets with object lock enabled
✅ Handle all object lock validation errors consistently with proper error codes
2025-07-18 15:52:28 -07:00
chrislu
9f88fd2ea5
fixes
...
With these comprehensive fixes, the s3-tests should now:
✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets
✅ Return InvalidRetentionPeriod for invalid retention periods
✅ Return MalformedXML for malformed retention configurations
✅ Include VersionId in response headers when available
✅ Return proper HTTP status codes for all error conditions
✅ Handle all object lock validation errors consistently
The workflow should now pass significantly more object lock tests, bringing SeaweedFS's S3 object lock implementation much closer to AWS S3 compatibility standards.
2025-07-18 15:45:15 -07:00
chrislu
0123abe49b
address test errors
...
With these fixes, the s3-tests should now:
✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets
✅ Return MalformedXML for invalid retention configurations
✅ Include VersionId in response headers when available
✅ Return proper HTTP status codes (403 Forbidden for retention mode changes)
✅ Handle all object lock validation errors consistently
2025-07-18 15:39:30 -07:00
chrislu
4b92f03b65
address test errors
2025-07-18 15:33:44 -07:00
chrislu
1e7a3c09d4
Update s3tests.conf
2025-07-18 15:23:05 -07:00
chrislu
ddb2105f00
Update s3tests.conf
2025-07-18 15:17:58 -07:00
chrislu
bbcd19f6c6
Update s3tests.yml
2025-07-18 15:14:09 -07:00
chrislu
fc2fcae543
Update s3tests.yml
2025-07-18 15:03:21 -07:00
chrislu
4801f641f1
install s3 tests
2025-07-18 15:01:25 -07:00
chrislu
770888df81
use marker
2025-07-18 14:54:15 -07:00
chrislu
1dfdd3c84d
Merge branch 'master' into fix-GetObjectLockConfigurationHandler
2025-07-18 14:47:36 -07:00
chrislu
b63855560a
add s3 tests for object lock and retention
2025-07-18 14:46:32 -07:00
chrislu
9f8e0257b0
read entry once
2025-07-18 14:39:02 -07:00
c6a22ce43a
Fix get object lock configuration handler ( #6996 )
...
* fix GetObjectLockConfigurationHandler
* cache and use bucket object lock config
* subscribe to bucket configuration changes
* increase bucket config cache TTL
* refactor
* Update weed/s3api/s3api_server.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* avoid duplidated work
* rename variable
* Update s3api_object_handlers_put.go
* fix routing
* admin ui and api handler are consistent now
* use fields instead of xml
* fix test
* address comments
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/s3/retention/s3_retention_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/object_lock_utils.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* change error style
* errorf
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-18 02:19:50 -07:00
chrislu
e53cd29eb2
errorf
2025-07-18 02:14:19 -07:00
chrislu
eeeb595346
change error style
2025-07-18 02:02:54 -07:00
678f962ded
Update weed/s3api/object_lock_utils.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-18 01:55:43 -07:00
a906358c59
Update test/s3/retention/s3_retention_test.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-18 01:54:36 -07:00
12f34f965f
Update weed/s3api/s3api_object_handlers_put.go
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-18 01:54:14 -07:00
chrislu
1db149ecc2
address comments
2025-07-18 01:49:44 -07:00
chrislu
59f8444a90
fix test
2025-07-18 01:42:03 -07:00
chrislu
bcc7a74a25
use fields instead of xml
2025-07-18 01:39:23 -07:00
chrislu
0d4eeb67be
admin ui and api handler are consistent now
2025-07-18 01:27:46 -07:00
chrislu
85e34df214
fix routing
2025-07-18 01:27:27 -07:00
chrislu
bb05e6cade
Update s3api_object_handlers_put.go
2025-07-18 00:53:20 -07:00
chrislu
bc46214445
rename variable
2025-07-18 00:52:38 -07:00
chrislu
121f6ef2c0
avoid duplidated work
2025-07-18 00:48:56 -07:00
22673fee76
Update weed/s3api/s3api_server.go
...
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2025-07-18 00:47:24 -07:00
chrislu
3fbab20b83
refactor
2025-07-18 00:34:16 -07:00
chrislu
b8cbe9b6b2
increase bucket config cache TTL
2025-07-18 00:26:58 -07:00
chrislu
8bb47f3c03
subscribe to bucket configuration changes
2025-07-18 00:25:18 -07:00
chrislu
7bec2ef94b
cache and use bucket object lock config
2025-07-18 00:19:47 -07:00
chrislu
f9cbed7ee1
fix GetObjectLockConfigurationHandler
2025-07-17 23:12:19 -07:00
Chris Lu and GitHub
69553e5ba6
convert error fromating to %w everywhere ( #6995 )
2025-07-16 23:39:27 -07:00
a524b4f485
Object locking need to persist the tags and set the headers ( #6994 )
...
* fix object locking read and write
No logic to include object lock metadata in HEAD/GET response headers
No logic to extract object lock metadata from PUT request headers
* add tests for object locking
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* refactor
* add unit tests
* sync versions
* Update s3_worm_integration_test.go
* fix legal hold values
* lint
* fix tests
* racing condition when enable versioning
* fix tests
* validate put object lock header
* allow check lock permissions for PUT
* default to OFF legal hold
* only set object lock headers for objects that are actually from object lock-enabled buckets
fix --- FAIL: TestAddObjectLockHeadersToResponse/Handle_entry_with_no_object_lock_metadata (0.00s)
* address comments
* fix tests
* purge
* fix
* refactoring
* address comment
* address comment
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers_put.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* avoid nil
* ensure locked objects cannot be overwritten
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-16 23:00:25 -07:00
chrislu
89706d36dc
less logs
2025-07-16 16:30:22 -07:00
chrislu
22465b8a96
unused
2025-07-16 16:30:07 -07:00
Andrei Kvapil and GitHub
39b574f3c5
[cosi] Update sidecar ( #6993 )
2025-07-16 13:51:30 -07:00
9982f91b4c
Add more fuse tests ( #6992 )
...
* add more tests
* move to new package
* add github action
* Update fuse-integration.yml
* Update fuse-integration.yml
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/fuse_integration/framework.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/fuse_integration/README.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* fix
* Update test/fuse_integration/concurrent_operations_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-16 12:43:08 -07:00
chrislu
215c5de579
minor
2025-07-16 09:22:25 -07:00
chrislu
12c9282042
avoid error overwriting
...
fix https://github.com/seaweedfs/seaweedfs/issues/6991
2025-07-16 09:15:50 -07:00
chrislu
bb81894078
Update .gitignore
2025-07-16 01:18:23 -07:00
dde1cf63c2
S3 Object Lock: ensure x-amz-bucket-object-lock-enabled header ( #6990 )
...
* ensure x-amz-bucket-object-lock-enabled header
* fix tests
* combine 2 metadata changes into one
* address comments
* Update s3api_bucket_handlers.go
* Update weed/s3api/s3api_bucket_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/s3/retention/object_lock_reproduce_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/s3/retention/object_lock_validation_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/s3/retention/s3_bucket_object_lock_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_bucket_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_bucket_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update test/s3/retention/s3_bucket_object_lock_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_bucket_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* package name
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-15 23:21:58 -07:00
chrislu
64c5dde2f3
support multiple masters
...
fix https://github.com/seaweedfs/seaweedfs/issues/6988
2025-07-15 10:51:07 -07:00
Ibrahim Konsowa and GitHub
d78aa3d2de
[Notifications] Improving webhook notifications ( #6965 )
...
* worker setup
* fix tests
* start worker
* graceful worker drain
* retry queue
* migrate queue to watermill
* adding filters and improvements
* add the event type to the webhook message
* eliminating redundant JSON serialization
* resolve review comments
* trigger actions
* fix tests
* typo fixes
* read max_backoff_seconds from config
* add more context to the dead letter
* close the http response on errors
* drain the http response body in case not empty
* eliminate exported typesπ
2025-07-15 10:49:37 -07:00
74f4e9ba5a
rewrite, simplify, avoid unused functions ( #6989 )
...
* adding cors support
* address some comments
* optimize matchesWildcard
* address comments
* fix for tests
* address comments
* address comments
* address comments
* path building
* refactor
* Update weed/s3api/s3api_bucket_config.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* address comment
Service-level responses need both Access-Control-Allow-Methods and Access-Control-Allow-Headers. After setting Access-Control-Allow-Origin and Access-Control-Expose-Headers, also set Access-Control-Allow-Methods: * and Access-Control-Allow-Headers: * so service endpoints satisfy CORS preflight requirements.
* Update weed/s3api/s3api_bucket_config.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* fix
* refactor
* Update weed/s3api/s3api_bucket_config.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_server.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* simplify
* add cors tests
* fix tests
* fix tests
* remove unused functions
* fix tests
* simplify
* address comments
* fix
* Update weed/s3api/auth_signature_v4.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Apply suggestion from @Copilot
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* rename variable
* Revert "Apply suggestion from @Copilot"
This reverts commit fce2d4e57e175728472+Copilot@users.noreply.github.com >
2025-07-15 10:11:49 -07:00
4b040e8a87
adding cors support ( #6987 )
...
* adding cors support
* address some comments
* optimize matchesWildcard
* address comments
* fix for tests
* address comments
* address comments
* address comments
* path building
* refactor
* Update weed/s3api/s3api_bucket_config.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* address comment
Service-level responses need both Access-Control-Allow-Methods and Access-Control-Allow-Headers. After setting Access-Control-Allow-Origin and Access-Control-Expose-Headers, also set Access-Control-Allow-Methods: * and Access-Control-Allow-Headers: * so service endpoints satisfy CORS preflight requirements.
* Update weed/s3api/s3api_bucket_config.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* fix
* refactor
* Update weed/s3api/s3api_bucket_config.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_object_handlers.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* Update weed/s3api/s3api_server.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
* simplify
* add cors tests
* fix tests
* fix tests
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-07-15 00:23:54 -07:00
chrislu
Andrei KvapilandGitHub
Ibrahim KonsowaandGitHub