mirror of
https://github.com/seaweedfs/seaweedfs.git
synced 2026-08-17 20:57:27 +00:00
* s3: resolve a bucket owner recorded as an identity The admin UI and weed shell record a bucket's owner as an identity name in s3-identity-id and never write the account id the S3 API stores alongside it, so such a bucket looked unowned: its ACL owner fell back to the default admin account, and under the default BucketOwnerEnforced ownership every object uploaded to it was stamped with that account instead of the bucket owner. Resolve the identity to its account when no account id is recorded, in the one place both the bucket metadata and the bucket config derive the owner from. * s3: drop the recorded account when the bucket owner is reassigned Changing the owner of a bucket created through the S3 API left its old account id behind, and that outranks the identity when the owner is resolved, so the new owner never took effect for object ownership or the bucket ACL.
155 lines
4.5 KiB
Go
155 lines
4.5 KiB
Go
package shell
|
|
|
|
import (
|
|
"context"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/seaweedfs/seaweedfs/weed/util"
|
|
)
|
|
|
|
func init() {
|
|
Commands = append(Commands, &commandS3BucketOwner{})
|
|
}
|
|
|
|
type commandS3BucketOwner struct {
|
|
}
|
|
|
|
func (c *commandS3BucketOwner) Name() string {
|
|
return "s3.bucket.owner"
|
|
}
|
|
|
|
func (c *commandS3BucketOwner) Help() string {
|
|
return `view or change the owner of an S3 bucket
|
|
|
|
Example:
|
|
# View the current owner of a bucket
|
|
s3.bucket.owner -name <bucket_name>
|
|
|
|
# Set or change the owner of a bucket
|
|
s3.bucket.owner -name <bucket_name> -owner <identity_name>
|
|
|
|
# Remove the owner (make bucket admin-only)
|
|
s3.bucket.owner -name <bucket_name> -delete
|
|
|
|
The owner identity determines which S3 user can access the bucket.
|
|
Non-admin users can only access buckets they own. Admin users can
|
|
access all buckets regardless of ownership.
|
|
|
|
The -owner value should match the identity name configured in your
|
|
S3 IAM system (the "name" field in s3.json identities configuration).
|
|
`
|
|
}
|
|
|
|
func (c *commandS3BucketOwner) HasTag(CommandTag) bool {
|
|
return false
|
|
}
|
|
|
|
func (c *commandS3BucketOwner) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) {
|
|
|
|
bucketCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError)
|
|
bucketName := bucketCommand.String("name", "", "bucket name")
|
|
bucketOwner := bucketCommand.String("owner", "", "new bucket owner identity name")
|
|
deleteOwner := bucketCommand.Bool("delete", false, "remove the bucket owner (make admin-only)")
|
|
if err = bucketCommand.Parse(args); err != nil {
|
|
return nil
|
|
}
|
|
|
|
if *bucketName == "" {
|
|
return fmt.Errorf("empty bucket name")
|
|
}
|
|
|
|
// Trim whitespace from owner
|
|
owner := strings.TrimSpace(*bucketOwner)
|
|
|
|
// Validate flags: can't use both -owner and -delete
|
|
if owner != "" && *deleteOwner {
|
|
return fmt.Errorf("cannot use both -owner and -delete flags together")
|
|
}
|
|
|
|
err = commandEnv.WithFilerClient(false, func(client filer_pb.SeaweedFilerClient) error {
|
|
|
|
resp, err := client.GetFilerConfiguration(context.Background(), &filer_pb.GetFilerConfigurationRequest{})
|
|
if err != nil {
|
|
return fmt.Errorf("get filer configuration: %w", err)
|
|
}
|
|
filerBucketsPath := resp.DirBuckets
|
|
|
|
// Look up the bucket entry
|
|
lookupResp, err := client.LookupDirectoryEntry(context.Background(), &filer_pb.LookupDirectoryEntryRequest{
|
|
Directory: filerBucketsPath,
|
|
Name: *bucketName,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("lookup bucket %s: %w", *bucketName, err)
|
|
}
|
|
|
|
entry := lookupResp.Entry
|
|
|
|
// If -owner is provided, set the owner
|
|
if owner != "" {
|
|
if entry.Extended == nil {
|
|
entry.Extended = make(map[string][]byte)
|
|
}
|
|
entry.Extended[s3_constants.AmzIdentityId] = []byte(owner)
|
|
// The S3 API derives the owning account from this identity when no
|
|
// account id is recorded; a leftover one would keep the old owner.
|
|
delete(entry.Extended, s3_constants.ExtAmzOwnerKey)
|
|
fmt.Fprintf(writer, "Setting owner of bucket %s to: %s\n", *bucketName, owner)
|
|
|
|
// Update the entry
|
|
if _, err := client.UpdateEntry(context.Background(), &filer_pb.UpdateEntryRequest{
|
|
Directory: filerBucketsPath,
|
|
Entry: entry,
|
|
}); err != nil {
|
|
return fmt.Errorf("failed to update bucket: %w", err)
|
|
}
|
|
|
|
fmt.Fprintf(writer, "Bucket owner updated successfully.\n")
|
|
return nil
|
|
}
|
|
|
|
// If -delete is provided, remove the owner
|
|
if *deleteOwner {
|
|
if entry.Extended != nil {
|
|
delete(entry.Extended, s3_constants.AmzIdentityId)
|
|
delete(entry.Extended, s3_constants.ExtAmzOwnerKey)
|
|
}
|
|
fmt.Fprintf(writer, "Removing owner from bucket %s\n", *bucketName)
|
|
|
|
// Update the entry
|
|
if _, err := client.UpdateEntry(context.Background(), &filer_pb.UpdateEntryRequest{
|
|
Directory: filerBucketsPath,
|
|
Entry: entry,
|
|
}); err != nil {
|
|
return fmt.Errorf("failed to update bucket: %w", err)
|
|
}
|
|
|
|
fmt.Fprintf(writer, "Bucket owner removed. Bucket is now admin-only.\n")
|
|
return nil
|
|
}
|
|
|
|
// Display current owner (no flags provided)
|
|
fmt.Fprintf(writer, "Bucket: %s\n", *bucketName)
|
|
fmt.Fprintf(writer, "Path: %s\n", util.NewFullPath(filerBucketsPath, *bucketName))
|
|
|
|
if entry.Extended != nil {
|
|
if ownerBytes, ok := entry.Extended[s3_constants.AmzIdentityId]; ok && len(ownerBytes) > 0 {
|
|
fmt.Fprintf(writer, "Owner: %s\n", string(ownerBytes))
|
|
} else {
|
|
fmt.Fprintf(writer, "Owner: (none - admin access only)\n")
|
|
}
|
|
} else {
|
|
fmt.Fprintf(writer, "Owner: (none - admin access only)\n")
|
|
}
|
|
|
|
return nil
|
|
})
|
|
|
|
return err
|
|
}
|