mirrors/tar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(flush_read): Bugfix: the condition at line 714 included

Browse Source 
|| (status > 0 && !read_full_records_option)

which is grossly wrong, since even if new_volume() below succeeds,
the subsequent call to rmtread will overwrite the chunk of data
already read in the buffer and thus spoil everything.
This commit is contained in:
Sergey Poznyakoff
2004-02-29 10:15:45 +00:00
parent 8c1b242931
commit 37400fa94e
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/buffer.c
View File

@@ -310,7 +310,7 @@ open_archive (enum access_mode wanted_access)
}
else if (strcmp (archive_name_array[0], "-") == 0)
{
read_full_records_option = 1; /* could be a pipe, be safe */
read_full_records_option = true; /* could be a pipe, be safe */
if (verify_option)
FATAL_ERROR ((0, 0, _("Cannot verify stdin/stdout archive")));
@@ -408,8 +408,10 @@ open_archive (enum access_mode wanted_access)
else
strcpy (record_start->header.name, volume_label_option);
assign_string (&current_stat_info.file_name, record_start->header.name);
current_stat_info.had_trailing_slash = strip_trailing_slashes (current_stat_info.file_name);
assign_string (&current_stat_info.file_name,
record_start->header.name);
current_stat_info.had_trailing_slash =
strip_trailing_slashes (current_stat_info.file_name);
record_start->header.typeflag = GNUTYPE_VOLHDR;
TIME_TO_CHARS (start_time, record_start->header.mtime);
@@ -703,9 +705,14 @@ flush_read (void)
return;
}
/* The condition below used to include
|| (status > 0 && !read_full_records_option)
This is incorrect since even if new_volume() succeeds, the
subsequent call to rmtread will overwrite the chunk of data
already read in the buffer, so the processing will fail */
if ((status == 0
|| (status < 0 && errno == ENOSPC)
|| (status > 0 && !read_full_records_option))
|| (status < 0 && errno == ENOSPC))
&& multi_volume_option)
{
union block *cursor;