mirrors/tar
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pacify gcc -Wanalyzer-fd-use-without-check

Browse Source 
* src/system.c (sys_exec_setmtime_script):
Treat fds with more care.
This commit is contained in:
Paul Eggert
2023-08-21 12:52:14 -07:00
parent 8131ca7b26
commit bfee1d44a3
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/system.c
View File

@@ -963,15 +963,15 @@ sys_exec_setmtime_script (const char *script_name,
FATAL_ERROR ((0, errno, _("chdir failed")));
}
close (0);
close (1);
if (open (dev_null, O_RDONLY) == -1)
open_error (dev_null);
if (dup2 (p[1], 1) == -1)
FATAL_ERROR ((0, errno, _("dup2 failed")));
close (p[0]);
if (dup2 (p[1], STDOUT_FILENO) < 0)
FATAL_ERROR ((0, errno, _("dup2 failed")));
if (p[1] != STDOUT_FILENO)
close (p[1]);
close (STDIN_FILENO);
if (open (dev_null, O_RDONLY) != STDIN_FILENO)
open_error (dev_null);
priv_set_restore_linkdir ();
xexec (command);