Commit Graph

1643 Commits

Author SHA1 Message Date
Sergey Poznyakoff
225e690142 (sparse_scan_file): Fix another bug, introduced yesterday: Initialize
archive_file_size to 0. The variable keeps size of the file *as stored
in the archive*, not the size reported by stat.
2005-06-23 09:10:28 +00:00
Sergey Poznyakoff
c877b48d68 Updated 2005-06-23 08:27:41 +00:00
Sergey Poznyakoff
37d2462d7c (tar_sparse_init): Fix recent bugfixes: Initialize dumped_size to 0. 2005-06-23 08:27:22 +00:00
Paul Eggert
040b5ab5f9 A sweep of the sparse code prompted by a bug report by Jim Meyering.
* src/sparse.c: Include <inttostr.h>.
(struct tar_sparse_file): offset and dumped_size are off_t, not
size_t.  optab is now const *.
(dump_zeros): Return bool success flag, not off_t.
All callers changed.
Use a constant-zero buffer rather than clearing a buffer each time.
Don't mess up if write fails.
(dump_zeros, check_sparse_region):
Don't assume off_t is no wider than size_t.
(tar_sparse_init): Don't bother clearing a field that is already clear.
(zero_block_p): First arg is const *, not *.
(clear_block, SPARSES_INIT_COUNT): Remove.
(sparse_add_map): First arg is now struct start_stat_info *, not
struct tar_sparse_file *.  All callers changed.
Use x2nrealloc to check for size_t overflow.
(parse_scan_file): Cache commonly-used parts of file.
Use an auto buffer, not a static one.
Don't bother clearing the buffer; not needed.
Don't bother clearing items that are already clear.
(oldgnu_optab, star_optab, pax_optab): Now const.
(sparse_dump_region): Don't bother clearing the buffer before
reading into it; just clear the parts that aren't read into.
(sparse_dump_file): Clear the whole local variable 'file'.
(diff_buffer): Remove; now a local var.
(check_sparse_region): Don't bother clearing buffer before
reading into it.  Don't assume off_t is promoted to long.
(oldgnu_get_sparse_info, star_get_sparse_info):
Use an auto status, not static.
* src/tar.h (struct tar_stat_info): had_trailing_slash is
now bool, not int.
* src/xheader.c (sparse_offset_coder, sparse_numbytes_coder):
Rewrite to avoid cast.
(sparse_offset_decoder, sparse_numbytes_decoder):
Diagnose excess entries rather than crashing.
2005-06-23 06:55:01 +00:00
Paul Eggert
4f4a858eb6 * src/common.h (timespec_lt): Add a return type: bool. 2005-06-23 03:19:03 +00:00
Paul Eggert
d659cbaccd Carefully crafted invalid headers can cause buffer overrun.
Invalid header fields go undiagnosed.
Some valid time strings are ignored.

* NEWS: Better support for full-resolution time stamps.
The -v option now prints time stamps only to 1-minute resolution.
* gnulib.modules: Add utimens.
* lib/.cvsignore: Add imaxtostr.c, inttostr.c, inttostr.h,
offtostr.c, umaxtostr.c, utimens.c, utimens.h.  Remove paxconvert.c.
* lib/Makefile.tmpl (libtar_a_SOURCES): Remove paxconvert.c.
* lib/paxconvert.c: Remove; superseded by umaxtostr.c.
* po/POTFILES.in: Remove lib/paxconvert.c.  Add lib/xalloc-die.c,
lib/obstack.c.
* src/buffer.c (set_start_time, compute_duration, start_time):
Use gettime rather than rolling our own code.
* src/common.h (OLDGNU_NAME_FIELD_SIZE, MAXOCTAL11, MAXOCTAL7): Remove.
(newer_ctime_option): Remove.
(timespec_lt): New function.
(OLDER_STAT_TIME): Use it.
(string_to_chars): First arg is char const *, not char *.
(tartime): Time arg is now struct timespec.  New bool arg.
All callers changed.
(code_ns_fraction): New decl.
(sys_stat_nanoseconds): Remove decl.
(get_stat_atime, get_stat_ctime, get_stat_mtime): New functions.
(set_stat_atime, set_stat_ctime, set_stat_mtime): New functions.
* src/compare.c: Include utimens.h rather than rolling our own.
(diff_dir, diff_file, diff_link, diff_symlink, diff_special):
Prototype.
(diff_dumpdir, diff_multivol): Prototype.
(diff_file): Support higher-resolution time stamps.
* src/create.c: Include utimens.h rather than rolling our own.
(MAX_OCTAL_VAL): New macro.
(tar_copy_str, string_to_chars): Don't bother to zero-fill;
the destination is already zeroed.
(string_to_chars): First arg is char const *.
(start_private_header): Use MINOR_TO_CHARS, not MAJOR_TO_CHARS,
for minor device number.
(write_header_name, dump_hard_link, dump_file0):
Simplify test for old GNU format.
(start_header): Put in placeholders for uid, etc., even when
using extended headers, for benefit of older "tar" implementations.
Don't assume uintmax_t is wider than 32 bits.
Output extended header for mtime if needed.
(dump_regular_finish, dump_file0):
Support extended time stamp resolution.
* src/extract.c: Include utimens.h rather than rolling our own.
(check_time): Support extended time stamp resolution.
* src/list.c: Include <inttostr.h>.
(tartime): Use umaxtostr rather than stringify_uintmax_t_backwards.
* src/xheader.c: Include <inttostr.h>.
Do not include <xstrtol.h>.
(strtoimax) [!HAVE_DECL_STRTOIMAX && !defined strtoimax]: New decl.
(strtoumax) [!HAVE_DECL_STRTOUMAX && !defined strtoumax]: New decl.
(BILLION, LOG10_BILLION): New constants.
(to_decimal): Remove; superseded by inttostr.  All callers changed
to use umaxtostr.
(xheader_format_name): Don't assume pids and uintmax_t values
fit in 63 bytes (!) when printed.
(decode_record): Don't bother to check for ERANGE; an out of range
value must be treater than len_max anyway.
If the length is out of range, output it in the diagnostic.
(format_uintmax): Remove; all callers changed to use umaxtostr.
(xheader_print): Don't assume sizes can be printed in 99 bytes (!).
(out_of_range_header): New function.
(decode_time): Use it.
(code_time): Accept struct timespec, not time_t and unsigned long.
All callers changed.  Size sbuf properly, and remove unnecessary check.
Don't assume time stamps can fit in 199 bytes.
Handle negative time stamps.  Handle fractional time stamps
more consistently.  Don't output unnecessary trailing zeros.
(decode_time): Yield struct timespec, not time_t and unsigned long.
All callers changed.
Handle negative time stamps.  Truncate towards minus infinity
consistently.  Improve overflow checks, and output a better
diagnostic on overflow.
(code_num): Don't assume uintmax_t can be printed in 99 bytes (!).
(decode_num): New function, for better diagnostics.
(atime_coder, atime_decoder, gid_decoder, ctime_coder):
(ctime_decoder, mtime_coder, mtime_decoder, size_decoder):
(uid_decoder, sparse_size_decoder, sparse_numblocks_decoder):
(sparse_offset_decoder, sparse_numbytes_decoder):
Use decode_num, etc., instead of xstrtoumax, etc.

* src/xheader.c (sparse_numblocks_decoder): Remove unchecked use
of `calloc'.  Use xcalloc instead.
(decode_time, gid_decoder, size_decoder, uid_decoder):
(sparse_size_decoder, sparse_offset_decoder, sparse_numblocks_decoder):
Ensure that the result of calling xstrtoumax is no larger than
the maximum value for the target type.  Upon any failure, exit with
a diagnostic.
(sparse_numblocks_decoder): Avoid buffer overrun/heap corruption:
use x2nrealloc, rather than `n *= 2' and xrealloc(p, n,....
(decode_time): Rewrite to accept time strings like
1119018481.000000000.  Before, such strings were always ignored.
2005-06-22 06:24:39 +00:00
Sergey Poznyakoff
f6445e4ed6 Updated 2005-06-13 19:14:52 +00:00
Sergey Poznyakoff
3fe8fc3ef9 Add update.at 2005-06-13 19:11:43 +00:00
Sergey Poznyakoff
372ff169e7 New test 2005-06-13 19:10:56 +00:00
Sergey Poznyakoff
c6cde895e3 (dump_file0): Check for is_avoided_name() first. Fixes bug reported by Martin Lohmeier 2005-06-13 19:09:45 +00:00
Sergey Poznyakoff
28b44cc69c Updated 2005-06-13 12:54:45 +00:00
Sergey Poznyakoff
eb70fd51cb (AC_STRUCT_ST_BLKSIZE,AC_STRUCT_ST_BLOCKS): Removed. Handled by system.m4. 2005-06-13 12:53:25 +00:00
Paul Eggert
5c4ea58bd7 * src/names.c (excluded_name): excluded_filename ->
excluded_file_name, because the name was changed in gnulib.
2005-06-02 21:02:58 +00:00
Sergey Poznyakoff
85ad04d822 Updated 2005-05-30 15:15:25 +00:00
Sergey Poznyakoff
fb7b2f3645 (read_name_from_file,update_argv): Automatically detect nul-terminated list files. 2005-05-30 15:15:10 +00:00
Sergey Poznyakoff
ab03bd6a2c Updated 2005-05-30 13:38:21 +00:00
Sergey Poznyakoff
9d5fd390dc Bugfixes. 2005-05-27 12:03:39 +00:00
Sergey Poznyakoff
e5e43aa7a4 Updated 2005-05-26 12:51:18 +00:00
Sergey Poznyakoff
77e56f876d Document new backup scripts behavior 2005-05-26 12:50:43 +00:00
Sergey Poznyakoff
2c49c610be (mt_begin,mt_rewind,mt_offline,mt_status): Use $MT to invoke mt
(init_common): Set --rsh-command option for mt if TAPE_FILE is a
 remote archive.
2005-05-26 12:50:30 +00:00
Sergey Poznyakoff
ec89da307c Minor fixes 2005-05-26 12:50:11 +00:00
Sergey Poznyakoff
ee870c97b9 Updated 2005-05-21 23:13:38 +00:00
Sergey Poznyakoff
ca5e64504b (hash_string_hasher,hash_string_compare)
(hash_string_insert,hash_string_lookup,removed_prefixes_p)
(safer_name_suffix): Moved to paxutils
2005-05-21 23:11:26 +00:00
Sergey Poznyakoff
cc07b9e170 Include paxlib.h instead of paxerror.h
(safer_name_suffix,removed_prefixes_p): Removed. The functions are
imported from paxutils
2005-05-21 23:10:57 +00:00
Sergey Poznyakoff
f2c8b1dff3 Update invocations of safer_name_suffix() 2005-05-21 23:10:42 +00:00
Sergey Poznyakoff
9129c846e7 Add new paxutils files 2005-05-21 23:09:42 +00:00
Sergey Poznyakoff
df0913f3fe Updated 2005-05-21 23:09:16 +00:00
Sergey Poznyakoff
e20fdceb38 Updated 2005-05-19 15:35:14 +00:00
Sergey Poznyakoff
5c35fdb275 Remove defines and declarations imported from paxutils 2005-05-19 15:34:19 +00:00
Sergey Poznyakoff
113b619383 Add paxerror.c paxexit.c paxconvert.c 2005-05-19 15:33:45 +00:00
Sergey Poznyakoff
517205c31c (libtar_a_SOURCES): Add paxerror.c paxexit.c paxconvert.c 2005-05-19 15:33:17 +00:00
Sergey Poznyakoff
dfabe2397a Remove checking for LIB_SETSOCKOPT, it is handled by paxutils 2005-05-19 15:32:56 +00:00
Sergey Poznyakoff
8f1f0955cf (copy_files): Accept optional third argument: a prefix
to be appended to destination file names.
Import paxutils/paxlib files.
2005-05-19 15:32:38 +00:00
Paul Eggert
1672258959 * src/misc.c (remove_any_file): Fix typo in previous change. 2005-05-17 08:34:16 +00:00
Paul Eggert
c172481f41 (remove_any_file): Fix typo in previous change. 2005-05-17 08:34:03 +00:00
Paul Eggert
46f09016e8 Port to Solaris 10's treatment of unlinking directories.
* gnulib-modules: Add unlinkdir.
* lib/.cvsignore: Add unlinkdir.h, unlinkdir.c.
* src/common.h (we_are_root): Remove extern decl; it's now static.
* src/extract.c (we_are_root): Now static.
* src/misc.c: Include <unlinkdir.h>.
(remove_any_file): Use cannot_unlink_dir () rather than	we_are_root.
2005-05-15 06:23:49 +00:00
Paul Eggert
120e96c480 Update FSF postal mail address. 2005-05-15 03:59:08 +00:00
Sergey Poznyakoff
271ed97494 Updated 2005-05-12 15:46:40 +00:00
Sergey Poznyakoff
3ac99bc540 Updated 2005-05-12 15:46:18 +00:00
Sergey Poznyakoff
a33b37a9a3 Add truncate.at 2005-05-12 15:40:07 +00:00
Sergey Poznyakoff
c9365a1d09 New test case 2005-05-12 15:39:54 +00:00
Sergey Poznyakoff
8d064bb816 (file_newer_p): Return false if file does not exist 2005-05-12 15:39:34 +00:00
Sergey Poznyakoff
29c902bc49 (dump_regular_file): Correctly pad archive members that shrunk during archiving. Repored by Frank Heckenbach. 2005-05-12 15:39:21 +00:00
Sergey Poznyakoff
d78f85d61d (diff_file): diff_handle was not initialized 2005-05-12 15:39:02 +00:00
Sergey Poznyakoff
73be90ea0d (Genfile): New appendix 2005-05-12 15:38:48 +00:00
Sergey Poznyakoff
9adc789138 (tar_TEXINFOS): Add genfile.texi 2005-05-12 15:38:37 +00:00
Sergey Poznyakoff
cfe4eef5c2 Install files from paxutils/doc 2005-05-12 15:38:27 +00:00
Sergey Poznyakoff
0e61fd397f Updated 2005-05-12 15:38:19 +00:00
Paul Eggert
bb8dcc1e8c Update copyright. 2005-05-02 08:05:59 +00:00
Paul Eggert
87bd7f5d1c Update copyright. 2005-05-02 08:05:23 +00:00