mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-02-12 23:01:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

update comments on ensureextensions methods

Browse Source
This commit is contained in:
William Banfield
2022-05-13 16:37:12 -04:00
parent badd430a04
commit 1463a0e352
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
types/block.go
View File

@@ -769,6 +769,8 @@ func (ecs ExtendedCommitSig) ValidateBasic() error {
return nil
}
// EnsureExtensions validates that a vote extensions signature is present for
// this ExtendedCommitSig.
func (ecs ExtendedCommitSig) EnsureExtension() error {
if len(ecs.ExtensionSignature) == 0 {
return errors.New("vote extension signature is missing")
@@ -1054,9 +1056,8 @@ func (c *Commit) ToVoteSet(chainID string, vals *ValidatorSet) *VoteSet {
return voteSet
}
// TODO Comment
// this should probably also verify the signature
// probably want to change to just verify when present.
// EnsureExtensions validates that a vote extensions signature is present for
// every ExtendedCommitSig in the ExtendedCommit.
func (ec *ExtendedCommit) EnsureExtensions() error {
for idx, ecs := range ec.ExtendedSignatures {
if ecs.BlockIDFlag == BlockIDFlagAbsent {