mirror of
https://github.com/tendermint/tendermint.git
synced 2026-05-21 22:51:30 +00:00
remove TODO for prepare proposal
This commit is contained in:
@@ -433,9 +433,6 @@ func (app *Application) execPrepareTx(tx []byte) *types.ExecTxResult {
|
||||
// substPrepareTx subst all the preparetx in the blockdata
|
||||
// to null string(could be any arbitrary string).
|
||||
func (app *Application) substPrepareTx(blockData [][]byte) []*types.TxRecord {
|
||||
// TODO: this mechanism will change with the current spec of PrepareProposal
|
||||
// We now have a special type for marking a tx as changed
|
||||
|
||||
trs := make([]*types.TxRecord, len(blockData))
|
||||
for i, tx := range blockData {
|
||||
if isPrepareTx(tx) {
|
||||
|
||||
@@ -251,6 +251,9 @@ func (rpp *ResponsePrepareProposal) Validate(maxSizeBytes int64, otxs [][]byte)
|
||||
if !rpp.ModifiedTx {
|
||||
// This method currently only checks the validity of the TxRecords field.
|
||||
// If ModifiedTx is false, then we can ignore the validity of the TxRecords field.
|
||||
//
|
||||
// TODO: When implementing VoteExensions, AppSignedUpdates may be modified by the application
|
||||
// and this method should be updated to validate the AppSignedUpdates.
|
||||
return nil
|
||||
}
|
||||
|
||||
|
||||
@@ -429,7 +429,7 @@ func extendedCommitInfo(c abci.CommitInfo) abci.ExtendedCommitInfo {
|
||||
Validator: c.Votes[i].Validator,
|
||||
SignedLastBlock: c.Votes[i].SignedLastBlock,
|
||||
/*
|
||||
TODO: Include extended vote information once vote extension vote is complete.
|
||||
TODO: Include vote extensions information when implementing vote extension is complete.
|
||||
VoteExtension: []byte{},
|
||||
*/
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user