remove TODO for prepare proposal

This commit is contained in:
William Banfield
2022-03-08 16:45:04 -05:00
parent 6a085d6077
commit 333b25cfbe
3 changed files with 4 additions and 4 deletions

View File

@@ -433,9 +433,6 @@ func (app *Application) execPrepareTx(tx []byte) *types.ExecTxResult {
// substPrepareTx subst all the preparetx in the blockdata
// to null string(could be any arbitrary string).
func (app *Application) substPrepareTx(blockData [][]byte) []*types.TxRecord {
// TODO: this mechanism will change with the current spec of PrepareProposal
// We now have a special type for marking a tx as changed
trs := make([]*types.TxRecord, len(blockData))
for i, tx := range blockData {
if isPrepareTx(tx) {

View File

@@ -251,6 +251,9 @@ func (rpp *ResponsePrepareProposal) Validate(maxSizeBytes int64, otxs [][]byte)
if !rpp.ModifiedTx {
// This method currently only checks the validity of the TxRecords field.
// If ModifiedTx is false, then we can ignore the validity of the TxRecords field.
//
// TODO: When implementing VoteExensions, AppSignedUpdates may be modified by the application
// and this method should be updated to validate the AppSignedUpdates.
return nil
}

View File

@@ -429,7 +429,7 @@ func extendedCommitInfo(c abci.CommitInfo) abci.ExtendedCommitInfo {
Validator: c.Votes[i].Validator,
SignedLastBlock: c.Votes[i].SignedLastBlock,
/*
TODO: Include extended vote information once vote extension vote is complete.
TODO: Include vote extensions information when implementing vote extension is complete.
VoteExtension: []byte{},
*/
}