mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-02-08 04:50:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only set vote extension signatures when signing is successful

Browse Source 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
This commit is contained in:
Thane Thomson
2022-04-12 13:53:32 -04:00
parent b054c42b03
commit 35aa879c7e
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
privval/file.go
View File

@@ -405,10 +405,11 @@ func (pv *FilePV) signVote(chainID string, vote *tmproto.Vote) error {
vote.Signature = sig
// Sign the vote extension, regardless of whether it's present or not
vote.ExtensionSignature, err = pv.Key.PrivKey.Sign(extSignBytes)
extSig, err := pv.Key.PrivKey.Sign(extSignBytes)
if err != nil {
return err
}
vote.ExtensionSignature = extSig
return nil
}

8
types/priv_validator.go
View File

@@ -96,8 +96,12 @@ func (pv MockPV) SignVote(ctx context.Context, chainID string, vote *tmproto.Vot
return err
}
vote.Signature = sig
vote.ExtensionSignature, err = pv.PrivKey.Sign(extSignBytes)
return err
extSig, err := pv.PrivKey.Sign(extSignBytes)
if err != nil {
return err
}
vote.ExtensionSignature = extSig
return nil
}
// Implements PrivValidator.