mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-06-02 04:16:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #94 from Liamsi/const_time

Browse Source 
Use constant-time comparator to compare signatures
This commit is contained in:
Ethan Buchman
2018-05-30 18:27:05 -04:00
committed by GitHub
parent 20fdec6c0e 94ce56d243
commit 434759e17b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
signature.go
View File

@@ -1,9 +1,10 @@
package crypto
import (
"bytes"
"fmt"
"crypto/subtle"
. "github.com/tendermint/tmlibs/common"
)
@@ -41,7 +42,7 @@ func (sig SignatureEd25519) String() string { return fmt.Sprintf("/%X.../", Fing
func (sig SignatureEd25519) Equals(other Signature) bool {
if otherEd, ok := other.(SignatureEd25519); ok {
return bytes.Equal(sig[:], otherEd[:])
return subtle.ConstantTimeCompare(sig[:], otherEd[:]) == 1
} else {
return false
}
@@ -74,7 +75,7 @@ func (sig SignatureSecp256k1) String() string { return fmt.Sprintf("/%X.../", Fi
func (sig SignatureSecp256k1) Equals(other Signature) bool {
if otherSecp, ok := other.(SignatureSecp256k1); ok {
return bytes.Equal(sig[:], otherSecp[:])
return subtle.ConstantTimeCompare(sig[:], otherSecp[:]) == 1
} else {
return false
}