mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-04-22 08:40:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

avoid first person

Browse Source
This commit is contained in:
tycho garen
2021-06-14 08:55:58 -04:00
parent bfa8ac334b
commit 46863a30a2
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
docs/architecture/adr-069-flexible-node-intitalization.md
View File

@@ -23,11 +23,11 @@ cases.
## Observations
To prepare for this work I've been playing in [this
branch](https://github.com/tendermint/tendermint/tree/tychoish/scratch-node-minimize),
with the node implementation to see if, without making major
modifications or changing interfaces, what aspects could be
simplified. My conclusions, generally:
To prepare for this work [this
branch](https://github.com/tendermint/tendermint/tree/tychoish/scratch-node-minimize)
contains some experimentation with the node implementation to see if,
without making major modifications or changing interfaces, what
aspects could be simplified. To summarize, generally:
- The implementation of the `node` service, doesn't really need the
ability to introspect the implementations of reactors in most
@@ -44,8 +44,8 @@ simplified. My conclusions, generally:
Ideally, it seems like a node instance should be expressable simply as
a list of `service.Services` and any knowledge of the internals of any
of these services could be limited to their constructors. I sketched
out a generic and simple `groupService` implementation, to handle a
of these services could be limited to their constructors. There is a
sketch of a generic and simple `groupService` implementation, to handle a
desecrate stage or sequence of services. As some services have
dependencies during construction or initialization and as a starting
point, a cluster of dependencies can be wrapped as a single