mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-09 22:47:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: disable TestPEXReactorSeedModeFlushStop due to flake (#5996)

Browse Source 
This test occasionally fails because the peer is already stopped. It is unclear to me exactly what this test is supposed to do, since calling `FlushStop()` will stop the peer, but the test asserts that the peer shouldn't have been stopped by `FlushStop()` since calling `Stop()` afterwards will error in that case.

The current PEX reactor will be removed in the new P2P stack anyway.
This commit is contained in:
Erik Grinaker
2021-01-27 21:05:37 +01:00
committed by GitHub
parent 6e3c58204a
commit 4dca066aab
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
p2p/pex/pex_reactor_test.go
View File

@@ -376,6 +376,7 @@ func TestPEXReactorDialsPeerUpToMaxAttemptsInSeedMode(t *testing.T) {
// with FlushStop. Before a fix, this non-deterministically reproduced
// https://github.com/tendermint/tendermint/issues/3231.
func TestPEXReactorSeedModeFlushStop(t *testing.T) {
t.Skip("flaky test, will be replaced by new P2P stack")
N := 2
switches := make([]*p2p.Switch, N)