mirrors/tendermint
1
0
Fork 0
mirror of https://github.com/tendermint/tendermint.git synced 2026-01-05 04:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

rpc: fix mock test cases (#7571)

Browse Source 
In two cases, we check for the content of an error right after asserting that
no error occurs. Fix the sense of those checks.

In one case, we check that there is no error with the diagnostic "expected
error". It's not clear whether this means "an error was expected" (which is
what I believe) or "we got the expected error". However, given the way the mock
plumbing is set up, the first interpretation seems right.
This commit is contained in:
M. J. Fromberger
2022-01-12 12:17:53 -08:00
committed by GitHub
parent 6efdba8aa9
commit 5c1399d803
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
rpc/client/mock/abci_test.go
View File

@@ -48,7 +48,7 @@ func TestABCIMock(t *testing.T) {
// now, let's try to make some calls
_, err := m.ABCIInfo(ctx)
require.NoError(t, err)
require.Error(t, err)
assert.Equal(t, "foobar", err.Error())
// query always returns the response
@@ -62,7 +62,7 @@ func TestABCIMock(t *testing.T) {
// non-commit calls always return errors
_, err = m.BroadcastTxSync(ctx, goodTx)
require.NoError(t, err)
require.Error(t, err)
assert.Equal(t, "must commit", err.Error())
_, err = m.BroadcastTxAsync(ctx, goodTx)
require.Error(t, err)
@@ -70,7 +70,7 @@ func TestABCIMock(t *testing.T) {
// commit depends on the input
_, err = m.BroadcastTxCommit(ctx, badTx)
require.NoError(t, err)
require.Error(t, err)
assert.Equal(t, "bad tx", err.Error())
bres, err := m.BroadcastTxCommit(ctx, goodTx)
require.NoError(t, err, "%+v", err)
@@ -106,7 +106,7 @@ func TestABCIRecorder(t *testing.T) {
bytes.HexBytes("data"),
client.ABCIQueryOptions{Prove: false},
)
assert.NoError(t, err, "expected error on query")
assert.Error(t, err, "expected error on query")
require.Equal(t, 2, len(r.Calls))
info := r.Calls[0]